mbox series

[0/5] tcg: Restrict tcg_out_op() to arrays of TCG_MAX_OP_ARGS elements

Message ID 20210111150114.1415930-1-f4bug@amsat.org (mailing list archive)
Headers show
Series tcg: Restrict tcg_out_op() to arrays of TCG_MAX_OP_ARGS elements | expand

Message

Philippe Mathieu-Daudé Jan. 11, 2021, 3:01 p.m. UTC 
Attempt to fix the warning reported by Miroslav using GCC 10:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg771520.html

Philippe Mathieu-Daudé (5):
  tcg/arm: Hoist common argument loads in tcg_out_op()
  tcg/ppc: Hoist common argument loads in tcg_out_op()
  tcg/s390: Hoist common argument loads in tcg_out_op()
  tcg: Restrict tcg_out_op() to arrays of TCG_MAX_OP_ARGS elements
  tcg: Restrict tcg_out_vec_op() to arrays of TCG_MAX_OP_ARGS elements

 tcg/tcg.c                    |  19 ++-
 tcg/aarch64/tcg-target.c.inc |   3 +-
 tcg/arm/tcg-target.c.inc     | 173 ++++++++++----------
 tcg/i386/tcg-target.c.inc    |   6 +-
 tcg/mips/tcg-target.c.inc    |   3 +-
 tcg/ppc/tcg-target.c.inc     | 297 +++++++++++++++++------------------
 tcg/riscv/tcg-target.c.inc   |   3 +-
 tcg/s390/tcg-target.c.inc    | 252 ++++++++++++++---------------
 tcg/tci/tcg-target.c.inc     |   5 +-
 9 files changed, 372 insertions(+), 389 deletions(-)

Comments

Richard Henderson Jan. 11, 2021, 5:22 p.m. UTC | #1 
On 1/11/21 5:01 AM, Philippe Mathieu-Daudé wrote:
> Attempt to fix the warning reported by Miroslav using GCC 10:
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg771520.html
> 
> Philippe Mathieu-Daudé (5):
>   tcg/arm: Hoist common argument loads in tcg_out_op()
>   tcg/ppc: Hoist common argument loads in tcg_out_op()
>   tcg/s390: Hoist common argument loads in tcg_out_op()
>   tcg: Restrict tcg_out_op() to arrays of TCG_MAX_OP_ARGS elements
>   tcg: Restrict tcg_out_vec_op() to arrays of TCG_MAX_OP_ARGS elements

I've been trying to figure out a cleaner way to handle these, but this is
certainly ok for now, and avoids the Werror.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

Will queue to tcg-next.

r~
Philippe Mathieu-Daudé Jan. 13, 2021, 3:07 p.m. UTC | #2 
On 1/11/21 6:22 PM, Richard Henderson wrote:
> On 1/11/21 5:01 AM, Philippe Mathieu-Daudé wrote:
>> Attempt to fix the warning reported by Miroslav using GCC 10:
>> https://www.mail-archive.com/qemu-devel@nongnu.org/msg771520.html
>>
>> Philippe Mathieu-Daudé (5):
>>   tcg/arm: Hoist common argument loads in tcg_out_op()
>>   tcg/ppc: Hoist common argument loads in tcg_out_op()
>>   tcg/s390: Hoist common argument loads in tcg_out_op()
>>   tcg: Restrict tcg_out_op() to arrays of TCG_MAX_OP_ARGS elements
>>   tcg: Restrict tcg_out_vec_op() to arrays of TCG_MAX_OP_ARGS elements
> 
> I've been trying to figure out a cleaner way to handle these, but this is
> certainly ok for now, and avoids the Werror.
> 
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> 
> Will queue to tcg-next.

Please hold on, Miroslav found a regression in the PPC patch.
Richard Henderson Jan. 13, 2021, 6:34 p.m. UTC | #3 
On 1/13/21 5:07 AM, Philippe Mathieu-Daudé wrote:
> On 1/11/21 6:22 PM, Richard Henderson wrote:
>> On 1/11/21 5:01 AM, Philippe Mathieu-Daudé wrote:
>>> Attempt to fix the warning reported by Miroslav using GCC 10:
>>> https://www.mail-archive.com/qemu-devel@nongnu.org/msg771520.html
>>>
>>> Philippe Mathieu-Daudé (5):
>>>   tcg/arm: Hoist common argument loads in tcg_out_op()
>>>   tcg/ppc: Hoist common argument loads in tcg_out_op()
>>>   tcg/s390: Hoist common argument loads in tcg_out_op()
>>>   tcg: Restrict tcg_out_op() to arrays of TCG_MAX_OP_ARGS elements
>>>   tcg: Restrict tcg_out_vec_op() to arrays of TCG_MAX_OP_ARGS elements
>>
>> I've been trying to figure out a cleaner way to handle these, but this is
>> certainly ok for now, and avoids the Werror.
>>
>> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>>
>> Will queue to tcg-next.
> 
> Please hold on, Miroslav found a regression in the PPC patch.
> 

I had found the trivial s390 one during regression and fixed it.  But I'll
dequeue for the ppc one and let you re-post.


r~