mbox series

[0/3] hw: Constify VMStateDescription

Message ID 20210313171150.2122409-1-f4bug@amsat.org (mailing list archive)
Headers show
Series hw: Constify VMStateDescription | expand

Message

Philippe Mathieu-Daudé March 13, 2021, 5:11 p.m. UTC 
VMStateDescription isn't supposed to be modified.

Philippe Mathieu-Daudé (3):
  hw/arm: Constify VMStateDescription
  hw/display/qxl: Constify VMStateDescription
  hw/usb: Constify VMStateDescription

 hw/arm/highbank.c             | 2 +-
 hw/arm/pxa2xx_pic.c           | 2 +-
 hw/arm/spitz.c                | 4 ++--
 hw/arm/strongarm.c            | 2 +-
 hw/arm/z2.c                   | 4 ++--
 hw/display/qxl.c              | 8 ++++----
 hw/dma/pxa2xx_dma.c           | 4 ++--
 hw/misc/mst_fpga.c            | 2 +-
 hw/usb/ccid-card-passthru.c   | 2 +-
 hw/usb/dev-smartcard-reader.c | 8 ++++----
 10 files changed, 19 insertions(+), 19 deletions(-)

Comments

Richard Henderson March 13, 2021, 5:24 p.m. UTC | #1 
On 3/13/21 11:11 AM, Philippe Mathieu-Daudé wrote:
> Philippe Mathieu-Daudé (3):
>    hw/arm: Constify VMStateDescription
>    hw/display/qxl: Constify VMStateDescription
>    hw/usb: Constify VMStateDescription

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~
zhukeqian March 15, 2021, 9:05 a.m. UTC | #2 
Hi Philippe,

It seems that vmstate_ecc_state and vmstate_x86_cpu can also be constified.
Found by <git grep "VMStateDescription" | grep -v "const">.

Thanks,
Keqian

On 2021/3/14 1:11, Philippe Mathieu-Daudé wrote:
> VMStateDescription isn't supposed to be modified.
> 
> 
> 
> Philippe Mathieu-Daudé (3):
> 
>   hw/arm: Constify VMStateDescription
> 
>   hw/display/qxl: Constify VMStateDescription
> 
>   hw/usb: Constify VMStateDescription
> 
> 
> 
>  hw/arm/highbank.c             | 2 +-
> 
>  hw/arm/pxa2xx_pic.c           | 2 +-
> 
>  hw/arm/spitz.c                | 4 ++--
> 
>  hw/arm/strongarm.c            | 2 +-
> 
>  hw/arm/z2.c                   | 4 ++--
> 
>  hw/display/qxl.c              | 8 ++++----
> 
>  hw/dma/pxa2xx_dma.c           | 4 ++--
> 
>  hw/misc/mst_fpga.c            | 2 +-
> 
>  hw/usb/ccid-card-passthru.c   | 2 +-
> 
>  hw/usb/dev-smartcard-reader.c | 8 ++++----
> 
>  10 files changed, 19 insertions(+), 19 deletions(-)
> 
> 
>
Philippe Mathieu-Daudé April 8, 2021, 1:22 p.m. UTC | #3 
On 3/15/21 10:05 AM, Keqian Zhu wrote:
> Hi Philippe,
> 
> It seems that vmstate_ecc_state and vmstate_x86_cpu can also be constified.
> Found by <git grep "VMStateDescription" | grep -v "const">.

Correct (I only searched for the static ones).

Do you mind sending a patch?

> 
> Thanks,
> Keqian
> 
> On 2021/3/14 1:11, Philippe Mathieu-Daudé wrote:
>> VMStateDescription isn't supposed to be modified.
zhukeqian April 8, 2021, 1:46 p.m. UTC | #4 
On 2021/4/8 21:22, Philippe Mathieu-Daudé wrote:
> On 3/15/21 10:05 AM, Keqian Zhu wrote:
>> Hi Philippe,
>>
>> It seems that vmstate_ecc_state and vmstate_x86_cpu can also be constified.
>> Found by <git grep "VMStateDescription" | grep -v "const">.
> 
> Correct (I only searched for the static ones).
> 
> Do you mind sending a patch?
OK, I'll do. :)

BRs,
Keqian

> 
>>
>> Thanks,
>> Keqian
>>
>> On 2021/3/14 1:11, Philippe Mathieu-Daudé wrote:
>>> VMStateDescription isn't supposed to be modified.
> .
>