Message ID | 20210427150824.638359-1-kraxel@redhat.com (mailing list archive) |
---|---|
Headers | show |
Series | edid: windows fixes | expand |
Patchew URL: https://patchew.org/QEMU/20210427150824.638359-1-kraxel@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210427150824.638359-1-kraxel@redhat.com Subject: [PATCH v2 0/8] edid: windows fixes === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20210427150824.638359-1-kraxel@redhat.com -> patchew/20210427150824.638359-1-kraxel@redhat.com Switched to a new branch 'test' b31a1b5 edid: add support for DisplayID extension (5k resolution) e399779 edid: allow arbitrary-length checksums 9491d39 edid: move timing generation into a separate function ae580e9 edid: Make refresh rate configurable 241f41b edid: use dta extension block descriptors befe944 edid: move xtra3 descriptor e031225 edid: edid_desc_next fd14046 qemu-edid: use qemu_edid_size() === OUTPUT BEGIN === 1/8 Checking commit fd14046ca07b (qemu-edid: use qemu_edid_size()) 2/8 Checking commit e031225d558f (edid: edid_desc_next) 3/8 Checking commit befe94451d11 (edid: move xtra3 descriptor) 4/8 Checking commit 241f41bfe772 (edid: use dta extension block descriptors) 5/8 Checking commit ae580e9b2d33 (edid: Make refresh rate configurable) WARNING: line over 80 characters #33: FILE: hw/display/edid-generate.c:239: + uint64_t clock = (uint64_t)refresh_rate * (xres + xblank) * (yres + yblank); ERROR: Macros with complex values should be enclosed in parenthesis #78: FILE: include/hw/display/edid.h:25: +#define DEFINE_EDID_PROPERTIES(_state, _edid_info) \ + DEFINE_PROP_UINT32("xres", _state, _edid_info.prefx, 0), \ + DEFINE_PROP_UINT32("yres", _state, _edid_info.prefy, 0), \ + DEFINE_PROP_UINT32("xmax", _state, _edid_info.maxx, 0), \ + DEFINE_PROP_UINT32("ymax", _state, _edid_info.maxy, 0), \ + DEFINE_PROP_UINT32("refresh_rate", _state, _edid_info.refresh_rate, 0) total: 1 errors, 1 warnings, 57 lines checked Patch 5/8 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/8 Checking commit 9491d3944b98 (edid: move timing generation into a separate function) 7/8 Checking commit e39977915fbb (edid: allow arbitrary-length checksums) 8/8 Checking commit b31a1b5618ad (edid: add support for DisplayID extension (5k resolution)) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20210427150824.638359-1-kraxel@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com