Message ID | 20210428170410.479308-1-f4bug@amsat.org (mailing list archive) |
---|---|
Headers | show |
Series | target/mips: Re-org to allow KVM-only builds | expand |
Patchew URL: https://patchew.org/QEMU/20210428170410.479308-1-f4bug@amsat.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210428170410.479308-1-f4bug@amsat.org Subject: [PATCH v4 00/30] target/mips: Re-org to allow KVM-only builds === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20210428170410.479308-1-f4bug@amsat.org -> patchew/20210428170410.479308-1-f4bug@amsat.org Switched to a new branch 'test' a0db0e0 gitlab-ci: Add KVM mips64el cross-build jobs 55de33a hw/mips: Restrict non-virtualized machines to TCG b6367df target/mips: Move TCG source files under tcg/ sub directory ea881c7 target/mips: Move CP0 helpers to sysemu/cp0.c ce95d25 target/mips: Move exception management code to exception.c 8cd822c target/mips: Move TLB management helpers to tcg/sysemu/tlb_helper.c 418c944 target/mips: Move helper_cache() to tcg/sysemu/special_helper.c b764a38 target/mips: Move Special opcodes to tcg/sysemu/special_helper.c 523789c target/mips: Restrict CPUMIPSTLBContext::map_address() handlers scope e886f40 target/mips: Move tlb_helper.c to tcg/sysemu/ aabf737 target/mips: Restrict mmu_init() to TCG 2718093 target/mips: Move sysemu TCG-specific code to tcg/sysemu/ subfolder 6d251ed target/mips: Restrict cpu_mips_get_random() / update_pagemask() to TCG 3f98aa1 target/mips: Move physical addressing code to sysemu/physaddr.c b8472f3 target/mips: Move sysemu specific files under sysemu/ subfolder 8c58af3 target/mips: Move cpu_signal_handler definition around b33009b target/mips: Add simple user-mode mips_cpu_tlb_fill() 3cbbb41 target/mips: Add simple user-mode mips_cpu_do_interrupt() d9c2b79 target/mips: Introduce tcg-internal.h for TCG specific declarations 9dbf6bd meson: Introduce meson_user_arch source set for arch-specific user-mode bce7e3c target/mips: Extract load/store helpers to ldst_helper.c e604b2d target/mips: Merge do_translate_address into cpu_mips_translate_address 458e7d6 target/mips: Declare mips_env_set_pc() inlined in "internal.h" f9b4d43 target/mips: Turn printfpr() macro into a proper function 0ae0222 target/mips: Restrict mips_cpu_dump_state() to cpu.c e3bbcaf target/mips: Optimize CPU/FPU regnames[] arrays 8d5eb80 target/mips: Make CPU/FPU regnames[] arrays global 9df82db target/mips: Move msa_reset() to new source file b37df21 target/mips: Move IEEE rounding mode array to new source file 6694ecd target/mips: Simplify meson TCG rules === OUTPUT BEGIN === 1/30 Checking commit 6694ecd2dffa (target/mips: Simplify meson TCG rules) 2/30 Checking commit b37df21d05f2 (target/mips: Move IEEE rounding mode array to new source file) Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529. WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #31: new file mode 100644 total: 0 errors, 1 warnings, 39 lines checked Patch 2/30 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/30 Checking commit 9df82db76e50 (target/mips: Move msa_reset() to new source file) Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529. WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #37: new file mode 100644 total: 0 errors, 1 warnings, 70 lines checked Patch 3/30 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/30 Checking commit 8d5eb80f7bbb (target/mips: Make CPU/FPU regnames[] arrays global) 5/30 Checking commit e3bbcaf78c8a (target/mips: Optimize CPU/FPU regnames[] arrays) 6/30 Checking commit 0ae02223ffef (target/mips: Restrict mips_cpu_dump_state() to cpu.c) 7/30 Checking commit f9b4d437bc96 (target/mips: Turn printfpr() macro into a proper function) 8/30 Checking commit 458e7d6c6a84 (target/mips: Declare mips_env_set_pc() inlined in "internal.h") 9/30 Checking commit e604b2d2a872 (target/mips: Merge do_translate_address into cpu_mips_translate_address) 10/30 Checking commit bce7e3c11816 (target/mips: Extract load/store helpers to ldst_helper.c) Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529. WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #18: new file mode 100644 total: 0 errors, 1 warnings, 560 lines checked Patch 10/30 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 11/30 Checking commit 9dbf6bd26fc0 (meson: Introduce meson_user_arch source set for arch-specific user-mode) 12/30 Checking commit d9c2b79ab88d (target/mips: Introduce tcg-internal.h for TCG specific declarations) Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529. WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #54: new file mode 100644 total: 0 errors, 1 warnings, 45 lines checked Patch 12/30 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 13/30 Checking commit 3cbbb41cdf4c (target/mips: Add simple user-mode mips_cpu_do_interrupt()) Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529. WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #54: new file mode 100644 total: 0 errors, 1 warnings, 76 lines checked Patch 13/30 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/30 Checking commit b33009b5c333 (target/mips: Add simple user-mode mips_cpu_tlb_fill()) 15/30 Checking commit 8c58af3512cb (target/mips: Move cpu_signal_handler definition around) 16/30 Checking commit b8472f365da5 (target/mips: Move sysemu specific files under sysemu/ subfolder) 17/30 Checking commit 3f98aa1cf68e (target/mips: Move physical addressing code to sysemu/physaddr.c) Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529. WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #76: new file mode 100644 total: 0 errors, 1 warnings, 573 lines checked Patch 17/30 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 18/30 Checking commit 6d251ed830e4 (target/mips: Restrict cpu_mips_get_random() / update_pagemask() to TCG) 19/30 Checking commit 271809370c52 (target/mips: Move sysemu TCG-specific code to tcg/sysemu/ subfolder) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: target/mips/{ => tcg/sysemu}/cp0_helper.c | 0 total: 0 errors, 1 warnings, 371 lines checked Patch 19/30 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 20/30 Checking commit aabf7374bb8d (target/mips: Restrict mmu_init() to TCG) 21/30 Checking commit e886f40ff895 (target/mips: Move tlb_helper.c to tcg/sysemu/) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #24: target/mips/{ => tcg/sysemu}/tlb_helper.c | 3 --- total: 0 errors, 1 warnings, 59 lines checked Patch 21/30 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 22/30 Checking commit 523789ce0b5b (target/mips: Restrict CPUMIPSTLBContext::map_address() handlers scope) 23/30 Checking commit b764a3883fc5 (target/mips: Move Special opcodes to tcg/sysemu/special_helper.c) Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529. WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #194: new file mode 100644 total: 0 errors, 1 warnings, 311 lines checked Patch 23/30 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 24/30 Checking commit 418c94497f6f (target/mips: Move helper_cache() to tcg/sysemu/special_helper.c) 25/30 Checking commit 8cd822ce4eb8 (target/mips: Move TLB management helpers to tcg/sysemu/tlb_helper.c) ERROR: space prohibited after that '&' (ctx:WxW) #456: FILE: target/mips/tcg/sysemu/tlb_helper.c:71: + tlb->XI0 = (env->CP0_EntryLo0 >> CP0EnLo_XI) & 1; ^ ERROR: space prohibited after that '&' (ctx:WxW) #457: FILE: target/mips/tcg/sysemu/tlb_helper.c:72: + tlb->RI0 = (env->CP0_EntryLo0 >> CP0EnLo_RI) & 1; ^ ERROR: space prohibited after that '&' (ctx:WxW) #462: FILE: target/mips/tcg/sysemu/tlb_helper.c:77: + tlb->XI1 = (env->CP0_EntryLo1 >> CP0EnLo_XI) & 1; ^ ERROR: space prohibited after that '&' (ctx:WxW) #463: FILE: target/mips/tcg/sysemu/tlb_helper.c:78: + tlb->RI1 = (env->CP0_EntryLo1 >> CP0EnLo_RI) & 1; ^ total: 4 errors, 0 warnings, 720 lines checked Patch 25/30 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 26/30 Checking commit ce95d255679e (target/mips: Move exception management code to exception.c) Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529. WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #158: new file mode 100644 total: 0 errors, 1 warnings, 402 lines checked Patch 26/30 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 27/30 Checking commit ea881c740fbe (target/mips: Move CP0 helpers to sysemu/cp0.c) Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529. WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #161: new file mode 100644 ERROR: space prohibited after that '&' (ctx:WxW) #205: FILE: target/mips/sysemu/cp0.c:40: + cu = (v >> CP0St_CU0) & 0xf; ^ ERROR: space prohibited after that '&' (ctx:WxW) #206: FILE: target/mips/sysemu/cp0.c:41: + mx = (v >> CP0St_MX) & 0x1; ^ ERROR: space prohibited after that '&' (ctx:WxW) #207: FILE: target/mips/sysemu/cp0.c:42: + ksu = (v >> CP0St_KSU) & 0x3; ^ ERROR: space prohibited after that '&' (ctx:WxW) #234: FILE: target/mips/sysemu/cp0.c:69: + uint32_t ksux = (1 << CP0St_KX) & val; ^ ERROR: space prohibited after that '&' (ctx:WxW) #242: FILE: target/mips/sysemu/cp0.c:77: + mask &= ~(((1 << CP0St_SR) | (1 << CP0St_NMI)) & val); ^ ERROR: space prohibited after that '&' (ctx:WxW) #269: FILE: target/mips/sysemu/cp0.c:104: + mask &= ~((1 << CP0Ca_WP) & val); ^ ERROR: space prohibited after that '&' (ctx:WxW) #274: FILE: target/mips/sysemu/cp0.c:109: + if ((old ^ env->CP0_Cause) & (1 << CP0Ca_DC)) { ^ ERROR: space prohibited after that '&' (ctx:WxW) #284: FILE: target/mips/sysemu/cp0.c:119: + if ((old ^ env->CP0_Cause) & (1 << (CP0Ca_IP + i))) { ^ total: 8 errors, 1 warnings, 257 lines checked Patch 27/30 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 28/30 Checking commit b6367df8d263 (target/mips: Move TCG source files under tcg/ sub directory) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #24: target/mips/{ => tcg}/dsp_helper.c | 0 total: 0 errors, 1 warnings, 144 lines checked Patch 28/30 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 29/30 Checking commit 55de33ac3775 (hw/mips: Restrict non-virtualized machines to TCG) 30/30 Checking commit a0db0e01ff03 (gitlab-ci: Add KVM mips64el cross-build jobs) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20210428170410.479308-1-f4bug@amsat.org/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
On 4/28/21 7:03 PM, Philippe Mathieu-Daudé wrote: > TL;DR: > > This series restrict TCG-specific objects by moving them to > the tcg/ subdir. Code is moved around to satisfy 3 cases: > { generic sysemu / tcg sysemu / tcg user}. > Philippe Mathieu-Daudé (30): > target/mips: Simplify meson TCG rules > target/mips: Move IEEE rounding mode array to new source file > target/mips: Move msa_reset() to new source file > target/mips: Make CPU/FPU regnames[] arrays global > target/mips: Optimize CPU/FPU regnames[] arrays > target/mips: Restrict mips_cpu_dump_state() to cpu.c > target/mips: Turn printfpr() macro into a proper function > target/mips: Declare mips_env_set_pc() inlined in "internal.h" > target/mips: Merge do_translate_address into > cpu_mips_translate_address > target/mips: Extract load/store helpers to ldst_helper.c > meson: Introduce meson_user_arch source set for arch-specific > user-mode > target/mips: Introduce tcg-internal.h for TCG specific declarations > target/mips: Add simple user-mode mips_cpu_do_interrupt() > target/mips: Add simple user-mode mips_cpu_tlb_fill() > target/mips: Move cpu_signal_handler definition around > target/mips: Move sysemu specific files under sysemu/ subfolder > target/mips: Move physical addressing code to sysemu/physaddr.c > target/mips: Restrict cpu_mips_get_random() / update_pagemask() to TCG > target/mips: Move sysemu TCG-specific code to tcg/sysemu/ subfolder > target/mips: Restrict mmu_init() to TCG > target/mips: Move tlb_helper.c to tcg/sysemu/ > target/mips: Restrict CPUMIPSTLBContext::map_address() handlers scope > target/mips: Move Special opcodes to tcg/sysemu/special_helper.c > target/mips: Move helper_cache() to tcg/sysemu/special_helper.c > target/mips: Move TLB management helpers to tcg/sysemu/tlb_helper.c > target/mips: Move exception management code to exception.c > target/mips: Move CP0 helpers to sysemu/cp0.c > target/mips: Move TCG source files under tcg/ sub directory > hw/mips: Restrict non-virtualized machines to TCG > gitlab-ci: Add KVM mips64el cross-build jobs Thanks, series applied to mips-next tree.