[v2,0/2] mconfigptr support

Message

Rahul Pathak Oct. 25, 2021, 12:43 p.m. UTC

Patches add the mconfigptr csr support. 
mconfigptr is newly incorporated in risc-v privileged architecture
specification 1.12 version. 
priv spec 1.12.0 version check is also added.


qemu-system-riscv64 -nographic -machine virt -cpu rv64,priv_spec=v1.12.0

Changelog:

v1->v2
------
1. Added privileged architecture spec version 1.12 ("v1.12.0") check
2. Added predicate function for mconfigptr which verifies
for priv spec version v1.12.0 or higher.

Thanks
Rahul

Rahul Pathak (2):
  target/riscv: Add priv spec 1.12.0 version check
  target/riscv: csr: Implement mconfigptr CSR

 target/riscv/cpu.c      |  4 +++-
 target/riscv/cpu.h      |  1 +
 target/riscv/cpu_bits.h |  1 +
 target/riscv/csr.c      | 19 +++++++++++++++----
 4 files changed, 20 insertions(+), 5 deletions(-)

Comments

Alistair Francis Oct. 27, 2021, 2:44 a.m. UTC | #1

On Mon, Oct 25, 2021 at 10:51 PM Rahul Pathak <[e-mail]> wrote:
>
> Patches add the mconfigptr csr support.
> mconfigptr is newly incorporated in risc-v privileged architecture
> specification 1.12 version.
> priv spec 1.12.0 version check is also added.
>
>
> qemu-system-riscv64 -nographic -machine virt -cpu rv64,priv_spec=v1.12.0

Thanks for the patches!

I gave some comments in line with the code changes. Overall this looks
good, we just need to add the other v1.12.0 features.

Alistair

>
> Changelog:
>
> v1->v2
> ------
> 1. Added privileged architecture spec version 1.12 ("v1.12.0") check
> 2. Added predicate function for mconfigptr which verifies
> for priv spec version v1.12.0 or higher.
>
> Thanks
> Rahul
>
> Rahul Pathak (2):
>   target/riscv: Add priv spec 1.12.0 version check
>   target/riscv: csr: Implement mconfigptr CSR
>
>  target/riscv/cpu.c      |  4 +++-
>  target/riscv/cpu.h      |  1 +
>  target/riscv/cpu_bits.h |  1 +
>  target/riscv/csr.c      | 19 +++++++++++++++----
>  4 files changed, 20 insertions(+), 5 deletions(-)
>
> --
> 2.25.1
>
>

Rahul Pathak Oct. 28, 2021, 2:34 a.m. UTC | #2

On Wed, Oct 27, 2021 at 8:14 AM Alistair Francis <[e-mail]>
wrote:

> On Mon, Oct 25, 2021 at 10:51 PM Rahul Pathak <[e-mail]>
> wrote:
> >
> > Patches add the mconfigptr csr support.
> > mconfigptr is newly incorporated in risc-v privileged architecture
> > specification 1.12 version.
> > priv spec 1.12.0 version check is also added.
> >
> >
> > qemu-system-riscv64 -nographic -machine virt -cpu rv64,priv_spec=v1.12.0
>
> Thanks for the patches!
>
> I gave some comments in line with the code changes. Overall this looks
> good, we just need to add the other v1.12.0 features.
>
> Alistair


Thanks Alistair, I will work on the comments and send the
next version.

>
>
>
> > Changelog:
> >
> > v1->v2
> > ------
> > 1. Added privileged architecture spec version 1.12 ("v1.12.0") check
> > 2. Added predicate function for mconfigptr which verifies
> > for priv spec version v1.12.0 or higher.
> >
> > Thanks
> > Rahul
> >
> > Rahul Pathak (2):
> >   target/riscv: Add priv spec 1.12.0 version check
> >   target/riscv: csr: Implement mconfigptr CSR
> >
> >  target/riscv/cpu.c      |  4 +++-
> >  target/riscv/cpu.h      |  1 +
> >  target/riscv/cpu_bits.h |  1 +
> >  target/riscv/csr.c      | 19 +++++++++++++++----
> >  4 files changed, 20 insertions(+), 5 deletions(-)
> >
> > --
> > 2.25.1
> >
> >
>