[v2,00/10] Instantiate VT82xx functions in host device

Message

Bernhard Beschow Aug. 30, 2022, 7 p.m. UTC

v2:
* Keep the call to pci_ide_create_devs() in board code for consistency (Zoltan)
* Create rtc-time alias in board rather than in south bridge code
* Remove stale comments about PCI functions

v1:
This series instantiates all PCI functions of the VT82xx south bridges in the south bridges themselves.
For the IDE function this is especially important since its interrupt routing is configured in the
ISA function, hence doesn't make sense to instantiate it as a "Frankenstein" device. The interrupt
routing is currently hardcoded and changing that is currently not in the scope of this series.

Testing done:
* `qemu-system-ppc -machine pegasos2 -rtc base=localtime -device ati-vga,guest_hwcursor=true,romfile="" -cdrom morphos-3.17.iso -kernel morphos-3.17/boot.img`
  Boots successfully and it is possible to open games and tools.

* I was unable to test the fuloong2e board even before this series since it seems to be unfinished [1].
  A buildroot-baked kernel [2] booted but doesn't find its root partition, though the issues could be in the buildroot receipt I created.

[1] https://osdn.net/projects/qmiga/wiki/SubprojectPegasos2
[2] https://github.com/shentok/buildroot/commits/fuloong2e

Bernhard Beschow (10):
  hw/isa/vt82c686: Resolve chip-specific realize methods
  hw/isa/vt82c686: Resolve unneeded attribute
  hw/isa/vt82c686: Prefer pci_address_space() over get_system_memory()
  hw/isa/vt82c686: Reuse errp
  hw/isa/vt82c686: Instantiate IDE function in host device
  hw/isa/vt82c686: Instantiate USB functions in host device
  hw/isa/vt82c686: Instantiate PM function in host device
  hw/isa/vt82c686: Instantiate AC97 and MC97 functions in host device
  hw/isa/vt82c686: Embed RTCState in host device
  hw/isa/vt82c686: Create rtc-time alias in boards instead

 configs/devices/mips64el-softmmu/default.mak |   1 -
 hw/isa/Kconfig                               |   1 +
 hw/isa/vt82c686.c                            | 119 +++++++++++++++----
 hw/mips/fuloong2e.c                          |  21 ++--
 hw/ppc/Kconfig                               |   1 -
 hw/ppc/pegasos2.c                            |  25 ++--
 include/hw/isa/vt82c686.h                    |   2 -
 7 files changed, 115 insertions(+), 55 deletions(-)

Comments

Philippe Mathieu-Daudé Aug. 30, 2022, 9:49 p.m. UTC | #1

On 30/8/22 21:00, Bernhard Beschow wrote:
> v2:
> * Keep the call to pci_ide_create_devs() in board code for consistency (Zoltan)
> * Create rtc-time alias in board rather than in south bridge code
> * Remove stale comments about PCI functions
> 
> v1:
> This series instantiates all PCI functions of the VT82xx south bridges in the south bridges themselves.
> For the IDE function this is especially important since its interrupt routing is configured in the
> ISA function, hence doesn't make sense to instantiate it as a "Frankenstein" device. The interrupt
> routing is currently hardcoded and changing that is currently not in the scope of this series.

Excellent!

Series:
Reviewed-by: Philippe Mathieu-Daudé <[e-mail]>

Philippe Mathieu-Daudé Aug. 30, 2022, 9:49 p.m. UTC | #2

On 30/8/22 21:00, Bernhard Beschow wrote:
> v2:
> * Keep the call to pci_ide_create_devs() in board code for consistency (Zoltan)
> * Create rtc-time alias in board rather than in south bridge code
> * Remove stale comments about PCI functions
> 
> v1:
> This series instantiates all PCI functions of the VT82xx south bridges in the south bridges themselves.
> For the IDE function this is especially important since its interrupt routing is configured in the
> ISA function, hence doesn't make sense to instantiate it as a "Frankenstein" device. The interrupt
> routing is currently hardcoded and changing that is currently not in the scope of this series.

Excellent!

Series:
Reviewed-by: Philippe Mathieu-Daudé <[e-mail]>