[v2,00/52] Audio 5.1 patches

Message

Zoltán Kővágó Dec. 23, 2018, 8:51 p.m. UTC

Hi,

I've updated my audio patchset to the current git master. Other than that not
much happened since my last update [1], fixed a few small problems that I
noticed while rebasing my patches.

Please review.

[1]: https://lists.gnu.org/archive/html/qemu-devel/2016-01/msg02451.html

Kővágó, Zoltán (52):
  qapi: support alternates in OptsVisitor
  qapi: support nested structs in OptsVisitor
  qapi: qapi for audio backends
  audio: use qapi AudioFormat instead of audfmt_e
  audio: -audiodev command line option: documentation
  audio: -audiodev command line option basic implementation
  alsaaudio: port to -audiodev config
  coreaudio: port to -audiodev config
  dsoundaudio: port to -audiodev config
  noaudio: port to -audiodev config
  ossaudio: port to -audiodev config
  paaudio: port to -audiodev config
  sdlaudio: port to -audiodev config
  spiceaudio: port to -audiodev config
  wavaudio: port to -audiodev config
  audio: -audiodev command line option: cleanup
  audio: reduce glob_audio_state usage
  audio: basic support for multi backend audio
  audio: add audiodev properties to frontends
  audio: audiodev= parameters no longer optional when -audiodev present
  paaudio: do not move stream when sink/source name is specified
  paaudio: properly disconnect streams in fini_*
  audio: remove audio_MIN, audio_MAX
  audio: do not run each backend in audio_run
  paaudio: fix playback glitches
  audio: remove read and write pcm_ops
  audio: use size_t where makes sense
  audio: api for mixeng code free backends
  alsaaudio: port to the new audio backend api
  coreaudio: port to the new audio backend api
  dsoundaudio: port to the new audio backend api
  noaudio: port to the new audio backend api
  ossaudio: port to the new audio backend api
  paaudio: port to the new audio backend api
  sdlaudio: port to the new audio backend api
  spiceaudio: port to the new audio backend api
  wavaudio: port to the new audio backend api
  audio: remove remains of the old backend api
  audio: unify input and output mixeng buffer management
  audio: remove hw->samples, buffer_size_in/out pcm_ops
  audio: common rate control code for timer based outputs
  audio: split ctl_* functions into enable_* and volume_*
  audio: add mixeng option (documentation)
  audio: make mixeng optional
  paaudio: get/put_buffer functions
  audio: support more than two channels in volume setting
  audio: replace shift in audio_pcm_info with bytes_per_frame
  audio: basic support for multichannel audio
  paaudio: channel-map option
  usb-audio: do not count on avail bytes actually available
  usb-audio: support more than two channels of audio
  usbaudio: change playback counters to 64 bit

 Makefile.objs                           |    6 +-
 audio/Makefile.objs                     |    3 +-
 audio/alsaaudio.c                       |  755 ++++-------
 audio/audio.c                           | 1561 ++++++++++++-----------
 audio/audio.h                           |   78 +-
 audio/audio_int.h                       |  131 +-
 audio/audio_legacy.c                    |  342 +++++
 audio/audio_pt_int.c                    |  174 ---
 audio/audio_pt_int.h                    |   22 -
 audio/audio_template.h                  |  112 +-
 audio/audio_win_int.c                   |   18 +-
 audio/coreaudio.c                       |  198 ++-
 audio/dsound_template.h                 |   63 +-
 audio/dsoundaudio.c                     |  449 ++-----
 audio/mixeng.h                          |   11 +-
 audio/noaudio.c                         |   98 +-
 audio/ossaudio.c                        |  594 ++++-----
 audio/paaudio.c                         |  881 ++++++-------
 audio/rate_template.h                   |    2 +-
 audio/sdlaudio.c                        |  218 ++--
 audio/spiceaudio.c                      |  286 ++---
 audio/wavaudio.c                        |  158 +--
 audio/wavcapture.c                      |    8 +-
 configure                               |    5 -
 hmp-commands.hx                         |   11 +-
 hw/acpi/core.c                          |    2 +-
 hw/arm/omap2.c                          |    2 +-
 hw/audio/ac97.c                         |   13 +-
 hw/audio/adlib.c                        |    7 +-
 hw/audio/cs4231a.c                      |   11 +-
 hw/audio/es1370.c                       |   17 +-
 hw/audio/gus.c                          |    9 +-
 hw/audio/hda-codec.c                    |   35 +-
 hw/audio/lm4549.c                       |    6 +-
 hw/audio/milkymist-ac97.c               |   16 +-
 hw/audio/pcspk.c                        |    5 +-
 hw/audio/pl041.c                        |    1 +
 hw/audio/sb16.c                         |   17 +-
 hw/audio/wm8750.c                       |   14 +-
 hw/core/qdev-properties-system.c        |   57 +
 hw/display/xlnx_dp.c                    |    2 +-
 hw/input/tsc210x.c                      |    2 +-
 hw/usb/dev-audio.c                      |  460 ++++++-
 include/hw/qdev-properties.h            |    3 +
 include/qapi/opts-visitor.h             |    9 +-
 include/sysemu/replay.h                 |    4 +-
 monitor.c                               |   12 +-
 net/net.c                               |    2 +-
 numa.c                                  |    2 +-
 qapi/audio.json                         |  261 ++++
 qapi/opts-visitor.c                     |  145 ++-
 qapi/qapi-schema.json                   |    1 +
 qemu-options.hx                         |  242 +++-
 qom/object_interfaces.c                 |    2 +-
 replay/replay-audio.c                   |   16 +-
 tests/qapi-schema/qapi-schema-test.json |    9 +-
 tests/qapi-schema/qapi-schema-test.out  |    4 +
 tests/test-opts-visitor.c               |   43 +-
 ui/vnc.c                                |   41 +-
 ui/vnc.h                                |    2 +
 vl.c                                    |   11 +-
 61 files changed, 3921 insertions(+), 3748 deletions(-)
 create mode 100644 audio/audio_legacy.c
 delete mode 100644 audio/audio_pt_int.c
 delete mode 100644 audio/audio_pt_int.h
 create mode 100644 qapi/audio.json

Comments

Philippe Mathieu-Daudé Dec. 25, 2018, 10:43 a.m. UTC | #1

Hi Zoltán,

On 12/23/18 9:51 PM, Kővágó, Zoltán wrote:
> I've updated my audio patchset to the current git master. Other than that not
> much happened since my last update [1], fixed a few small problems that I
> noticed while rebasing my patches.

For a such series with refactors and typedefs changes, I recommend you
to use/setup the scripts/git.orderfile script: Headers are showed first,
then the sources, which makes review easier (no need to constantly scroll).
No need to resend, but if you have to respin, this will be appreciated.

Regards,

Phil.