| Message ID | 1524156319-11465-15-git-send-email-ian.jackson@eu.citrix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Ian, On 04/19/2018 01:45 PM, Ian Jackson wrote: > Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com> > CC: Paolo Bonzini <pbonzini@redhat.com> > CC: Markus Armbruster <armbru@redhat.com> > CC: Daniel P. Berrange <berrange@redhat.com> > CC: Michael Tokarev <mjt@tls.msk.ru> > --- > v7: New patch > --- > os-posix.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/os-posix.c b/os-posix.c > index 0f59566..d4cf466 100644 > --- a/os-posix.c > +++ b/os-posix.c > @@ -129,7 +129,7 @@ void os_set_proc_name(const char *s) > exit(1); > } > #else > - fprintf(stderr, "Change of process name not supported by your OS\n"); > + error_report("Change of process name not supported by your OS\n"); removing the trailing "\n": Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > exit(1); > #endif > } > @@ -243,7 +243,7 @@ static void change_root(void) > { > if (chroot_dir) { > if (chroot(chroot_dir) < 0) { > - fprintf(stderr, "chroot failed\n"); > + error_report("chroot failed"); > exit(1); > } > if (chdir("/")) { >
Philippe Mathieu-Daudé writes ("Re: [Qemu-devel] [PATCH 14/16] os-posix: cleanup: Replace fprintf with error_report in remaining call sites"):
> On 04/19/2018 01:45 PM, Ian Jackson wrote:
> > - fprintf(stderr, "Change of process name not supported by your OS\n");
> > + error_report("Change of process name not supported by your OS\n");
>
> removing the trailing "\n":
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Damn, missed one! Thanks :-).
Ian.
diff --git a/os-posix.c b/os-posix.c index 0f59566..d4cf466 100644 --- a/os-posix.c +++ b/os-posix.c @@ -129,7 +129,7 @@ void os_set_proc_name(const char *s) exit(1); } #else - fprintf(stderr, "Change of process name not supported by your OS\n"); + error_report("Change of process name not supported by your OS\n"); exit(1); #endif } @@ -243,7 +243,7 @@ static void change_root(void) { if (chroot_dir) { if (chroot(chroot_dir) < 0) { - fprintf(stderr, "chroot failed\n"); + error_report("chroot failed"); exit(1); } if (chdir("/")) {
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com> CC: Paolo Bonzini <pbonzini@redhat.com> CC: Markus Armbruster <armbru@redhat.com> CC: Daniel P. Berrange <berrange@redhat.com> CC: Michael Tokarev <mjt@tls.msk.ru> --- v7: New patch --- os-posix.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)