| Message ID | 1594878971-26050-8-git-send-email-bmeng.cn@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | riscv: Switch to use generic platform fw_dynamic type opensbi bios images | expand |
On Wed, Jul 15, 2020 at 11:01 PM Bin Meng <bmeng.cn@gmail.com> wrote: > > From: Bin Meng <bin.meng@windriver.com> > > At present only the generic platform fw_dynamic bios BIN images > are included in the 'make install' target for 'virt' and 'sifive_u' > machines. This updates the install blob list to include ELF images > which are needed by the 'spike' machine. > > Signed-off-by: Bin Meng <bin.meng@windriver.com> This commit should be squashed into patch 5. Do you want me to do that when applying? Alistair > > --- > > Changes in v5: > - Ship generic fw_dynamic.elf images in the Makefile > > Changes in v3: > - change fw_jump to fw_dynamic in the Makefile > > Changes in v2: > - new patch: Makefile: Ship the generic platform bios images for RISC-V > > Makefile | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index a6d6234..142c545 100644 > --- a/Makefile > +++ b/Makefile > @@ -841,7 +841,8 @@ u-boot.e500 u-boot-sam460-20100605.bin \ > qemu_vga.ndrv \ > edk2-licenses.txt \ > hppa-firmware.img \ > -opensbi-riscv32-generic-fw_dynamic.bin opensbi-riscv64-generic-fw_dynamic.bin > +opensbi-riscv32-generic-fw_dynamic.bin opensbi-riscv64-generic-fw_dynamic.bin \ > +opensbi-riscv32-generic-fw_dynamic.elf opensbi-riscv64-generic-fw_dynamic.elf > > > DESCS=50-edk2-i386-secure.json 50-edk2-x86_64-secure.json \ > -- > 2.7.4 > >
Hi Alistair, On Tue, Jul 28, 2020 at 11:37 PM Alistair Francis <alistair23@gmail.com> wrote: > > On Wed, Jul 15, 2020 at 11:01 PM Bin Meng <bmeng.cn@gmail.com> wrote: > > > > From: Bin Meng <bin.meng@windriver.com> > > > > At present only the generic platform fw_dynamic bios BIN images > > are included in the 'make install' target for 'virt' and 'sifive_u' > > machines. This updates the install blob list to include ELF images > > which are needed by the 'spike' machine. > > > > Signed-off-by: Bin Meng <bin.meng@windriver.com> > > This commit should be squashed into patch 5. I actually considered this before, and I was thinking that patch 5 is only for "fixing" the missing binaries for Spike machine, and this patch addresses the "make install" issue, hence separate patch. > > Do you want me to do that when applying? Sure, please do then if you feel this is the correct way. Regards, Bin
On Tue, Jul 28, 2020 at 8:52 AM Bin Meng <bmeng.cn@gmail.com> wrote: > > Hi Alistair, > > On Tue, Jul 28, 2020 at 11:37 PM Alistair Francis <alistair23@gmail.com> wrote: > > > > On Wed, Jul 15, 2020 at 11:01 PM Bin Meng <bmeng.cn@gmail.com> wrote: > > > > > > From: Bin Meng <bin.meng@windriver.com> > > > > > > At present only the generic platform fw_dynamic bios BIN images > > > are included in the 'make install' target for 'virt' and 'sifive_u' > > > machines. This updates the install blob list to include ELF images > > > which are needed by the 'spike' machine. > > > > > > Signed-off-by: Bin Meng <bin.meng@windriver.com> > > > > This commit should be squashed into patch 5. > > I actually considered this before, and I was thinking that patch 5 is > only for "fixing" the missing binaries for Spike machine, and this > patch addresses the "make install" issue, hence separate patch. Patch 5 creates the issue though, so I think it is worth fixing there. > > > > > Do you want me to do that when applying? > > Sure, please do then if you feel this is the correct way. This series still has regressions, so when you send a new version please squash this patch. Alistair > > Regards, > Bin
diff --git a/Makefile b/Makefile index a6d6234..142c545 100644 --- a/Makefile +++ b/Makefile @@ -841,7 +841,8 @@ u-boot.e500 u-boot-sam460-20100605.bin \ qemu_vga.ndrv \ edk2-licenses.txt \ hppa-firmware.img \ -opensbi-riscv32-generic-fw_dynamic.bin opensbi-riscv64-generic-fw_dynamic.bin +opensbi-riscv32-generic-fw_dynamic.bin opensbi-riscv64-generic-fw_dynamic.bin \ +opensbi-riscv32-generic-fw_dynamic.elf opensbi-riscv64-generic-fw_dynamic.elf DESCS=50-edk2-i386-secure.json 50-edk2-x86_64-secure.json \