| Message ID | 20181006183851.3797-1-sw@weilnetz.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | qemu-io-cmds: Fix two format strings | expand |
On 10/6/18 8:38 PM, Stefan Weil wrote: > Use %zu instead of %zd for unsigned numbers. > > This fixes two error messages from the LSTM static code analyzer: > > This argument should be of type 'ssize_t' but is of type 'unsigned long' Eventually prepend some spaces to have the difference between your statement and the analyzer output. > > Signed-off-by: Stefan Weil <sw@weilnetz.de> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > qemu-io-cmds.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/qemu-io-cmds.c b/qemu-io-cmds.c > index db0b3ee5ef..5363482213 100644 > --- a/qemu-io-cmds.c > +++ b/qemu-io-cmds.c > @@ -907,7 +907,7 @@ static int readv_f(BlockBackend *blk, int argc, char **argv) > memset(cmp_buf, pattern, qiov.size); > if (memcmp(buf, cmp_buf, qiov.size)) { > printf("Pattern verification failed at offset %" > - PRId64 ", %zd bytes\n", offset, qiov.size); > + PRId64 ", %zu bytes\n", offset, qiov.size); > ret = -EINVAL; > } > g_free(cmp_buf); > @@ -1294,7 +1294,7 @@ static void aio_read_done(void *opaque, int ret) > memset(cmp_buf, ctx->pattern, ctx->qiov.size); > if (memcmp(ctx->buf, cmp_buf, ctx->qiov.size)) { > printf("Pattern verification failed at offset %" > - PRId64 ", %zd bytes\n", ctx->offset, ctx->qiov.size); > + PRId64 ", %zu bytes\n", ctx->offset, ctx->qiov.size); > } > g_free(cmp_buf); > } >
Am 06.10.2018 um 20:38 hat Stefan Weil geschrieben: > Use %zu instead of %zd for unsigned numbers. > > This fixes two error messages from the LSTM static code analyzer: > > This argument should be of type 'ssize_t' but is of type 'unsigned long' > > Signed-off-by: Stefan Weil <sw@weilnetz.de> Thanks, applied to the block branch. Kevin
diff --git a/qemu-io-cmds.c b/qemu-io-cmds.c index db0b3ee5ef..5363482213 100644 --- a/qemu-io-cmds.c +++ b/qemu-io-cmds.c @@ -907,7 +907,7 @@ static int readv_f(BlockBackend *blk, int argc, char **argv) memset(cmp_buf, pattern, qiov.size); if (memcmp(buf, cmp_buf, qiov.size)) { printf("Pattern verification failed at offset %" - PRId64 ", %zd bytes\n", offset, qiov.size); + PRId64 ", %zu bytes\n", offset, qiov.size); ret = -EINVAL; } g_free(cmp_buf); @@ -1294,7 +1294,7 @@ static void aio_read_done(void *opaque, int ret) memset(cmp_buf, ctx->pattern, ctx->qiov.size); if (memcmp(ctx->buf, cmp_buf, ctx->qiov.size)) { printf("Pattern verification failed at offset %" - PRId64 ", %zd bytes\n", ctx->offset, ctx->qiov.size); + PRId64 ", %zu bytes\n", ctx->offset, ctx->qiov.size); } g_free(cmp_buf); }
Use %zu instead of %zd for unsigned numbers. This fixes two error messages from the LSTM static code analyzer: This argument should be of type 'ssize_t' but is of type 'unsigned long' Signed-off-by: Stefan Weil <sw@weilnetz.de> --- qemu-io-cmds.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)