| Message ID | 20190123065618.3520-19-yang.zhong@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Support Kconfig in QEMU | expand |
On 2019-01-23 07:55, Yang Zhong wrote: > Add the new configs to default-configs/hppa-sofmmu.mak. > > Signed-off-by: Yang Zhong <yang.zhong@intel.com> > --- > default-configs/hppa-softmmu.mak | 2 ++ > hw/hppa/Makefile.objs | 4 +++- > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/default-configs/hppa-softmmu.mak b/default-configs/hppa-softmmu.mak > index 4badc0521e..846e9f0ba6 100644 > --- a/default-configs/hppa-softmmu.mak > +++ b/default-configs/hppa-softmmu.mak > @@ -10,3 +10,5 @@ CONFIG_IDE_CMD646=y > # CONFIG_IDE_MMIO=y > CONFIG_VIRTIO_VGA=y > CONFIG_MC146818RTC=y > +CONFIG_HPPA=y > +CONFIG_DINO=y > diff --git a/hw/hppa/Makefile.objs b/hw/hppa/Makefile.objs > index bef241ed25..6204b74e5e 100644 > --- a/hw/hppa/Makefile.objs > +++ b/hw/hppa/Makefile.objs > @@ -1 +1,3 @@ > -obj-y += machine.o pci.o dino.o > +obj-y += pci.o > +obj-$(CONFIG_HPPA) += machine.o > +obj-$(CONFIG_DINO) += dino.o Reviewed-by: Thomas Huth <thuth@redhat.com>
On 1/22/19 10:55 PM, Yang Zhong wrote: > Add the new configs to default-configs/hppa-sofmmu.mak. > > Signed-off-by: Yang Zhong <yang.zhong@intel.com> > --- > default-configs/hppa-softmmu.mak | 2 ++ > hw/hppa/Makefile.objs | 4 +++- > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/default-configs/hppa-softmmu.mak b/default-configs/hppa-softmmu.mak > index 4badc0521e..846e9f0ba6 100644 > --- a/default-configs/hppa-softmmu.mak > +++ b/default-configs/hppa-softmmu.mak > @@ -10,3 +10,5 @@ CONFIG_IDE_CMD646=y > # CONFIG_IDE_MMIO=y > CONFIG_VIRTIO_VGA=y > CONFIG_MC146818RTC=y > +CONFIG_HPPA=y > +CONFIG_DINO=y Why CONFIG_HPPA? Isn't that implied by... > diff --git a/hw/hppa/Makefile.objs b/hw/hppa/Makefile.objs > index bef241ed25..6204b74e5e 100644 > --- a/hw/hppa/Makefile.objs > +++ b/hw/hppa/Makefile.objs > @@ -1 +1,3 @@ > -obj-y += machine.o pci.o dino.o > +obj-y += pci.o > +obj-$(CONFIG_HPPA) += machine.o ... arriving in the hw/hppa directory? What makes pci.o different from machine.o? > +obj-$(CONFIG_DINO) += dino.o My question for Alpha about a single machine type applies here as well. r~
diff --git a/default-configs/hppa-softmmu.mak b/default-configs/hppa-softmmu.mak index 4badc0521e..846e9f0ba6 100644 --- a/default-configs/hppa-softmmu.mak +++ b/default-configs/hppa-softmmu.mak @@ -10,3 +10,5 @@ CONFIG_IDE_CMD646=y # CONFIG_IDE_MMIO=y CONFIG_VIRTIO_VGA=y CONFIG_MC146818RTC=y +CONFIG_HPPA=y +CONFIG_DINO=y diff --git a/hw/hppa/Makefile.objs b/hw/hppa/Makefile.objs index bef241ed25..6204b74e5e 100644 --- a/hw/hppa/Makefile.objs +++ b/hw/hppa/Makefile.objs @@ -1 +1,3 @@ -obj-y += machine.o pci.o dino.o +obj-y += pci.o +obj-$(CONFIG_HPPA) += machine.o +obj-$(CONFIG_DINO) += dino.o
Add the new configs to default-configs/hppa-sofmmu.mak. Signed-off-by: Yang Zhong <yang.zhong@intel.com> --- default-configs/hppa-softmmu.mak | 2 ++ hw/hppa/Makefile.objs | 4 +++- 2 files changed, 5 insertions(+), 1 deletion(-)