| Message ID | 20190701112612.14758-2-philmd@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Kconfig dependencies for some MIPS machines | expand |
> From: Philippe Mathieu-Daudé <philmd@redhat.com> > Sent: Monday, July 1, 2019 1:26 PM > Subject: [PATCH v4 1/4] hw/mips: Explicit the semi-hosting feature is always required > > Disabling the semi-hosting feature leads to build failure: ... > Add a comment to avoid this feature to be disabled. Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- Reviewed-by: Aleksandar Markovic <amarkovic@wavecomp.com>
diff --git a/default-configs/mips-softmmu-common.mak b/default-configs/mips-softmmu-common.mak index e10ac4b20c..1ea47a9c2a 100644 --- a/default-configs/mips-softmmu-common.mak +++ b/default-configs/mips-softmmu-common.mak @@ -1,5 +1,8 @@ # Common mips*-softmmu CONFIG defines +# CONFIG_SEMIHOSTING is always required on this architecture +CONFIG_SEMIHOSTING=y + CONFIG_ISA_BUS=y CONFIG_PCI=y CONFIG_PCI_DEVICES=y @@ -35,7 +38,6 @@ CONFIG_MIPS_CPS=y CONFIG_MIPS_ITU=y CONFIG_R4K=y CONFIG_MALTA=y -CONFIG_SEMIHOSTING=y CONFIG_PCNET_PCI=y CONFIG_MIPSSIM=y CONFIG_ACPI_SMBUS=y
Disabling the semi-hosting feature leads to build failure: LINK mips-softmmu/qemu-system-mips /usr/bin/ld: target/mips/mips-semi.o: in function `helper_do_semihosting': target/mips/mips-semi.c:335: undefined reference to `qemu_semihosting_log_out' /usr/bin/ld: target/mips/mips-semi.c:338: undefined reference to `qemu_semihosting_log_out' collect2: error: ld returned 1 exit status Add a comment to avoid this feature to be disabled. Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- default-configs/mips-softmmu-common.mak | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)