diff mbox series

[v4,4/4] hw/mips: Express dependencies of the r4k platform with Kconfig

Message ID 20190701112612.14758-5-philmd@redhat.com (mailing list archive)
State New, archived
Headers show
Series Kconfig dependencies for some MIPS machines | expand

Commit Message

Philippe Mathieu-Daudé July 1, 2019, 11:26 a.m. UTC
This platform use standard PC devices connected to an ISA bus.
Networking is provided by a ne2000 chipset.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
v4: use 'imply' for VGA_ISA/NE2000_ISA (Thomas)

v3: remove CONFIG_NE2000_ISA (Thomas)
    add PFLASH_CFI01
---
 default-configs/mips-softmmu-common.mak |  1 -
 hw/mips/Kconfig                         | 10 ++++++++++
 2 files changed, 10 insertions(+), 1 deletion(-)

Comments

Aleksandar Markovic July 1, 2019, 12:24 p.m. UTC | #1
> From: Philippe Mathieu-Daudé <philmd@redhat.com>
> Sent: Monday, July 1, 2019 1:26 PM
> Subject: [PATCH v4 4/4] hw/mips: Express dependencies of the r4k platform with Kconfig
> 
> This platform use standard PC devices connected to an ISA bus.
> Networking is provided by a ne2000 chipset.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---

Reviewed-by: Aleksandar Markovic <amarkovic@wavecomp.com>
diff mbox series

Patch

diff --git a/default-configs/mips-softmmu-common.mak b/default-configs/mips-softmmu-common.mak
index d545987d42..da29c6c0b2 100644
--- a/default-configs/mips-softmmu-common.mak
+++ b/default-configs/mips-softmmu-common.mak
@@ -27,7 +27,6 @@  CONFIG_I8257=y
 CONFIG_PIIX4=y
 CONFIG_IDE_ISA=y
 CONFIG_IDE_PIIX=y
-CONFIG_NE2000_ISA=y
 CONFIG_PFLASH_CFI01=y
 CONFIG_I8259=y
 CONFIG_MC146818RTC=y
diff --git a/hw/mips/Kconfig b/hw/mips/Kconfig
index ab006477c7..62aa01b29e 100644
--- a/hw/mips/Kconfig
+++ b/hw/mips/Kconfig
@@ -1,5 +1,15 @@ 
 config R4K
     bool
+    select ISA_BUS
+    select SERIAL_ISA
+    select I8259
+    select I8254
+    select MC146818RTC
+    imply VGA_ISA
+    imply NE2000_ISA
+    select IDE_ISA
+    select PCKBD
+    select PFLASH_CFI01
 
 config MALTA
     bool