| Message ID | 20200129212345.20547-29-philmd@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | tests/acceptance/virtio_seg_max_adjust: Restrict it to Linux/X86 | expand |
On 29/01/2020 22.23, Philippe Mathieu-Daudé wrote: > We don't need the default options to run this test. > > This fixes errors when running a binary built with > --without-default-devices such: > > ERROR: qemu-system-arm: Unsupported NIC model: virtio-net-pci > > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > tests/acceptance/version.py | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/acceptance/version.py b/tests/acceptance/version.py > index 67c2192c93..79b923d4fc 100644 > --- a/tests/acceptance/version.py > +++ b/tests/acceptance/version.py > @@ -17,6 +17,7 @@ class Version(Test): > :avocado: tags=quick > """ > def test_qmp_human_info_version(self): > + self.vm.add_args('-nodefaults') > self.vm.launch() > res = self.vm.command('human-monitor-command', > command_line='info version') Reviewed-by: Thomas Huth <thuth@redhat.com>
On 1/29/20 7:23 PM, Philippe Mathieu-Daudé wrote: > We don't need the default options to run this test. > > This fixes errors when running a binary built with > --without-default-devices such: > > ERROR: qemu-system-arm: Unsupported NIC model: virtio-net-pci > > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > tests/acceptance/version.py | 1 + > 1 file changed, 1 insertion(+) My comments in [1] also applies for this change. So: Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com> [1] https://www.mail-archive.com/qemu-devel@nongnu.org/msg675104.html > > diff --git a/tests/acceptance/version.py b/tests/acceptance/version.py > index 67c2192c93..79b923d4fc 100644 > --- a/tests/acceptance/version.py > +++ b/tests/acceptance/version.py > @@ -17,6 +17,7 @@ class Version(Test): > :avocado: tags=quick > """ > def test_qmp_human_info_version(self): > + self.vm.add_args('-nodefaults') > self.vm.launch() > res = self.vm.command('human-monitor-command', > command_line='info version')
diff --git a/tests/acceptance/version.py b/tests/acceptance/version.py index 67c2192c93..79b923d4fc 100644 --- a/tests/acceptance/version.py +++ b/tests/acceptance/version.py @@ -17,6 +17,7 @@ class Version(Test): :avocado: tags=quick """ def test_qmp_human_info_version(self): + self.vm.add_args('-nodefaults') self.vm.launch() res = self.vm.command('human-monitor-command', command_line='info version')
We don't need the default options to run this test. This fixes errors when running a binary built with --without-default-devices such: ERROR: qemu-system-arm: Unsupported NIC model: virtio-net-pci Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- tests/acceptance/version.py | 1 + 1 file changed, 1 insertion(+)