| Message ID | 20200129212345.20547-30-philmd@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | tests/acceptance/virtio_seg_max_adjust: Restrict it to Linux/X86 | expand |
On 29/01/2020 22.23, Philippe Mathieu-Daudé wrote: > Acceptance tests can test any piece of the QEMU codebase. > As such, the directory holding them does not belong to a specific > subsystem with designated maintainers. > > Each subsystem covered by a test is welcomed to add the test path > to its section. > See for example commits 71b290e70, b11785ca2 or 5d480ddde. > > Since Eduardo, Cleber and Philippe have been reviewing the patches > on the list, add them as reviewers. > > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > Cc: Wainer dos Santos Moschetta <wainersm@redhat.com> > Wainer do you want to be listed? > --- > MAINTAINERS | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index efd3f3875f..4a3cc3f137 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -2733,6 +2733,12 @@ S: Maintained > F: tests/tcg/Makefile > F: tests/tcg/Makefile.include > > +Acceptance Tests > +R: Eduardo Habkost <ehabkost@redhat.com> > +R: Cleber Rosa <crosa@redhat.com> > +R: Philippe Mathieu-Daudé <philmd@redhat.com> > +F: tests/acceptance/ Many files under tests/acceptance/ are not covered by a maintainer at all, e.g.: $ scripts/get_maintainer.pl -f tests/acceptance/boot_linux_console.py get_maintainer.pl: No maintainers found, printing recent contributors. ... so I think it would be good to have someone who feels at least a little bit responsible to do the maintainers work here and picks up patches to put them into a pull request. Any volunteers? Thomas
On 1/30/20 6:41 AM, Thomas Huth wrote: > On 29/01/2020 22.23, Philippe Mathieu-Daudé wrote: >> Acceptance tests can test any piece of the QEMU codebase. >> As such, the directory holding them does not belong to a specific >> subsystem with designated maintainers. >> >> Each subsystem covered by a test is welcomed to add the test path >> to its section. >> See for example commits 71b290e70, b11785ca2 or 5d480ddde. >> >> Since Eduardo, Cleber and Philippe have been reviewing the patches >> on the list, add them as reviewers. >> >> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> >> --- >> Cc: Wainer dos Santos Moschetta <wainersm@redhat.com> >> Wainer do you want to be listed? Yes sir, please consider my name for reviewer of all tests/acceptance. >> --- >> MAINTAINERS | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index efd3f3875f..4a3cc3f137 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -2733,6 +2733,12 @@ S: Maintained >> F: tests/tcg/Makefile >> F: tests/tcg/Makefile.include >> >> +Acceptance Tests >> +R: Eduardo Habkost <ehabkost@redhat.com> >> +R: Cleber Rosa <crosa@redhat.com> >> +R: Philippe Mathieu-Daudé <philmd@redhat.com> >> +F: tests/acceptance/ > Many files under tests/acceptance/ are not covered by a maintainer at > all, e.g.: > > $ scripts/get_maintainer.pl -f tests/acceptance/boot_linux_console.py > get_maintainer.pl: No maintainers found, printing recent contributors. I'll maintain tests/acceptance/linux_initrd.py, that I created. Also I feel comfortable on co-maintaining tests/acceptance/avocado_qemu/. Cleber? The migration.py, virtio_version.py, version.py, virtio_seg_max_adjust.py tests can be put in my account if no one else step up. > ... so I think it would be good to have someone who feels at least a > little bit responsible to do the maintainers work here and picks up > patches to put them into a pull request. Any volunteers? Cleber has pulled the Python + Acceptance patches. Maybe we just need to turn it official in the MAINTAINERS? Thanks, Wainer > > Thomas
diff --git a/MAINTAINERS b/MAINTAINERS index efd3f3875f..4a3cc3f137 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2733,6 +2733,12 @@ S: Maintained F: tests/tcg/Makefile F: tests/tcg/Makefile.include +Acceptance Tests +R: Eduardo Habkost <ehabkost@redhat.com> +R: Cleber Rosa <crosa@redhat.com> +R: Philippe Mathieu-Daudé <philmd@redhat.com> +F: tests/acceptance/ + Documentation ------------- Build system architecture
Acceptance tests can test any piece of the QEMU codebase. As such, the directory holding them does not belong to a specific subsystem with designated maintainers. Each subsystem covered by a test is welcomed to add the test path to its section. See for example commits 71b290e70, b11785ca2 or 5d480ddde. Since Eduardo, Cleber and Philippe have been reviewing the patches on the list, add them as reviewers. Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- Cc: Wainer dos Santos Moschetta <wainersm@redhat.com> Wainer do you want to be listed? --- MAINTAINERS | 6 ++++++ 1 file changed, 6 insertions(+)