| Message ID | 20200806132106.747414-3-clg@kaod.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | aspeed: mostly cleanups and some extensions | expand |
On Thu, 6 Aug 2020 at 13:21, Cédric Le Goater <clg@kaod.org> wrote: > > The mx25l25635f is an extenstion of the mx25l25635e. It includes QPI > support, 4-Byte Address Command Set and faster transfers. See this > document for more details : > > https://www.macronix.com/Lists/ApplicationNote/Attachments/1892/AN0200V1_MGRT_MX25L25635E_25735E%20to%20MX25L25635F_25735F.pdf > > Both devices have the same 3bytes JEDEC ID: 0xc22019. They can be > distinguished with the QPIID command which is only available on > mx25l25635f. The mx25l25635f also has a longer JEDEC ID that we can > use for the model. > > Signed-off-by: Cédric Le Goater <clg@kaod.org> Reviewed-by: Joel Stanley <joel@jms.id.au> We don't have support for this one in upstream Linux. It's the one that Alexander tried to get merged by renaming the mysterious mx66l51235l. > --- > hw/block/m25p80.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c > index 605ff55c6756..1696ab1f7821 100644 > --- a/hw/block/m25p80.c > +++ b/hw/block/m25p80.c > @@ -218,6 +218,7 @@ static const FlashPartInfo known_devices[] = { > { INFO("mx25l12805d", 0xc22018, 0, 64 << 10, 256, 0) }, > { INFO("mx25l12855e", 0xc22618, 0, 64 << 10, 256, 0) }, > { INFO6("mx25l25635e", 0xc22019, 0xc22019, 64 << 10, 512, 0) }, > + { INFO("mx25l25635f", 0xc22019, 0xc200, 64 << 10, 512, 0) }, > { INFO("mx25l25655e", 0xc22619, 0, 64 << 10, 512, 0) }, > { INFO("mx66u51235f", 0xc2253a, 0, 64 << 10, 1024, ER_4K | ER_32K) }, > { INFO("mx66u1g45g", 0xc2253b, 0, 64 << 10, 2048, ER_4K | ER_32K) }, > -- > 2.25.4 >
On 8/7/20 12:55 AM, Joel Stanley wrote: > On Thu, 6 Aug 2020 at 13:21, Cédric Le Goater <clg@kaod.org> wrote: >> >> The mx25l25635f is an extenstion of the mx25l25635e. It includes QPI >> support, 4-Byte Address Command Set and faster transfers. See this >> document for more details : >> >> https://www.macronix.com/Lists/ApplicationNote/Attachments/1892/AN0200V1_MGRT_MX25L25635E_25735E%20to%20MX25L25635F_25735F.pdf >> >> Both devices have the same 3bytes JEDEC ID: 0xc22019. They can be >> distinguished with the QPIID command which is only available on >> mx25l25635f. The mx25l25635f also has a longer JEDEC ID that we can >> use for the model. >> >> Signed-off-by: Cédric Le Goater <clg@kaod.org> > > Reviewed-by: Joel Stanley <joel@jms.id.au> > > We don't have support for this one in upstream Linux. It's detected by testing the 4BYTE operation capability in the SFDP table in mx25l25635_post_bfpt_fixups() The only system I have access to is a SuperMicro P9 Boston but I can not upload a new kernel. However, the FW reports : BMC flash ID: 0xc21920c2 jedec_id: 0xc21920c2 flash type: MX25L25635F ReadClk=0x32, WriteClk=0x85, EraseClk=0x85 [smcfw_spi] cpuclk: 198000000 MHz, RefCLK: 24000000 MHz, AXI-AHB ratio: 2:1 platform_flash: MX25L25635F (32768 Kbytes) > It's the one > that Alexander tried to get merged by renaming the mysterious > mx66l51235l. Yes. That one behaves a bit more like the mx25l25635e. Difficult to find a detection pattern. A model for SFDP would help. C. > >> --- >> hw/block/m25p80.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c >> index 605ff55c6756..1696ab1f7821 100644 >> --- a/hw/block/m25p80.c >> +++ b/hw/block/m25p80.c >> @@ -218,6 +218,7 @@ static const FlashPartInfo known_devices[] = { >> { INFO("mx25l12805d", 0xc22018, 0, 64 << 10, 256, 0) }, >> { INFO("mx25l12855e", 0xc22618, 0, 64 << 10, 256, 0) }, >> { INFO6("mx25l25635e", 0xc22019, 0xc22019, 64 << 10, 512, 0) }, >> + { INFO("mx25l25635f", 0xc22019, 0xc200, 64 << 10, 512, 0) }, >> { INFO("mx25l25655e", 0xc22619, 0, 64 << 10, 512, 0) }, >> { INFO("mx66u51235f", 0xc2253a, 0, 64 << 10, 1024, ER_4K | ER_32K) }, >> { INFO("mx66u1g45g", 0xc2253b, 0, 64 << 10, 2048, ER_4K | ER_32K) }, >> -- >> 2.25.4 >>
diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c index 605ff55c6756..1696ab1f7821 100644 --- a/hw/block/m25p80.c +++ b/hw/block/m25p80.c @@ -218,6 +218,7 @@ static const FlashPartInfo known_devices[] = { { INFO("mx25l12805d", 0xc22018, 0, 64 << 10, 256, 0) }, { INFO("mx25l12855e", 0xc22618, 0, 64 << 10, 256, 0) }, { INFO6("mx25l25635e", 0xc22019, 0xc22019, 64 << 10, 512, 0) }, + { INFO("mx25l25635f", 0xc22019, 0xc200, 64 << 10, 512, 0) }, { INFO("mx25l25655e", 0xc22619, 0, 64 << 10, 512, 0) }, { INFO("mx66u51235f", 0xc2253a, 0, 64 << 10, 1024, ER_4K | ER_32K) }, { INFO("mx66u1g45g", 0xc2253b, 0, 64 << 10, 2048, ER_4K | ER_32K) },
The mx25l25635f is an extenstion of the mx25l25635e. It includes QPI support, 4-Byte Address Command Set and faster transfers. See this document for more details : https://www.macronix.com/Lists/ApplicationNote/Attachments/1892/AN0200V1_MGRT_MX25L25635E_25735E%20to%20MX25L25635F_25735F.pdf Both devices have the same 3bytes JEDEC ID: 0xc22019. They can be distinguished with the QPIID command which is only available on mx25l25635f. The mx25l25635f also has a longer JEDEC ID that we can use for the model. Signed-off-by: Cédric Le Goater <clg@kaod.org> --- hw/block/m25p80.c | 1 + 1 file changed, 1 insertion(+)