Message ID | 20210122122958.12311-3-bmeng.cn@gmail.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | hw/riscv: Clean-ups and map high mmio for PCIe of 'virt' machine | expand |
On Fri, Jan 22, 2021 at 4:32 AM Bin Meng <bmeng.cn@gmail.com> wrote: > > From: Bin Meng <bin.meng@windriver.com> > > `link_up` is never used in gpex_pcie_init(). Drop it. > > Signed-off-by: Bin Meng <bin.meng@windriver.com> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Alistair > --- > > hw/riscv/virt.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c > index cfd52bc59b..1d05bb3ef9 100644 > --- a/hw/riscv/virt.c > +++ b/hw/riscv/virt.c > @@ -449,7 +449,7 @@ static inline DeviceState *gpex_pcie_init(MemoryRegion *sys_mem, > hwaddr ecam_base, hwaddr ecam_size, > hwaddr mmio_base, hwaddr mmio_size, > hwaddr pio_base, > - DeviceState *plic, bool link_up) > + DeviceState *plic) > { > DeviceState *dev; > MemoryRegion *ecam_alias, *ecam_reg; > @@ -669,12 +669,12 @@ static void virt_machine_init(MachineState *machine) > } > > gpex_pcie_init(system_memory, > - memmap[VIRT_PCIE_ECAM].base, > - memmap[VIRT_PCIE_ECAM].size, > - memmap[VIRT_PCIE_MMIO].base, > - memmap[VIRT_PCIE_MMIO].size, > - memmap[VIRT_PCIE_PIO].base, > - DEVICE(pcie_plic), true); > + memmap[VIRT_PCIE_ECAM].base, > + memmap[VIRT_PCIE_ECAM].size, > + memmap[VIRT_PCIE_MMIO].base, > + memmap[VIRT_PCIE_MMIO].size, > + memmap[VIRT_PCIE_PIO].base, > + DEVICE(pcie_plic)); > > serial_mm_init(system_memory, memmap[VIRT_UART0].base, > 0, qdev_get_gpio_in(DEVICE(mmio_plic), UART0_IRQ), 399193, > -- > 2.25.1 > >
diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c index cfd52bc59b..1d05bb3ef9 100644 --- a/hw/riscv/virt.c +++ b/hw/riscv/virt.c @@ -449,7 +449,7 @@ static inline DeviceState *gpex_pcie_init(MemoryRegion *sys_mem, hwaddr ecam_base, hwaddr ecam_size, hwaddr mmio_base, hwaddr mmio_size, hwaddr pio_base, - DeviceState *plic, bool link_up) + DeviceState *plic) { DeviceState *dev; MemoryRegion *ecam_alias, *ecam_reg; @@ -669,12 +669,12 @@ static void virt_machine_init(MachineState *machine) } gpex_pcie_init(system_memory, - memmap[VIRT_PCIE_ECAM].base, - memmap[VIRT_PCIE_ECAM].size, - memmap[VIRT_PCIE_MMIO].base, - memmap[VIRT_PCIE_MMIO].size, - memmap[VIRT_PCIE_PIO].base, - DEVICE(pcie_plic), true); + memmap[VIRT_PCIE_ECAM].base, + memmap[VIRT_PCIE_ECAM].size, + memmap[VIRT_PCIE_MMIO].base, + memmap[VIRT_PCIE_MMIO].size, + memmap[VIRT_PCIE_PIO].base, + DEVICE(pcie_plic)); serial_mm_init(system_memory, memmap[VIRT_UART0].base, 0, qdev_get_gpio_in(DEVICE(mmio_plic), UART0_IRQ), 399193,