| Message ID | 20210323151749.21299-5-cfontana@suse.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm cleanup experiment for kvm-only build | expand |
On 3/23/21 9:16 AM, Claudio Fontana wrote: > +++ b/target/arm/tcg/sysemu/meson.build > @@ -0,0 +1,3 @@ > + > +arm_softmmu_ss.add(when: ['CONFIG_TCG','CONFIG_SOFTMMU'], if_true: files( > +)) Blank lines at the start of each new file? Otherwise, Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
On 3/23/21 9:16 AM, Claudio Fontana wrote: > +arm_softmmu_ss.add(when: ['CONFIG_TCG','CONFIG_SOFTMMU'], if_true: files( > +)) > diff --git a/target/arm/tcg/user/meson.build b/target/arm/tcg/user/meson.build > new file mode 100644 > index 0000000000..d70a51ea9a > --- /dev/null > +++ b/target/arm/tcg/user/meson.build > @@ -0,0 +1,3 @@ > + > +arm_user_ss.add(when: ['CONFIG_TCG','CONFIG_USER_ONLY'], if_true: files( Actually, surely the CONFIG_USER_ONLY and CONFIG_SOFTMMU tests are redundant with the variables, as they are eventually added to target_softmmu_arch and target_user_arch. r~
On 3/24/21 7:18 PM, Richard Henderson wrote: > On 3/23/21 9:16 AM, Claudio Fontana wrote: >> +arm_softmmu_ss.add(when: ['CONFIG_TCG','CONFIG_SOFTMMU'], if_true: files( >> +)) >> diff --git a/target/arm/tcg/user/meson.build b/target/arm/tcg/user/meson.build >> new file mode 100644 >> index 0000000000..d70a51ea9a >> --- /dev/null >> +++ b/target/arm/tcg/user/meson.build >> @@ -0,0 +1,3 @@ >> + >> +arm_user_ss.add(when: ['CONFIG_TCG','CONFIG_USER_ONLY'], if_true: files( > > Actually, surely the CONFIG_USER_ONLY and CONFIG_SOFTMMU tests are redundant > with the variables, as they are eventually added to target_softmmu_arch and > target_user_arch. > > > r~ > Yes, good point, needs fixing.
diff --git a/target/arm/tcg/meson.build b/target/arm/tcg/meson.build index 3b4146d079..abc9d27b63 100644 --- a/target/arm/tcg/meson.build +++ b/target/arm/tcg/meson.build @@ -36,3 +36,6 @@ arm_ss.add(when: ['TARGET_AARCH64','CONFIG_TCG'], if_true: files( 'pauth_helper.c', 'sve_helper.c', )) + +subdir('user') +subdir('sysemu') diff --git a/target/arm/tcg/sysemu/meson.build b/target/arm/tcg/sysemu/meson.build new file mode 100644 index 0000000000..bc11678a0a --- /dev/null +++ b/target/arm/tcg/sysemu/meson.build @@ -0,0 +1,3 @@ + +arm_softmmu_ss.add(when: ['CONFIG_TCG','CONFIG_SOFTMMU'], if_true: files( +)) diff --git a/target/arm/tcg/user/meson.build b/target/arm/tcg/user/meson.build new file mode 100644 index 0000000000..d70a51ea9a --- /dev/null +++ b/target/arm/tcg/user/meson.build @@ -0,0 +1,3 @@ + +arm_user_ss.add(when: ['CONFIG_TCG','CONFIG_USER_ONLY'], if_true: files( +))