| Message ID | 20210531073255.46286-1-thuth@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | hw/display/macfb: Classify the "nubus-macfb" as display device | expand |
Le 31/05/2021 à 09:32, Thomas Huth a écrit : > The "nubus-macfb" currently shows up as uncategorized device in > the output of "-device help". Put it into the display category > to fix this ugliness. > > Signed-off-by: Thomas Huth <thuth@redhat.com> > --- > hw/display/macfb.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/display/macfb.c b/hw/display/macfb.c > index ff8bdb846b..d8183b9bbd 100644 > --- a/hw/display/macfb.c > +++ b/hw/display/macfb.c > @@ -450,6 +450,7 @@ static void macfb_nubus_class_init(ObjectClass *klass, void *data) > dc->desc = "Nubus Macintosh framebuffer"; > dc->reset = macfb_nubus_reset; > dc->vmsd = &vmstate_macfb; > + set_bit(DEVICE_CATEGORY_DISPLAY, dc->categories); > device_class_set_props(dc, macfb_nubus_properties); > } > > Reviewed-by: Laurent Vivier <laurent@vivier.eu>
On 5/31/21 9:32 AM, Thomas Huth wrote: > The "nubus-macfb" currently shows up as uncategorized device in > the output of "-device help". Put it into the display category > to fix this ugliness. > > Signed-off-by: Thomas Huth <thuth@redhat.com> > --- > hw/display/macfb.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Le 31/05/2021 à 09:32, Thomas Huth a écrit : > The "nubus-macfb" currently shows up as uncategorized device in > the output of "-device help". Put it into the display category > to fix this ugliness. > > Signed-off-by: Thomas Huth <thuth@redhat.com> > --- > hw/display/macfb.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/display/macfb.c b/hw/display/macfb.c > index ff8bdb846b..d8183b9bbd 100644 > --- a/hw/display/macfb.c > +++ b/hw/display/macfb.c > @@ -450,6 +450,7 @@ static void macfb_nubus_class_init(ObjectClass *klass, void *data) > dc->desc = "Nubus Macintosh framebuffer"; > dc->reset = macfb_nubus_reset; > dc->vmsd = &vmstate_macfb; > + set_bit(DEVICE_CATEGORY_DISPLAY, dc->categories); > device_class_set_props(dc, macfb_nubus_properties); > } > > Applied to my trivial-patches branch. Thanks, Laurent
diff --git a/hw/display/macfb.c b/hw/display/macfb.c index ff8bdb846b..d8183b9bbd 100644 --- a/hw/display/macfb.c +++ b/hw/display/macfb.c @@ -450,6 +450,7 @@ static void macfb_nubus_class_init(ObjectClass *klass, void *data) dc->desc = "Nubus Macintosh framebuffer"; dc->reset = macfb_nubus_reset; dc->vmsd = &vmstate_macfb; + set_bit(DEVICE_CATEGORY_DISPLAY, dc->categories); device_class_set_props(dc, macfb_nubus_properties); }
The "nubus-macfb" currently shows up as uncategorized device in the output of "-device help". Put it into the display category to fix this ugliness. Signed-off-by: Thomas Huth <thuth@redhat.com> --- hw/display/macfb.c | 1 + 1 file changed, 1 insertion(+)