target/ppc, hw/ppc: Change maintainers

Commit Message

David Gibson Nov. 5, 2021, 3:46 a.m. UTC

As our day jobs and interests have moved onto other things, Greg and I have
been struggling to keep on top of maintainership of target/ppc and
associated pieces like the pseries and powernv machine types, with their
platform specific devices.

We've therefore discussed and plan to transfer maintainership to Cédric Le
Goater (primary) and Daniel Henrique Barboza (backup).  Cédric and Daniel
have been actively contributing to the area for some time, and they're
supported in this by their current employer, IBM, who has an obvious
interest in the platform.

Greg and I do plan to stay around in some capacity for at least the next
6 months, providing reviews and advice to assist the new maintainers into
the role.

Signed-off-by: David Gibson <[e-mail]>
---
 MAINTAINERS | 20 ++++++++++++++------
 1 file changed, 14 insertions(+), 6 deletions(-)

Comments

Daniel Henrique Barboza Nov. 5, 2021, 9:48 a.m. UTC | #1

On 11/5/21 00:46, David Gibson wrote:
> As our day jobs and interests have moved onto other things, Greg and I have
> been struggling to keep on top of maintainership of target/ppc and
> associated pieces like the pseries and powernv machine types, with their
> platform specific devices.
> 
> We've therefore discussed and plan to transfer maintainership to Cédric Le
> Goater (primary) and Daniel Henrique Barboza (backup).  Cédric and Daniel
> have been actively contributing to the area for some time, and they're
> supported in this by their current employer, IBM, who has an obvious
> interest in the platform.

Thank you and Greg and Red Hat for all the years of service supporting
qemu-ppc in the community. IBM will shoulder this responsibility now.

> 
> Greg and I do plan to stay around in some capacity for at least the next
> 6 months, providing reviews and advice to assist the new maintainers into
> the role.

I hope both of you stay around way longer than that :)



Reviewed-by: Daniel Henrique Barboza <[e-mail]>

> 
> Signed-off-by: David Gibson <[e-mail]>
> ---
>   MAINTAINERS | 20 ++++++++++++++------
>   1 file changed, 14 insertions(+), 6 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 797be5b366..066c4fb2b0 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -262,8 +262,10 @@ F: hw/openrisc/
>   F: tests/tcg/openrisc/
>   
>   PowerPC TCG CPUs
> -M: David Gibson <[e-mail]>
> -M: Greg Kurz <[e-mail]>
> +M: Cédric Le Goater <[e-mail]>
> +M: Daniel Henrique Barboza <[e-mail]>
> +R: David Gibson <[e-mail]>
> +R: Greg Kurz <[e-mail]>
>   L: [e-mail]
>   S: Maintained
>   F: target/ppc/
> @@ -382,8 +384,10 @@ F: target/mips/kvm*
>   F: target/mips/sysemu/
>   
>   PPC KVM CPUs
> -M: David Gibson <[e-mail]>
> -M: Greg Kurz <[e-mail]>
> +M: Cédric Le Goater <[e-mail]>
> +M: Daniel Henrique Barboza <[e-mail]>
> +R: David Gibson <[e-mail]>
> +R: Greg Kurz <[e-mail]>
>   S: Maintained
>   F: target/ppc/kvm.c
>   
> @@ -1321,8 +1325,10 @@ F: include/hw/rtc/m48t59.h
>   F: tests/acceptance/ppc_prep_40p.py
>   
>   sPAPR
> -M: David Gibson <[e-mail]>
> -M: Greg Kurz <[e-mail]>
> +M: Cédric Le Goater <[e-mail]>
> +M: Daniel Henrique Barboza <[e-mail]>
> +R: David Gibson <[e-mail]>
> +R: Greg Kurz <[e-mail]>
>   L: [e-mail]
>   S: Maintained
>   F: hw/*/spapr*
> @@ -1382,6 +1388,8 @@ F: include/hw/pci-host/mv64361.h
>   
>   Virtual Open Firmware (VOF)
>   M: Alexey Kardashevskiy <[e-mail]>
> +R: Cédric Le Goater <[e-mail]>
> +R: Daniel Henrique Barboza <[e-mail]>
>   R: David Gibson <[e-mail]>
>   R: Greg Kurz <[e-mail]>
>   L: [e-mail]
>

Cédric Le Goater Nov. 5, 2021, 1:54 p.m. UTC | #2

On 11/5/21 04:46, David Gibson wrote:
> As our day jobs and interests have moved onto other things, Greg and I have
> been struggling to keep on top of maintainership of target/ppc and
> associated pieces like the pseries and powernv machine types, with their
> platform specific devices.
> 
> We've therefore discussed and plan to transfer maintainership to Cédric Le
> Goater (primary) and Daniel Henrique Barboza (backup).  Cédric and Daniel
> have been actively contributing to the area for some time, and they're
> supported in this by their current employer, IBM, who has an obvious
> interest in the platform.


IBM business has changed focus and pseries/KVM will be less in
the spotlights. Nevertheless, there is a large code base we want
to keep running and not break. Migration compatibility is the
most complex part of it. I hope we will be able to automate some
of the non-regression tests RedHat/IBM have. Not an easy part
I admit.


There are plenty of contributors who help on very large parts
of QEMU-PPC.

Richard and the Eldorado team are watching closely instruction
implementation,
Mark is doing the same for MAC machines,
Balaton for 44x and 46x and associated machines.
Thomas showed he could bring back from the dead any forgotten board,
Alex Graf still admins the qemu-ppc mailin list.
It was nicely hooked to patchwork by the OzLabs recently :

     https://patchwork.ozlabs.org/project/qemu-ppc/list/

we might add some simple automation on the received patches,
"does the patch apply ?" for instance. Anyhow, it's an easy way
to share the review between people.

Daniel, Bharata, Fabiano, Nick, You and Greg for pseries, and
Alexey, for SLOF+VOF also. I am still around for PowerNV, XIVE, XICS.

Christophe is doing his best to keep alive Linux ppc405.

Michael does kernel CI testing on all these platforms :

     https://github.com/linuxppc/ci-scripts/tree/master/scripts/boot

Guenter also does :

     https://github.com/groeck/linux-build-test/tree/master/rootfs/ppc

and skiboot :

     https://github.com/open-power/skiboot/tree/master/opal-ci

GitLab does even more.

and we have Philippe, always here to make sure every grain of sand
has been examined.

We don't feel alone :)

> Greg and I do plan to stay around in some capacity for at least the next
> 6 months, providing reviews and advice to assist the new maintainers into
> the role.

Thanks for the time and assistance for all these years. Pseries
and PowerNV would not be in such a good shape without all the
efforts you have put into them.

I suppose emulation will take a larger part of our time now since
it is largely used for pseries/powernv development in IBM. We will
see how that goes.

> 
> Signed-off-by: David Gibson <[e-mail]>

Acked-by: Cédric Le Goater <[e-mail]>

C.

> ---
>   MAINTAINERS | 20 ++++++++++++++------
>   1 file changed, 14 insertions(+), 6 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 797be5b366..066c4fb2b0 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -262,8 +262,10 @@ F: hw/openrisc/
>   F: tests/tcg/openrisc/
>   
>   PowerPC TCG CPUs
> -M: David Gibson <[e-mail]>
> -M: Greg Kurz <[e-mail]>
> +M: Cédric Le Goater <[e-mail]>
> +M: Daniel Henrique Barboza <[e-mail]>
> +R: David Gibson <[e-mail]>
> +R: Greg Kurz <[e-mail]>
>   L: [e-mail]
>   S: Maintained
>   F: target/ppc/
> @@ -382,8 +384,10 @@ F: target/mips/kvm*
>   F: target/mips/sysemu/
>   
>   PPC KVM CPUs
> -M: David Gibson <[e-mail]>
> -M: Greg Kurz <[e-mail]>
> +M: Cédric Le Goater <[e-mail]>
> +M: Daniel Henrique Barboza <[e-mail]>
> +R: David Gibson <[e-mail]>
> +R: Greg Kurz <[e-mail]>
>   S: Maintained
>   F: target/ppc/kvm.c
>   
> @@ -1321,8 +1325,10 @@ F: include/hw/rtc/m48t59.h
>   F: tests/acceptance/ppc_prep_40p.py
>   
>   sPAPR
> -M: David Gibson <[e-mail]>
> -M: Greg Kurz <[e-mail]>
> +M: Cédric Le Goater <[e-mail]>
> +M: Daniel Henrique Barboza <[e-mail]>
> +R: David Gibson <[e-mail]>
> +R: Greg Kurz <[e-mail]>
>   L: [e-mail]
>   S: Maintained
>   F: hw/*/spapr*
> @@ -1382,6 +1388,8 @@ F: include/hw/pci-host/mv64361.h
>   
>   Virtual Open Firmware (VOF)
>   M: Alexey Kardashevskiy <[e-mail]>
> +R: Cédric Le Goater <[e-mail]>
> +R: Daniel Henrique Barboza <[e-mail]>
>   R: David Gibson <[e-mail]>
>   R: Greg Kurz <[e-mail]>
>   L: [e-mail]
>

Philippe Mathieu-Daudé Nov. 5, 2021, 7:16 p.m. UTC | #3

Hi Daniel,

On 11/5/21 10:48, Daniel Henrique Barboza wrote:
> On 11/5/21 00:46, David Gibson wrote:
>> As our day jobs and interests have moved onto other things, Greg and I
>> have
>> been struggling to keep on top of maintainership of target/ppc and
>> associated pieces like the pseries and powernv machine types, with their
>> platform specific devices.
>>
>> We've therefore discussed and plan to transfer maintainership to
>> Cédric Le
>> Goater (primary) and Daniel Henrique Barboza (backup).  Cédric and Daniel
>> have been actively contributing to the area for some time, and they're
>> supported in this by their current employer, IBM, who has an obvious
>> interest in the platform.
> 
> Thank you and Greg and Red Hat for all the years of service supporting
> qemu-ppc in the community. IBM will shoulder this responsibility now.

In term of the MAINTAINERS file:

        S: Status, one of the following:
           Supported:   Someone is actually paid to look after this.
           Maintained:  Someone actually looks after it.

The PPC entries have a 'Maintained' status. You say "IBM will shoulder
this responsibility", does that mean the entries will be 'Supported'
as in "someone paid to look after them"?
I wonder because both Cédric and you have some commits with an IBM
email, but both are registering a non-IBM email as contact. I don't
mind the email technical detail, but I am curious about the status
and expectations.

Thanks,

Phil.

>> Greg and I do plan to stay around in some capacity for at least the next
>> 6 months, providing reviews and advice to assist the new maintainers into
>> the role.
> 
> I hope both of you stay around way longer than that :)
> 
> 
> 
> Reviewed-by: Daniel Henrique Barboza <[e-mail]>
> 
>>
>> Signed-off-by: David Gibson <[e-mail]>
>> ---
>>   MAINTAINERS | 20 ++++++++++++++------
>>   1 file changed, 14 insertions(+), 6 deletions(-)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 797be5b366..066c4fb2b0 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -262,8 +262,10 @@ F: hw/openrisc/
>>   F: tests/tcg/openrisc/
>>     PowerPC TCG CPUs
>> -M: David Gibson <[e-mail]>
>> -M: Greg Kurz <[e-mail]>
>> +M: Cédric Le Goater <[e-mail]>
>> +M: Daniel Henrique Barboza <[e-mail]>
>> +R: David Gibson <[e-mail]>
>> +R: Greg Kurz <[e-mail]>
>>   L: [e-mail]
>>   S: Maintained
>>   F: target/ppc/
>> @@ -382,8 +384,10 @@ F: target/mips/kvm*
>>   F: target/mips/sysemu/
>>     PPC KVM CPUs
>> -M: David Gibson <[e-mail]>
>> -M: Greg Kurz <[e-mail]>
>> +M: Cédric Le Goater <[e-mail]>
>> +M: Daniel Henrique Barboza <[e-mail]>
>> +R: David Gibson <[e-mail]>
>> +R: Greg Kurz <[e-mail]>
>>   S: Maintained
>>   F: target/ppc/kvm.c
>>   @@ -1321,8 +1325,10 @@ F: include/hw/rtc/m48t59.h
>>   F: tests/acceptance/ppc_prep_40p.py
>>     sPAPR
>> -M: David Gibson <[e-mail]>
>> -M: Greg Kurz <[e-mail]>
>> +M: Cédric Le Goater <[e-mail]>
>> +M: Daniel Henrique Barboza <[e-mail]>
>> +R: David Gibson <[e-mail]>
>> +R: Greg Kurz <[e-mail]>
>>   L: [e-mail]
>>   S: Maintained
>>   F: hw/*/spapr*
>> @@ -1382,6 +1388,8 @@ F: include/hw/pci-host/mv64361.h
>>     Virtual Open Firmware (VOF)
>>   M: Alexey Kardashevskiy <[e-mail]>
>> +R: Cédric Le Goater <[e-mail]>
>> +R: Daniel Henrique Barboza <[e-mail]>
>>   R: David Gibson <[e-mail]>
>>   R: Greg Kurz <[e-mail]>
>>   L: [e-mail]
>>
>

Daniel Henrique Barboza Nov. 5, 2021, 8:05 p.m. UTC | #4

On 11/5/21 16:16, Philippe Mathieu-Daudé wrote:
> Hi Daniel,
> 
> On 11/5/21 10:48, Daniel Henrique Barboza wrote:
>> On 11/5/21 00:46, David Gibson wrote:
>>> As our day jobs and interests have moved onto other things, Greg and I
>>> have
>>> been struggling to keep on top of maintainership of target/ppc and
>>> associated pieces like the pseries and powernv machine types, with their
>>> platform specific devices.
>>>
>>> We've therefore discussed and plan to transfer maintainership to
>>> Cédric Le
>>> Goater (primary) and Daniel Henrique Barboza (backup).  Cédric and Daniel
>>> have been actively contributing to the area for some time, and they're
>>> supported in this by their current employer, IBM, who has an obvious
>>> interest in the platform.
>>
>> Thank you and Greg and Red Hat for all the years of service supporting
>> qemu-ppc in the community. IBM will shoulder this responsibility now.
> 
> In term of the MAINTAINERS file:
> 
>          S: Status, one of the following:
>             Supported:   Someone is actually paid to look after this.
>             Maintained:  Someone actually looks after it.
> 
> The PPC entries have a 'Maintained' status. You say "IBM will shoulder
> this responsibility", does that mean the entries will be 'Supported'
> as in "someone paid to look after them"?

Yes. It's appropriate to change the PPC entries of this patch to "Supported"
now.


> I wonder because both Cédric and you have some commits with an IBM
> email, but both are registering a non-IBM email as contact. I don't
> mind the email technical detail, but I am curious about the status
> and expectations.

I had problems using IBM corporate email with mailing lists in the past,
and started using this gmail account instead. I believe Cedric has a
similar sob story.

FWIW the contrib/gitdm/group-map-ibm file has both our emails there to
indicate that we're IBM contributors.


Thanks,


Daniel

> 
> Thanks,
> 
> Phil.
> 
>>> Greg and I do plan to stay around in some capacity for at least the next
>>> 6 months, providing reviews and advice to assist the new maintainers into
>>> the role.
>>
>> I hope both of you stay around way longer than that :)
>>
>>
>>
>> Reviewed-by: Daniel Henrique Barboza <[e-mail]>
>>
>>>
>>> Signed-off-by: David Gibson <[e-mail]>
>>> ---
>>>    MAINTAINERS | 20 ++++++++++++++------
>>>    1 file changed, 14 insertions(+), 6 deletions(-)
>>>
>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>> index 797be5b366..066c4fb2b0 100644
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -262,8 +262,10 @@ F: hw/openrisc/
>>>    F: tests/tcg/openrisc/
>>>      PowerPC TCG CPUs
>>> -M: David Gibson <[e-mail]>
>>> -M: Greg Kurz <[e-mail]>
>>> +M: Cédric Le Goater <[e-mail]>
>>> +M: Daniel Henrique Barboza <[e-mail]>
>>> +R: David Gibson <[e-mail]>
>>> +R: Greg Kurz <[e-mail]>
>>>    L: [e-mail]
>>>    S: Maintained
>>>    F: target/ppc/
>>> @@ -382,8 +384,10 @@ F: target/mips/kvm*
>>>    F: target/mips/sysemu/
>>>      PPC KVM CPUs
>>> -M: David Gibson <[e-mail]>
>>> -M: Greg Kurz <[e-mail]>
>>> +M: Cédric Le Goater <[e-mail]>
>>> +M: Daniel Henrique Barboza <[e-mail]>
>>> +R: David Gibson <[e-mail]>
>>> +R: Greg Kurz <[e-mail]>
>>>    S: Maintained
>>>    F: target/ppc/kvm.c
>>>    @@ -1321,8 +1325,10 @@ F: include/hw/rtc/m48t59.h
>>>    F: tests/acceptance/ppc_prep_40p.py
>>>      sPAPR
>>> -M: David Gibson <[e-mail]>
>>> -M: Greg Kurz <[e-mail]>
>>> +M: Cédric Le Goater <[e-mail]>
>>> +M: Daniel Henrique Barboza <[e-mail]>
>>> +R: David Gibson <[e-mail]>
>>> +R: Greg Kurz <[e-mail]>
>>>    L: [e-mail]
>>>    S: Maintained
>>>    F: hw/*/spapr*
>>> @@ -1382,6 +1388,8 @@ F: include/hw/pci-host/mv64361.h
>>>      Virtual Open Firmware (VOF)
>>>    M: Alexey Kardashevskiy <[e-mail]>
>>> +R: Cédric Le Goater <[e-mail]>
>>> +R: Daniel Henrique Barboza <[e-mail]>
>>>    R: David Gibson <[e-mail]>
>>>    R: Greg Kurz <[e-mail]>
>>>    L: [e-mail]
>>>
>>
>

Cédric Le Goater Nov. 5, 2021, 11 p.m. UTC | #5

> In term of the MAINTAINERS file:
> 
>          S: Status, one of the following:
>             Supported:   Someone is actually paid to look after this.
>             Maintained:  Someone actually looks after it.
> 
> The PPC entries have a 'Maintained' status. You say "IBM will shoulder
> this responsibility", does that mean the entries will be 'Supported'
> as in "someone paid to look after them"?
> I wonder because both Cédric and you have some commits with an IBM
> email, but both are registering a non-IBM email as contact. 

Lotus Notes was not designed for patch communication. You don't want
me to send patches with it I assure you :)

> I don't
> mind the email technical detail, but I am curious about the status
> and expectations.

We have other IBM commitments. IBM is willing to share some/most of
our time for QEMU-PPC maintenance.

What we are going do will depend on inputs really. We have pseries
and KVM in focus because there is still business using the software
stack. TCG is extremely useful for pseries and powernv. We clearly
want to keep that running and improve it. Some parts have been barely
touched (and probably used) in the last 15 years. I think we should
drop some support to modernize the useful parts and ease maintenance.

Thanks,

C.

David Gibson Nov. 6, 2021, 4:20 a.m. UTC | #6

On Fri, Nov 05, 2021 at 05:05:25PM -0300, Daniel Henrique Barboza wrote:
> 
> 
> On 11/5/21 16:16, Philippe Mathieu-Daudé wrote:
> > Hi Daniel,
> > 
> > On 11/5/21 10:48, Daniel Henrique Barboza wrote:
> > > On 11/5/21 00:46, David Gibson wrote:
> > > > As our day jobs and interests have moved onto other things, Greg and I
> > > > have
> > > > been struggling to keep on top of maintainership of target/ppc and
> > > > associated pieces like the pseries and powernv machine types, with their
> > > > platform specific devices.
> > > > 
> > > > We've therefore discussed and plan to transfer maintainership to
> > > > Cédric Le
> > > > Goater (primary) and Daniel Henrique Barboza (backup).  Cédric and Daniel
> > > > have been actively contributing to the area for some time, and they're
> > > > supported in this by their current employer, IBM, who has an obvious
> > > > interest in the platform.
> > > 
> > > Thank you and Greg and Red Hat for all the years of service supporting
> > > qemu-ppc in the community. IBM will shoulder this responsibility now.
> > 
> > In term of the MAINTAINERS file:
> > 
> >          S: Status, one of the following:
> >             Supported:   Someone is actually paid to look after this.
> >             Maintained:  Someone actually looks after it.
> > 
> > The PPC entries have a 'Maintained' status. You say "IBM will shoulder
> > this responsibility", does that mean the entries will be 'Supported'
> > as in "someone paid to look after them"?
> 
> Yes. It's appropriate to change the PPC entries of this patch to "Supported"
> now.

Good point, I've adjusted that.

> > I wonder because both Cédric and you have some commits with an IBM
> > email, but both are registering a non-IBM email as contact. I don't
> > mind the email technical detail, but I am curious about the status
> > and expectations.
> 
> I had problems using IBM corporate email with mailing lists in the past,
> and started using this gmail account instead. I believe Cedric has a
> similar sob story.
> 
> FWIW the contrib/gitdm/group-map-ibm file has both our emails there to
> indicate that we're IBM contributors.
> 
> 
> Thanks,
> 
> 
> Daniel
> 
> > 
> > Thanks,
> > 
> > Phil.
> > 
> > > > Greg and I do plan to stay around in some capacity for at least the next
> > > > 6 months, providing reviews and advice to assist the new maintainers into
> > > > the role.
> > > 
> > > I hope both of you stay around way longer than that :)
> > > 
> > > 
> > > 
> > > Reviewed-by: Daniel Henrique Barboza <[e-mail]>
> > > 
> > > > 
> > > > Signed-off-by: David Gibson <[e-mail]>
> > > > ---
> > > >    MAINTAINERS | 20 ++++++++++++++------
> > > >    1 file changed, 14 insertions(+), 6 deletions(-)
> > > > 
> > > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > > index 797be5b366..066c4fb2b0 100644
> > > > --- a/MAINTAINERS
> > > > +++ b/MAINTAINERS
> > > > @@ -262,8 +262,10 @@ F: hw/openrisc/
> > > >    F: tests/tcg/openrisc/
> > > >      PowerPC TCG CPUs
> > > > -M: David Gibson <[e-mail]>
> > > > -M: Greg Kurz <[e-mail]>
> > > > +M: Cédric Le Goater <[e-mail]>
> > > > +M: Daniel Henrique Barboza <[e-mail]>
> > > > +R: David Gibson <[e-mail]>
> > > > +R: Greg Kurz <[e-mail]>
> > > >    L: [e-mail]
> > > >    S: Maintained
> > > >    F: target/ppc/
> > > > @@ -382,8 +384,10 @@ F: target/mips/kvm*
> > > >    F: target/mips/sysemu/
> > > >      PPC KVM CPUs
> > > > -M: David Gibson <[e-mail]>
> > > > -M: Greg Kurz <[e-mail]>
> > > > +M: Cédric Le Goater <[e-mail]>
> > > > +M: Daniel Henrique Barboza <[e-mail]>
> > > > +R: David Gibson <[e-mail]>
> > > > +R: Greg Kurz <[e-mail]>
> > > >    S: Maintained
> > > >    F: target/ppc/kvm.c
> > > >    @@ -1321,8 +1325,10 @@ F: include/hw/rtc/m48t59.h
> > > >    F: tests/acceptance/ppc_prep_40p.py
> > > >      sPAPR
> > > > -M: David Gibson <[e-mail]>
> > > > -M: Greg Kurz <[e-mail]>
> > > > +M: Cédric Le Goater <[e-mail]>
> > > > +M: Daniel Henrique Barboza <[e-mail]>
> > > > +R: David Gibson <[e-mail]>
> > > > +R: Greg Kurz <[e-mail]>
> > > >    L: [e-mail]
> > > >    S: Maintained
> > > >    F: hw/*/spapr*
> > > > @@ -1382,6 +1388,8 @@ F: include/hw/pci-host/mv64361.h
> > > >      Virtual Open Firmware (VOF)
> > > >    M: Alexey Kardashevskiy <[e-mail]>
> > > > +R: Cédric Le Goater <[e-mail]>
> > > > +R: Daniel Henrique Barboza <[e-mail]>
> > > >    R: David Gibson <[e-mail]>
> > > >    R: Greg Kurz <[e-mail]>
> > > >    L: [e-mail]
> > > > 
> > > 
> > 
>

Cédric Le Goater Nov. 6, 2021, 8:28 a.m. UTC | #7

>>>> Thank you and Greg and Red Hat for all the years of service supporting
>>>> qemu-ppc in the community. IBM will shoulder this responsibility now.
>>>
>>> In term of the MAINTAINERS file:
>>>
>>>           S: Status, one of the following:
>>>              Supported:   Someone is actually paid to look after this.
>>>              Maintained:  Someone actually looks after it.
>>>
>>> The PPC entries have a 'Maintained' status. You say "IBM will shoulder
>>> this responsibility", does that mean the entries will be 'Supported'
>>> as in "someone paid to look after them"?
>>
>> Yes. It's appropriate to change the PPC entries of this patch to "Supported"
>> now.
> 
> Good point, I've adjusted that.

"Supported" would be setting the expectations too high. It is an extra
activity among what we are already dealing with. Please leave it to
"Maintained".

Thanks,

C.

David Gibson Nov. 6, 2021, 8:53 a.m. UTC | #8

On Sat, Nov 06, 2021 at 09:28:54AM +0100, Cédric Le Goater wrote:
> > > > > Thank you and Greg and Red Hat for all the years of service supporting
> > > > > qemu-ppc in the community. IBM will shoulder this responsibility now.
> > > > 
> > > > In term of the MAINTAINERS file:
> > > > 
> > > >           S: Status, one of the following:
> > > >              Supported:   Someone is actually paid to look after this.
> > > >              Maintained:  Someone actually looks after it.
> > > > 
> > > > The PPC entries have a 'Maintained' status. You say "IBM will shoulder
> > > > this responsibility", does that mean the entries will be 'Supported'
> > > > as in "someone paid to look after them"?
> > > 
> > > Yes. It's appropriate to change the PPC entries of this patch to "Supported"
> > > now.
> > 
> > Good point, I've adjusted that.
> 
> "Supported" would be setting the expectations too high. It is an extra
> activity among what we are already dealing with. Please leave it to
> "Maintained".

Fair enough, reverted.

Philippe Mathieu-Daudé Nov. 6, 2021, 9:18 a.m. UTC | #9

On 11/5/21 21:05, Daniel Henrique Barboza wrote:
> On 11/5/21 16:16, Philippe Mathieu-Daudé wrote:
>> Hi Daniel,
>>
>> On 11/5/21 10:48, Daniel Henrique Barboza wrote:
>>> On 11/5/21 00:46, David Gibson wrote:
>>>> As our day jobs and interests have moved onto other things, Greg and I
>>>> have
>>>> been struggling to keep on top of maintainership of target/ppc and
>>>> associated pieces like the pseries and powernv machine types, with
>>>> their
>>>> platform specific devices.
>>>>
>>>> We've therefore discussed and plan to transfer maintainership to
>>>> Cédric Le
>>>> Goater (primary) and Daniel Henrique Barboza (backup).  Cédric and
>>>> Daniel
>>>> have been actively contributing to the area for some time, and they're
>>>> supported in this by their current employer, IBM, who has an obvious
>>>> interest in the platform.
>>>
>>> Thank you and Greg and Red Hat for all the years of service supporting
>>> qemu-ppc in the community. IBM will shoulder this responsibility now.
>>
>> In term of the MAINTAINERS file:
>>
>>          S: Status, one of the following:
>>             Supported:   Someone is actually paid to look after this.
>>             Maintained:  Someone actually looks after it.
>>
>> The PPC entries have a 'Maintained' status. You say "IBM will shoulder
>> this responsibility", does that mean the entries will be 'Supported'
>> as in "someone paid to look after them"?
> 
> Yes. It's appropriate to change the PPC entries of this patch to
> "Supported"
> now.

This is a great news :)

>> I wonder because both Cédric and you have some commits with an IBM
>> email, but both are registering a non-IBM email as contact. I don't
>> mind the email technical detail, but I am curious about the status
>> and expectations.
> 
> I had problems using IBM corporate email with mailing lists in the past,
> and started using this gmail account instead. I believe Cedric has a
> similar sob story.
> 
> FWIW the contrib/gitdm/group-map-ibm file has both our emails there to
> indicate that we're IBM contributors.

OK this is how I understood it first then. Thanks for the clarification.

Regards,

Phil.

Philippe Mathieu-Daudé Nov. 6, 2021, 9:22 a.m. UTC | #10

On 11/6/21 00:00, Cédric Le Goater wrote:
>> In term of the MAINTAINERS file:
>>
>>          S: Status, one of the following:
>>             Supported:   Someone is actually paid to look after this.
>>             Maintained:  Someone actually looks after it.
>>
>> The PPC entries have a 'Maintained' status. You say "IBM will shoulder
>> this responsibility", does that mean the entries will be 'Supported'
>> as in "someone paid to look after them"?
>> I wonder because both Cédric and you have some commits with an IBM
>> email, but both are registering a non-IBM email as contact. 
> 
> Lotus Notes was not designed for patch communication. You don't want
> me to send patches with it I assure you :)
> 
>> I don't
>> mind the email technical detail, but I am curious about the status
>> and expectations.
> 
> We have other IBM commitments. IBM is willing to share some/most of
> our time for QEMU-PPC maintenance.
> 
> What we are going do will depend on inputs really. We have pseries
> and KVM in focus because there is still business using the software
> stack. TCG is extremely useful for pseries and powernv. We clearly
> want to keep that running and improve it. Some parts have been barely
> touched (and probably used) in the last 15 years. I think we should
> drop some support to modernize the useful parts and ease maintenance.

Here let me recommend the ant work approach I'm doing for MIPS. Instead
of dropping ISA extensions, I'm splitting them in various compile units,
that way 1/ we can chose to build without them and 2/ sub-maintainers
can maintain them separately. Having a finer grained MAINTAINERS
entries allow to filter-out/in and reduce reviewers pressure.

Cédric Le Goater Nov. 6, 2021, 4:55 p.m. UTC | #11

>> What we are going do will depend on inputs really. We have pseries
>> and KVM in focus because there is still business using the software
>> stack. TCG is extremely useful for pseries and powernv. We clearly
>> want to keep that running and improve it. Some parts have been barely
>> touched (and probably used) in the last 15 years. I think we should
>> drop some support to modernize the useful parts and ease maintenance.
> 
> Here let me recommend the ant work approach I'm doing for MIPS. Instead
> of dropping ISA extensions, I'm splitting them in various compile units,
> that way 1/ we can chose to build without them and 2/ sub-maintainers
> can maintain them separately. Having a finer grained MAINTAINERS
> entries allow to filter-out/in and reduce reviewers pressure.

OK. Yes, the goal is to ease maintenance, not to remove platforms or
CPUs. QEMU is the perfect project for legacy systems.

I am very willing to go in that direction and take the risk to break
a few things. We have been through such an episode when HV mode was
added for the PowerNV machine and we managed to fix all regressions,
down to OpenBIOS. Ben and his ppc32 knowledge helped a lot of course.

Untangling some parts won't be easy. Exception modeling for instance.
The instruction implementation shouldn't be too hard and it's being
modernized by Luis and Matheus. I guess we should improve our
testsuite to catch early any issues. An acceptance test for each
machine is a minimum.

Thanks,

C.

Greg Kurz Nov. 7, 2021, 8:15 p.m. UTC | #12

On Sat, 6 Nov 2021 19:53:04 +1100
David Gibson <[e-mail]> wrote:

> On Sat, Nov 06, 2021 at 09:28:54AM +0100, Cédric Le Goater wrote:
> > > > > > Thank you and Greg and Red Hat for all the years of service supporting
> > > > > > qemu-ppc in the community. IBM will shoulder this responsibility now.
> > > > > 
> > > > > In term of the MAINTAINERS file:
> > > > > 
> > > > >           S: Status, one of the following:
> > > > >              Supported:   Someone is actually paid to look after this.
> > > > >              Maintained:  Someone actually looks after it.
> > > > > 
> > > > > The PPC entries have a 'Maintained' status. You say "IBM will shoulder
> > > > > this responsibility", does that mean the entries will be 'Supported'
> > > > > as in "someone paid to look after them"?
> > > > 
> > > > Yes. It's appropriate to change the PPC entries of this patch to "Supported"
> > > > now.
> > > 
> > > Good point, I've adjusted that.
> > 
> > "Supported" would be setting the expectations too high. It is an extra
> > activity among what we are already dealing with. Please leave it to
> > "Maintained".
> 
> Fair enough, reverted.
> 

For the "Maintained" version,

Reviewed-by: Greg Kurz <[e-mail]>

Good luck Cédric and Daniel !

Cheers,

--
Greg

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 797be5b366..066c4fb2b0 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -262,8 +262,10 @@  F: hw/openrisc/
 F: tests/tcg/openrisc/
 
 PowerPC TCG CPUs
-M: David Gibson <[e-mail]>
-M: Greg Kurz <[e-mail]>
+M: Cédric Le Goater <[e-mail]>
+M: Daniel Henrique Barboza <[e-mail]>
+R: David Gibson <[e-mail]>
+R: Greg Kurz <[e-mail]>
 L: [e-mail]
 S: Maintained
 F: target/ppc/
@@ -382,8 +384,10 @@  F: target/mips/kvm*
 F: target/mips/sysemu/
 
 PPC KVM CPUs
-M: David Gibson <[e-mail]>
-M: Greg Kurz <[e-mail]>
+M: Cédric Le Goater <[e-mail]>
+M: Daniel Henrique Barboza <[e-mail]>
+R: David Gibson <[e-mail]>
+R: Greg Kurz <[e-mail]>
 S: Maintained
 F: target/ppc/kvm.c
 
@@ -1321,8 +1325,10 @@  F: include/hw/rtc/m48t59.h
 F: tests/acceptance/ppc_prep_40p.py
 
 sPAPR
-M: David Gibson <[e-mail]>
-M: Greg Kurz <[e-mail]>
+M: Cédric Le Goater <[e-mail]>
+M: Daniel Henrique Barboza <[e-mail]>
+R: David Gibson <[e-mail]>
+R: Greg Kurz <[e-mail]>
 L: [e-mail]
 S: Maintained
 F: hw/*/spapr*
@@ -1382,6 +1388,8 @@  F: include/hw/pci-host/mv64361.h
 
 Virtual Open Firmware (VOF)
 M: Alexey Kardashevskiy <[e-mail]>
+R: Cédric Le Goater <[e-mail]>
+R: Daniel Henrique Barboza <[e-mail]>
 R: David Gibson <[e-mail]>
 R: Greg Kurz <[e-mail]>
 L: [e-mail]