| Message ID | 20211107124845.1174791-4-richard.henderson@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | linux-user: Fix getdents alignment issues (#704) | expand |
On 11/7/21 13:48, Richard Henderson wrote: > The host uint64_t (etc) does not have the correct > alignment constraint as the guest: use abi_* types. > > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> > --- > linux-user/syscall_defs.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> On Nov 7, 2021, at 5:48 AM, Richard Henderson <richard.henderson@linaro.org> wrote: > > The host uint64_t (etc) does not have the correct > alignment constraint as the guest: use abi_* types. > > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> > --- > linux-user/syscall_defs.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed by: Warner Losh <imp@bsdimp.com> > diff --git a/linux-user/syscall_defs.h b/linux-user/syscall_defs.h > index 98b09ee6d6..41aaafbac1 100644 > --- a/linux-user/syscall_defs.h > +++ b/linux-user/syscall_defs.h > @@ -437,9 +437,9 @@ struct target_dirent { > }; > > struct target_dirent64 { > - uint64_t d_ino; > - int64_t d_off; > - unsigned short d_reclen; > + abi_ullong d_ino; > + abi_llong d_off; > + abi_ushort d_reclen; > unsigned char d_type; > char d_name[]; > }; > -- > 2.25.1 > >
diff --git a/linux-user/syscall_defs.h b/linux-user/syscall_defs.h index 98b09ee6d6..41aaafbac1 100644 --- a/linux-user/syscall_defs.h +++ b/linux-user/syscall_defs.h @@ -437,9 +437,9 @@ struct target_dirent { }; struct target_dirent64 { - uint64_t d_ino; - int64_t d_off; - unsigned short d_reclen; + abi_ullong d_ino; + abi_llong d_off; + abi_ushort d_reclen; unsigned char d_type; char d_name[]; };
The host uint64_t (etc) does not have the correct alignment constraint as the guest: use abi_* types. Signed-off-by: Richard Henderson <richard.henderson@linaro.org> --- linux-user/syscall_defs.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)