linux-user: Add license in files generated by scripts/gensyscalls.sh

Commit Message

Philippe Mathieu-Daudé Nov. 17, 2021, 5:48 p.m. UTC

Signed-off-by: Philippe Mathieu-Daudé <[e-mail]>
---
 scripts/gensyscalls.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Philippe Mathieu-Daudé Dec. 15, 2021, 10:35 a.m. UTC | #1

ping?

On 11/17/21 18:48, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <[e-mail]>
> ---
>  scripts/gensyscalls.sh | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/scripts/gensyscalls.sh b/scripts/gensyscalls.sh
> index 8fb450e3c96..aee5cc64a15 100755
> --- a/scripts/gensyscalls.sh
> +++ b/scripts/gensyscalls.sh
> @@ -75,7 +75,8 @@ generate_syscall_nr()
>      file="$3"
>      guard="$(upper LINUX_USER_$(qemu_arch $arch)_$(basename "$file"))"
>  
> -    (echo "/*"
> +    (echo "/* SPDX-License-Identifier: GPL-2.0-or-later */"
> +    echo "/*"
>      echo " * This file contains the system call numbers."
>      echo " * Do not modify."
>      echo " * This file is generated by scripts/gensyscalls.sh"
>

Peter Maydell Dec. 15, 2021, 12:05 p.m. UTC | #2

On Wed, 17 Nov 2021 at 17:52, Philippe Mathieu-Daudé <[e-mail]> wrote:
>
> Signed-off-by: Philippe Mathieu-Daudé <[e-mail]>
> ---
>  scripts/gensyscalls.sh | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/gensyscalls.sh b/scripts/gensyscalls.sh
> index 8fb450e3c96..aee5cc64a15 100755
> --- a/scripts/gensyscalls.sh
> +++ b/scripts/gensyscalls.sh
> @@ -75,7 +75,8 @@ generate_syscall_nr()
>      file="$3"
>      guard="$(upper LINUX_USER_$(qemu_arch $arch)_$(basename "$file"))"
>
> -    (echo "/*"
> +    (echo "/* SPDX-License-Identifier: GPL-2.0-or-later */"

The gensyscalls.sh script itself is GPL-2-or-later, but
the output files are generated from the Linux kernel's
headers, which are generally GPL-2-only. As a non-lawyer,
I'm not sure to what extent copyright adheres in a list
of names-and-numbers, but marking the generated headers
as GPL-2.0-only rather than -or-later seems to me like it
better reflects the intention of the header file authors.
It makes no difference to QEMU in practice because we are
overall GPL-2.0-only anyway.

thanks
-- PMM

Patch

diff --git a/scripts/gensyscalls.sh b/scripts/gensyscalls.sh
index 8fb450e3c96..aee5cc64a15 100755
--- a/scripts/gensyscalls.sh
+++ b/scripts/gensyscalls.sh
@@ -75,7 +75,8 @@  generate_syscall_nr()
     file="$3"
     guard="$(upper LINUX_USER_$(qemu_arch $arch)_$(basename "$file"))"
 
-    (echo "/*"
+    (echo "/* SPDX-License-Identifier: GPL-2.0-or-later */"
+    echo "/*"
     echo " * This file contains the system call numbers."
     echo " * Do not modify."
     echo " * This file is generated by scripts/gensyscalls.sh"