| Message ID | 20220104085431.2122999-4-f4bug@amsat.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | hw/dma: Use dma_addr_t type definition when relevant | expand |
On 1/4/22 12:54 AM, Philippe Mathieu-Daudé wrote: > From: Philippe Mathieu-Daudé <philmd@redhat.com> > > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > include/hw/pci/pci.h | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h > index 5b36334a28a..07f08aa0626 100644 > --- a/include/hw/pci/pci.h > +++ b/include/hw/pci/pci.h > @@ -876,6 +876,18 @@ PCI_DMA_DEFINE_LDST(q_be, q_be, 64); > > #undef PCI_DMA_DEFINE_LDST > > +/** > + * pci_dma_map: Map device PCI address space range into host virtual address > + * > + * May map a subset of the requested range, given by and returned in @plen. > + * May return %NULL and set *@plen to zero(0), if resources needed to perform > + * the mapping are exhausted. > + * > + * @dev: #PCIDevice to be accessed > + * @addr: address within that device's address space > + * @plen: pointer to length of buffer; updated on return > + * @dir: indicates the transfer direction > + */ As Peter recently mentioned, the ** format is off. The description goes below the arguments. Otherwise, Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h index 5b36334a28a..07f08aa0626 100644 --- a/include/hw/pci/pci.h +++ b/include/hw/pci/pci.h @@ -876,6 +876,18 @@ PCI_DMA_DEFINE_LDST(q_be, q_be, 64); #undef PCI_DMA_DEFINE_LDST +/** + * pci_dma_map: Map device PCI address space range into host virtual address + * + * May map a subset of the requested range, given by and returned in @plen. + * May return %NULL and set *@plen to zero(0), if resources needed to perform + * the mapping are exhausted. + * + * @dev: #PCIDevice to be accessed + * @addr: address within that device's address space + * @plen: pointer to length of buffer; updated on return + * @dir: indicates the transfer direction + */ static inline void *pci_dma_map(PCIDevice *dev, dma_addr_t addr, dma_addr_t *plen, DMADirection dir) {