| Message ID | 20220110131001.614319-4-f4bug@amsat.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | host: Support macOS 12 | expand |
On Mon, Jan 10, 2022 at 02:09:57PM +0100, Philippe Mathieu-Daudé wrote: > Both hvf_get_segments/hvf_put_segments() functions are only > used within x86hvf.c: do not declare them as public API. > Reviewed-by: Roman Bolshakov <roman@roolebo.dev> Tested-by: Roman Bolshakov <roman@roolebo.dev> Thanks, Roman > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > target/i386/hvf/x86hvf.h | 2 -- > target/i386/hvf/x86hvf.c | 4 ++-- > 2 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/target/i386/hvf/x86hvf.h b/target/i386/hvf/x86hvf.h > index 99ed8d608dd..db6003d6bda 100644 > --- a/target/i386/hvf/x86hvf.h > +++ b/target/i386/hvf/x86hvf.h > @@ -26,11 +26,9 @@ void hvf_set_segment(struct CPUState *cpu, struct vmx_segment *vmx_seg, > SegmentCache *qseg, bool is_tr); > void hvf_get_segment(SegmentCache *qseg, struct vmx_segment *vmx_seg); > void hvf_put_xsave(CPUState *cpu_state); > -void hvf_put_segments(CPUState *cpu_state); > void hvf_put_msrs(CPUState *cpu_state); > void hvf_get_xsave(CPUState *cpu_state); > void hvf_get_msrs(CPUState *cpu_state); > void vmx_clear_int_window_exiting(CPUState *cpu); > -void hvf_get_segments(CPUState *cpu_state); > void vmx_update_tpr(CPUState *cpu); > #endif > diff --git a/target/i386/hvf/x86hvf.c b/target/i386/hvf/x86hvf.c > index 05ec1bddc4e..907f09f1b43 100644 > --- a/target/i386/hvf/x86hvf.c > +++ b/target/i386/hvf/x86hvf.c > @@ -83,7 +83,7 @@ void hvf_put_xsave(CPUState *cpu_state) > } > } > > -void hvf_put_segments(CPUState *cpu_state) > +static void hvf_put_segments(CPUState *cpu_state) > { > CPUX86State *env = &X86_CPU(cpu_state)->env; > struct vmx_segment seg; > @@ -166,7 +166,7 @@ void hvf_get_xsave(CPUState *cpu_state) > x86_cpu_xrstor_all_areas(X86_CPU(cpu_state), xsave, xsave_len); > } > > -void hvf_get_segments(CPUState *cpu_state) > +static void hvf_get_segments(CPUState *cpu_state) > { > CPUX86State *env = &X86_CPU(cpu_state)->env; > > -- > 2.33.1
diff --git a/target/i386/hvf/x86hvf.h b/target/i386/hvf/x86hvf.h index 99ed8d608dd..db6003d6bda 100644 --- a/target/i386/hvf/x86hvf.h +++ b/target/i386/hvf/x86hvf.h @@ -26,11 +26,9 @@ void hvf_set_segment(struct CPUState *cpu, struct vmx_segment *vmx_seg, SegmentCache *qseg, bool is_tr); void hvf_get_segment(SegmentCache *qseg, struct vmx_segment *vmx_seg); void hvf_put_xsave(CPUState *cpu_state); -void hvf_put_segments(CPUState *cpu_state); void hvf_put_msrs(CPUState *cpu_state); void hvf_get_xsave(CPUState *cpu_state); void hvf_get_msrs(CPUState *cpu_state); void vmx_clear_int_window_exiting(CPUState *cpu); -void hvf_get_segments(CPUState *cpu_state); void vmx_update_tpr(CPUState *cpu); #endif diff --git a/target/i386/hvf/x86hvf.c b/target/i386/hvf/x86hvf.c index 05ec1bddc4e..907f09f1b43 100644 --- a/target/i386/hvf/x86hvf.c +++ b/target/i386/hvf/x86hvf.c @@ -83,7 +83,7 @@ void hvf_put_xsave(CPUState *cpu_state) } } -void hvf_put_segments(CPUState *cpu_state) +static void hvf_put_segments(CPUState *cpu_state) { CPUX86State *env = &X86_CPU(cpu_state)->env; struct vmx_segment seg; @@ -166,7 +166,7 @@ void hvf_get_xsave(CPUState *cpu_state) x86_cpu_xrstor_all_areas(X86_CPU(cpu_state), xsave, xsave_len); } -void hvf_get_segments(CPUState *cpu_state) +static void hvf_get_segments(CPUState *cpu_state) { CPUX86State *env = &X86_CPU(cpu_state)->env;
Both hvf_get_segments/hvf_put_segments() functions are only used within x86hvf.c: do not declare them as public API. Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> --- target/i386/hvf/x86hvf.h | 2 -- target/i386/hvf/x86hvf.c | 4 ++-- 2 files changed, 2 insertions(+), 4 deletions(-)