mbox

[PULL,0/9] qemu-ga-win patches

Message ID 20220110134644.107375-1-kkostiuk@redhat.com (mailing list archive)
State New, archived
Headers show

Pull-request

https://github.com/kostyanf14/qemu.git tags/qga-win32-pull-2022-01-10

Message

Konstantin Kostiuk Jan. 10, 2022, 1:46 p.m. UTC 
The following changes since commit df722e33d5da26ea8604500ca8f509245a0ea524:

  Merge tag 'bsd-user-arm-pull-request' of gitlab.com:bsdimp/qemu into staging (2022-01-08 09:37:59 -0800)

are available in the Git repository at:

  https://github.com/kostyanf14/qemu.git tags/qga-win32-pull-2022-01-10

for you to fetch changes up to 206ce9699fae1f631ac74b7e1115db2affc759fd:

  qga-win: Detect Windows 11 by build number (2022-01-10 13:05:25 +0000)

----------------------------------------------------------------
qemu-ga-win patches

* Fix memory leak in get_pci_info function
* Add support for Windows 11 in guest-get-osinfo command


Signed-off-by: Kostiantyn Kostiuk <kkostiuk@redhat.com>

----------------------------------------------------------------
Kostiantyn Kostiuk (9):
      MAINTAINERS: Add entry for QEMU Guest Agent Windows components
      gqa-win: get_pci_info: Clean dev_info if handle is valid
      gqa-win: get_pci_info: Use common 'end' label
      gqa-win: get_pci_info: Free parent_dev_info properly
      gqa-win: get_pci_info: Split logic to separate functions
      gqa-win: get_pci_info: Add g_autofree for few variables
      gqa-win: get_pci_info: Replace 'while' with 2 calls of the function
      qga-win: Detect OS based on Windows 10 by first build number
      qga-win: Detect Windows 11 by build number

 MAINTAINERS          |   8 ++
 qga/commands-win32.c | 274 +++++++++++++++++++++++++++++----------------------
 2 files changed, 166 insertions(+), 116 deletions(-)

--
2.25.1

Comments

Philippe Mathieu-Daudé Jan. 10, 2022, 2:14 p.m. UTC | #1 
On 1/10/22 14:46, Konstantin Kostiuk wrote:
> The following changes since commit df722e33d5da26ea8604500ca8f509245a0ea524:
> 
>   Merge tag 'bsd-user-arm-pull-request' of gitlab.com:bsdimp/qemu into staging (2022-01-08 09:37:59 -0800)
> 
> are available in the Git repository at:
> 
>   https://github.com/kostyanf14/qemu.git tags/qga-win32-pull-2022-01-10
> 
> for you to fetch changes up to 206ce9699fae1f631ac74b7e1115db2affc759fd:
> 
>   qga-win: Detect Windows 11 by build number (2022-01-10 13:05:25 +0000)
> 
> ----------------------------------------------------------------
> qemu-ga-win patches
> 
> * Fix memory leak in get_pci_info function
> * Add support for Windows 11 in guest-get-osinfo command
> 
> 
> Signed-off-by: Kostiantyn Kostiuk <kkostiuk@redhat.com>
> 
> ----------------------------------------------------------------

I see the patch 'Message-ID' tag is not required on the guide:
https://www.qemu.org/docs/master/devel/submitting-a-pull-request.html
but it is sometime useful.

For your next PR I recommend the 'b4' tool which includes it:
https://people.kernel.org/monsieuricon/introducing-b4-and-patch-attestation
Peter Maydell Jan. 10, 2022, 2:16 p.m. UTC | #2 
On Mon, 10 Jan 2022 at 14:14, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> On 1/10/22 14:46, Konstantin Kostiuk wrote:
> > The following changes since commit df722e33d5da26ea8604500ca8f509245a0ea524:
> >
> >   Merge tag 'bsd-user-arm-pull-request' of gitlab.com:bsdimp/qemu into staging (2022-01-08 09:37:59 -0800)
> >
> > are available in the Git repository at:
> >
> >   https://github.com/kostyanf14/qemu.git tags/qga-win32-pull-2022-01-10
> >
> > for you to fetch changes up to 206ce9699fae1f631ac74b7e1115db2affc759fd:
> >
> >   qga-win: Detect Windows 11 by build number (2022-01-10 13:05:25 +0000)
> >
> > ----------------------------------------------------------------
> > qemu-ga-win patches
> >
> > * Fix memory leak in get_pci_info function
> > * Add support for Windows 11 in guest-get-osinfo command
> >
> >
> > Signed-off-by: Kostiantyn Kostiuk <kkostiuk@redhat.com>
> >
> > ----------------------------------------------------------------
>
> I see the patch 'Message-ID' tag is not required on the guide:
> https://www.qemu.org/docs/master/devel/submitting-a-pull-request.html
> but it is sometime useful.

I don't think we should be adding extra requirements if we don't
need them. The pullrequest handling infrastructure doesn't need
message-id tags.

thanks
-- PMM
Konstantin Kostiuk Jan. 10, 2022, 2:37 p.m. UTC | #3 
Thanks for the information. I will read about the 'b4' tool.

Best Regards,
Konstantin Kostiuk.


On Mon, Jan 10, 2022 at 4:16 PM Peter Maydell <peter.maydell@linaro.org>
wrote:

> On Mon, 10 Jan 2022 at 14:14, Philippe Mathieu-Daudé <f4bug@amsat.org>
> wrote:
> >
> > On 1/10/22 14:46, Konstantin Kostiuk wrote:
> > > The following changes since commit
> df722e33d5da26ea8604500ca8f509245a0ea524:
> > >
> > >   Merge tag 'bsd-user-arm-pull-request' of gitlab.com:bsdimp/qemu
> into staging (2022-01-08 09:37:59 -0800)
> > >
> > > are available in the Git repository at:
> > >
> > >   https://github.com/kostyanf14/qemu.git
> tags/qga-win32-pull-2022-01-10
> > >
> > > for you to fetch changes up to
> 206ce9699fae1f631ac74b7e1115db2affc759fd:
> > >
> > >   qga-win: Detect Windows 11 by build number (2022-01-10 13:05:25
> +0000)
> > >
> > > ----------------------------------------------------------------
> > > qemu-ga-win patches
> > >
> > > * Fix memory leak in get_pci_info function
> > > * Add support for Windows 11 in guest-get-osinfo command
> > >
> > >
> > > Signed-off-by: Kostiantyn Kostiuk <kkostiuk@redhat.com>
> > >
> > > ----------------------------------------------------------------
> >
> > I see the patch 'Message-ID' tag is not required on the guide:
> > https://www.qemu.org/docs/master/devel/submitting-a-pull-request.html
> > but it is sometime useful.
>
> I don't think we should be adding extra requirements if we don't
> need them. The pullrequest handling infrastructure doesn't need
> message-id tags.
>
> thanks
> -- PMM
>
>
Peter Maydell Jan. 15, 2022, 12:40 p.m. UTC | #4 
On Mon, 10 Jan 2022 at 13:46, Konstantin Kostiuk <kkostiuk@redhat.com> wrote:
>
> The following changes since commit df722e33d5da26ea8604500ca8f509245a0ea524:
>
>   Merge tag 'bsd-user-arm-pull-request' of gitlab.com:bsdimp/qemu into staging (2022-01-08 09:37:59 -0800)
>
> are available in the Git repository at:
>
>   https://github.com/kostyanf14/qemu.git tags/qga-win32-pull-2022-01-10
>
> for you to fetch changes up to 206ce9699fae1f631ac74b7e1115db2affc759fd:
>
>   qga-win: Detect Windows 11 by build number (2022-01-10 13:05:25 +0000)

Hi; this tag doesn't seem to be gpg-signed. QEMU only alloows pullreqs
which are for gpg-signed tags, so you'll need to sign it. Please make
sure you've uploaded your gpg key to a suitable keyserver (eg
keyserver.ubuntu.com and/or keys.openpgp.org) and let me know which
one so I can download it. If you can arrange to get your key signed by
some of your RedHat colleagues (and upload the key with those signatures)
that would also be helpful.

thanks
-- PMM
Konstantin Kostiuk Jan. 15, 2022, 10:13 p.m. UTC | #5 
On Sat, Jan 15, 2022 at 2:40 PM Peter Maydell <peter.maydell@linaro.org>
wrote:

> On Mon, 10 Jan 2022 at 13:46, Konstantin Kostiuk <kkostiuk@redhat.com>
> wrote:
> >
> > The following changes since commit
> df722e33d5da26ea8604500ca8f509245a0ea524:
> >
> >   Merge tag 'bsd-user-arm-pull-request' of gitlab.com:bsdimp/qemu into
> staging (2022-01-08 09:37:59 -0800)
> >
> > are available in the Git repository at:
> >
> >   https://github.com/kostyanf14/qemu.git tags/qga-win32-pull-2022-01-10
> >
> > for you to fetch changes up to 206ce9699fae1f631ac74b7e1115db2affc759fd:
> >
> >   qga-win: Detect Windows 11 by build number (2022-01-10 13:05:25 +0000)
>
> Hi; this tag doesn't seem to be gpg-signed. QEMU only alloows pullreqs
> which are for gpg-signed tags, so you'll need to sign it. Please make
> sure you've uploaded your gpg key to a suitable keyserver (eg
> keyserver.ubuntu.com and/or keys.openpgp.org) and let me know which
> one so I can download it. If you can arrange to get your key signed by
> some of your RedHat colleagues (and upload the key with those signatures)
> that would also be helpful.
>
> thanks
> -- PMM
>

Hi. I uploaded my GPG key to keys.openpgp.org. You can find it by my RedHat
email.
Unfortunately, for now, this key can not be signed by other RedHat
developers.
I signed my tag and pushed it to GitHub. Should I resend this set of
patches?

For tag signing, I use the 'git tag -s' command.
I am sorry for the mistakes, this is my first PR.

Best Regards,
Konstantin Kostiuk.
Peter Maydell Jan. 16, 2022, 8:11 p.m. UTC | #6 
On Sat, 15 Jan 2022 at 22:13, Konstantin Kostiuk <kkostiuk@redhat.com> wrote:
> Hi. I uploaded my GPG key to keys.openpgp.org. You can find it by my RedHat email.
> Unfortunately, for now, this key can not be signed by other RedHat developers.
> I signed my tag and pushed it to GitHub. Should I resend this set of patches?

No, there's no need to resend.

If you get an opportunity at some point to get some signatures
on your gpg key that would be great, but I know it's tricky
especially at the moment and for the last couple of years.

> For tag signing, I use the 'git tag -s' command.
> I am sorry for the mistakes, this is my first PR.

No worries.

Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/7.0
for any user-visible changes.

-- PMM