nbd/server.c: Remove unused field

Commit Message

Nir Soffer Jan. 11, 2022, 7:43 p.m. UTC

NBDRequestData struct has unused QSIMPLEQ_ENTRY filed. It seems that
this field exists since the first git commit and was never used.

Signed-off-by: Nir Soffer <[e-mail]>
---
 nbd/server.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Philippe Mathieu-Daudé Jan. 11, 2022, 8:17 p.m. UTC | #1

On 1/11/22 20:43, Nir Soffer wrote:
> NBDRequestData struct has unused QSIMPLEQ_ENTRY filed. It seems that
> this field exists since the first git commit and was never used.
> 
> Signed-off-by: Nir Soffer <[e-mail]>
> ---
>  nbd/server.c | 1 -
>  1 file changed, 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <[e-mail]>

Eric Blake Jan. 12, 2022, 2:55 p.m. UTC | #2

On Tue, Jan 11, 2022 at 09:17:43PM +0100, Philippe Mathieu-Daudé wrote:
> On 1/11/22 20:43, Nir Soffer wrote:
> > NBDRequestData struct has unused QSIMPLEQ_ENTRY filed. It seems that

s/filed/field/

> > this field exists since the first git commit and was never used.

If my git sleuthing is right, that's commit d9a73806, from 2011.

> > 
> > Signed-off-by: Nir Soffer <[e-mail]>
> > ---
> >  nbd/server.c | 1 -
> >  1 file changed, 1 deletion(-)
> 
> Reviewed-by: Philippe Mathieu-Daudé <[e-mail]>

Thanks, I'll add that to my NBD queue.

Patch

diff --git a/nbd/server.c b/nbd/server.c
index 3927f7789d..ce5b2a1d02 100644
--- a/nbd/server.c
+++ b/nbd/server.c
@@ -70,21 +70,20 @@  static int system_errno_to_nbd_errno(int err)
     default:
         return NBD_EINVAL;
     }
 }
 
 /* Definitions for opaque data types */
 
 typedef struct NBDRequestData NBDRequestData;
 
 struct NBDRequestData {
-    QSIMPLEQ_ENTRY(NBDRequestData) entry;
     NBDClient *client;
     uint8_t *data;
     bool complete;
 };
 
 struct NBDExport {
     BlockExport common;
 
     char *name;
     char *description;