| Message ID | 20220122003104.84391-1-f4bug@amsat.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | hw/ppc/vof: Add missing includes | expand |
Cc'ing qemu-trivial@ On 22/1/22 01:31, Philippe Mathieu-Daudé wrote: > vof.h requires "qom/object.h" for DECLARE_CLASS_CHECKERS(), > "exec/memory.h" for address_space_read/write(), > "exec/address-spaces.h" for address_space_memory > and more importantly "cpu.h" for target_ulong. > > vof.c doesn't need "exec/ram_addr.h". > > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > hw/ppc/vof.c | 1 - > include/hw/ppc/vof.h | 5 +++++ > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/hw/ppc/vof.c b/hw/ppc/vof.c > index 73adc44ec2..2b63a62875 100644 > --- a/hw/ppc/vof.c > +++ b/hw/ppc/vof.c > @@ -16,7 +16,6 @@ > #include "qemu/units.h" > #include "qemu/log.h" > #include "qapi/error.h" > -#include "exec/ram_addr.h" > #include "exec/address-spaces.h" > #include "hw/ppc/vof.h" > #include "hw/ppc/fdt.h" > diff --git a/include/hw/ppc/vof.h b/include/hw/ppc/vof.h > index 97fdef758b..f8c0effcaf 100644 > --- a/include/hw/ppc/vof.h > +++ b/include/hw/ppc/vof.h > @@ -6,6 +6,11 @@ > #ifndef HW_VOF_H > #define HW_VOF_H > > +#include "qom/object.h" > +#include "exec/address-spaces.h" > +#include "exec/memory.h" > +#include "cpu.h" > + > typedef struct Vof { > uint64_t top_addr; /* copied from rma_size */ > GArray *claimed; /* array of SpaprOfClaimed */
On 1/30/22 20:38, Philippe Mathieu-Daudé wrote: > Cc'ing qemu-trivial@ > It is queued in ppc-7.0. I should send a PR today or tomorrow. Thanks, C. > On 22/1/22 01:31, Philippe Mathieu-Daudé wrote: >> vof.h requires "qom/object.h" for DECLARE_CLASS_CHECKERS(), >> "exec/memory.h" for address_space_read/write(), >> "exec/address-spaces.h" for address_space_memory >> and more importantly "cpu.h" for target_ulong. >> >> vof.c doesn't need "exec/ram_addr.h". >> >> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> >> --- >> hw/ppc/vof.c | 1 - >> include/hw/ppc/vof.h | 5 +++++ >> 2 files changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/hw/ppc/vof.c b/hw/ppc/vof.c >> index 73adc44ec2..2b63a62875 100644 >> --- a/hw/ppc/vof.c >> +++ b/hw/ppc/vof.c >> @@ -16,7 +16,6 @@ >> #include "qemu/units.h" >> #include "qemu/log.h" >> #include "qapi/error.h" >> -#include "exec/ram_addr.h" >> #include "exec/address-spaces.h" >> #include "hw/ppc/vof.h" >> #include "hw/ppc/fdt.h" >> diff --git a/include/hw/ppc/vof.h b/include/hw/ppc/vof.h >> index 97fdef758b..f8c0effcaf 100644 >> --- a/include/hw/ppc/vof.h >> +++ b/include/hw/ppc/vof.h >> @@ -6,6 +6,11 @@ >> #ifndef HW_VOF_H >> #define HW_VOF_H >> +#include "qom/object.h" >> +#include "exec/address-spaces.h" >> +#include "exec/memory.h" >> +#include "cpu.h" >> + >> typedef struct Vof { >> uint64_t top_addr; /* copied from rma_size */ >> GArray *claimed; /* array of SpaprOfClaimed */ >
On 31/1/22 08:45, Cédric Le Goater wrote: > On 1/30/22 20:38, Philippe Mathieu-Daudé wrote: >> Cc'ing qemu-trivial@ >> > > It is queued in ppc-7.0. I should send a PR today or tomorrow. Thanks!
diff --git a/hw/ppc/vof.c b/hw/ppc/vof.c index 73adc44ec2..2b63a62875 100644 --- a/hw/ppc/vof.c +++ b/hw/ppc/vof.c @@ -16,7 +16,6 @@ #include "qemu/units.h" #include "qemu/log.h" #include "qapi/error.h" -#include "exec/ram_addr.h" #include "exec/address-spaces.h" #include "hw/ppc/vof.h" #include "hw/ppc/fdt.h" diff --git a/include/hw/ppc/vof.h b/include/hw/ppc/vof.h index 97fdef758b..f8c0effcaf 100644 --- a/include/hw/ppc/vof.h +++ b/include/hw/ppc/vof.h @@ -6,6 +6,11 @@ #ifndef HW_VOF_H #define HW_VOF_H +#include "qom/object.h" +#include "exec/address-spaces.h" +#include "exec/memory.h" +#include "cpu.h" + typedef struct Vof { uint64_t top_addr; /* copied from rma_size */ GArray *claimed; /* array of SpaprOfClaimed */
vof.h requires "qom/object.h" for DECLARE_CLASS_CHECKERS(), "exec/memory.h" for address_space_read/write(), "exec/address-spaces.h" for address_space_memory and more importantly "cpu.h" for target_ulong. vof.c doesn't need "exec/ram_addr.h". Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> --- hw/ppc/vof.c | 1 - include/hw/ppc/vof.h | 5 +++++ 2 files changed, 5 insertions(+), 1 deletion(-)