| Message ID | 20220131125615.74612-1-eesposit@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | block.h: remove outdated comment | expand |
On 31/1/22 13:56, Emanuele Giuseppe Esposito wrote: > The comment "disk I/O throttling" doesn't make any sense at all > any more. It was added in commit 0563e191516 to describe > bdrv_io_limits_enable()/disable(), which were removed in commit > 97148076, so the comment is just a forgotten leftover. > > Suggested-by: Kevin Wolf <kwolf@redhat.com> > Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com> > --- > include/block/block.h | 1 - > 1 file changed, 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
On 31.01.22 13:56, Emanuele Giuseppe Esposito wrote: > The comment "disk I/O throttling" doesn't make any sense at all > any more. It was added in commit 0563e191516 to describe > bdrv_io_limits_enable()/disable(), which were removed in commit > 97148076, so the comment is just a forgotten leftover. > > Suggested-by: Kevin Wolf <kwolf@redhat.com> > Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com> > --- > include/block/block.h | 1 - > 1 file changed, 1 deletion(-) Thanks, applied to my block branch: https://gitlab.com/hreitz/qemu/-/commits/block
Am 31.01.2022 um 13:56 hat Emanuele Giuseppe Esposito geschrieben: > The comment "disk I/O throttling" doesn't make any sense at all > any more. It was added in commit 0563e191516 to describe > bdrv_io_limits_enable()/disable(), which were removed in commit > 97148076, so the comment is just a forgotten leftover. > > Suggested-by: Kevin Wolf <kwolf@redhat.com> > Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com> Thanks, applied to the block branch. Kevin
diff --git a/include/block/block.h b/include/block/block.h index 9d4050220b..e1713ee306 100644 --- a/include/block/block.h +++ b/include/block/block.h @@ -344,7 +344,6 @@ typedef unsigned int BdrvChildRole; char *bdrv_perm_names(uint64_t perm); uint64_t bdrv_qapi_perm_to_blk_perm(BlockPermission qapi_perm); -/* disk I/O throttling */ void bdrv_init(void); void bdrv_init_with_whitelist(void); bool bdrv_uses_whitelist(void);
The comment "disk I/O throttling" doesn't make any sense at all any more. It was added in commit 0563e191516 to describe bdrv_io_limits_enable()/disable(), which were removed in commit 97148076, so the comment is just a forgotten leftover. Suggested-by: Kevin Wolf <kwolf@redhat.com> Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com> --- include/block/block.h | 1 - 1 file changed, 1 deletion(-)