| Message ID | 20220201085554.85733-1-thuth@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | tests/lcitool: Allow lcitool-refresh in out-of-tree builds, too | expand |
On Tue, Feb 01, 2022 at 09:55:54AM +0100, Thomas Huth wrote: > When running "make lcitool-refresh" in an out-of-tree build, it > currently fails with an error message from git like this: > > fatal: not a git repository (or any parent up to mount point /) > Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set). > > Fix it by changing to the source directory first before updating > the submodule. > > Signed-off-by: Thomas Huth <thuth@redhat.com> > --- > tests/lcitool/Makefile.include | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Regards, Daniel
Thomas Huth <thuth@redhat.com> writes: > When running "make lcitool-refresh" in an out-of-tree build, it > currently fails with an error message from git like this: > > fatal: not a git repository (or any parent up to mount point /) > Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set). > > Fix it by changing to the source directory first before updating > the submodule. > > Signed-off-by: Thomas Huth <thuth@redhat.com> Queued to testing/next, thanks.
On 2/1/22 09:55, Thomas Huth wrote: > When running "make lcitool-refresh" in an out-of-tree build, it > currently fails with an error message from git like this: > > fatal: not a git repository (or any parent up to mount point /) > Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set). > > Fix it by changing to the source directory first before updating > the submodule. > > Signed-off-by: Thomas Huth <thuth@redhat.com> > --- > tests/lcitool/Makefile.include | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
diff --git a/tests/lcitool/Makefile.include b/tests/lcitool/Makefile.include index cff7c0b814..6b215adcd1 100644 --- a/tests/lcitool/Makefile.include +++ b/tests/lcitool/Makefile.include @@ -13,5 +13,5 @@ lcitool: lcitool-help: lcitool lcitool-refresh: - $(call quiet-command, git submodule update --init $(SRC_PATH)/tests/lcitool/libvirt-ci) + $(call quiet-command, cd $(SRC_PATH) && git submodule update --init tests/lcitool/libvirt-ci) $(call quiet-command, $(LCITOOL_REFRESH))
When running "make lcitool-refresh" in an out-of-tree build, it currently fails with an error message from git like this: fatal: not a git repository (or any parent up to mount point /) Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set). Fix it by changing to the source directory first before updating the submodule. Signed-off-by: Thomas Huth <thuth@redhat.com> --- tests/lcitool/Makefile.include | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)