| Message ID | 20220520180109.8224-9-shentey@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Random cleanup patches | expand |
Am 20. Mai 2022 18:01:07 UTC schrieb Bernhard Beschow <shentey@gmail.com>: >Commit 3a841ab53f165910224dc4bebabf1a8f1d04200c 'qapi: introduce >x-query-jit QMP command' basically moved the only function using >dump_drift_info() to cpu-exec.c. Therefore, dump_drift_info() doesn't >need to be exported any longer. > >Signed-off-by: Bernhard Beschow <shentey@gmail.com> >--- > accel/tcg/cpu-exec.c | 2 +- > include/exec/cpu-all.h | 2 -- > 2 files changed, 1 insertion(+), 3 deletions(-) > >diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c >index 635aeecc0a..7cbf9996b7 100644 >--- a/accel/tcg/cpu-exec.c >+++ b/accel/tcg/cpu-exec.c >@@ -1048,7 +1048,7 @@ void tcg_exec_unrealizefn(CPUState *cpu) > > #ifndef CONFIG_USER_ONLY > >-void dump_drift_info(GString *buf) >+static void dump_drift_info(GString *buf) > { > if (!icount_enabled()) { > return; >diff --git a/include/exec/cpu-all.h b/include/exec/cpu-all.h >index 5d5290deb5..9a716be80d 100644 >--- a/include/exec/cpu-all.h >+++ b/include/exec/cpu-all.h >@@ -419,8 +419,6 @@ static inline bool tlb_hit(target_ulong tlb_addr, target_ulong addr) > } > > #ifdef CONFIG_TCG >-/* accel/tcg/cpu-exec.c */ >-void dump_drift_info(GString *buf); > /* accel/tcg/translate-all.c */ > void dump_exec_info(GString *buf); > void dump_opcount_info(GString *buf); Ping
On 20/5/22 20:01, Bernhard Beschow wrote: > Commit 3a841ab53f165910224dc4bebabf1a8f1d04200c 'qapi: introduce > x-query-jit QMP command' basically moved the only function using > dump_drift_info() to cpu-exec.c. Therefore, dump_drift_info() doesn't > need to be exported any longer. > > Signed-off-by: Bernhard Beschow <shentey@gmail.com> > --- > accel/tcg/cpu-exec.c | 2 +- > include/exec/cpu-all.h | 2 -- > 2 files changed, 1 insertion(+), 3 deletions(-) Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c index 635aeecc0a..7cbf9996b7 100644 --- a/accel/tcg/cpu-exec.c +++ b/accel/tcg/cpu-exec.c @@ -1048,7 +1048,7 @@ void tcg_exec_unrealizefn(CPUState *cpu) #ifndef CONFIG_USER_ONLY -void dump_drift_info(GString *buf) +static void dump_drift_info(GString *buf) { if (!icount_enabled()) { return; diff --git a/include/exec/cpu-all.h b/include/exec/cpu-all.h index 5d5290deb5..9a716be80d 100644 --- a/include/exec/cpu-all.h +++ b/include/exec/cpu-all.h @@ -419,8 +419,6 @@ static inline bool tlb_hit(target_ulong tlb_addr, target_ulong addr) } #ifdef CONFIG_TCG -/* accel/tcg/cpu-exec.c */ -void dump_drift_info(GString *buf); /* accel/tcg/translate-all.c */ void dump_exec_info(GString *buf); void dump_opcount_info(GString *buf);
Commit 3a841ab53f165910224dc4bebabf1a8f1d04200c 'qapi: introduce x-query-jit QMP command' basically moved the only function using dump_drift_info() to cpu-exec.c. Therefore, dump_drift_info() doesn't need to be exported any longer. Signed-off-by: Bernhard Beschow <shentey@gmail.com> --- accel/tcg/cpu-exec.c | 2 +- include/exec/cpu-all.h | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-)