| Message ID | 20220612204851.19914-4-imp@bsdimp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | bsd-user: Next round of syscalls | expand |
On 6/12/22 13:48, Warner Losh wrote: > Signed-off-by: Stacey Son<sson@FreeBSD.org> > Signed-off-by: Warner Losh<imp@bsdimp.com> > --- > bsd-user/bsd-file.h | 53 +++++++++++++++++++++++++++++++++++ > bsd-user/freebsd/os-syscall.c | 16 +++++++++++ > 2 files changed, 69 insertions(+) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
On 12/6/22 22:48, Warner Losh wrote: > Signed-off-by: Stacey Son <sson@FreeBSD.org> > Signed-off-by: Warner Losh <imp@bsdimp.com> > --- > bsd-user/bsd-file.h | 53 +++++++++++++++++++++++++++++++++++ > bsd-user/freebsd/os-syscall.c | 16 +++++++++++ > 2 files changed, 69 insertions(+) > > diff --git a/bsd-user/bsd-file.h b/bsd-user/bsd-file.h > index 3e0f160e312..37b3efccd2c 100644 > --- a/bsd-user/bsd-file.h > +++ b/bsd-user/bsd-file.h > @@ -262,4 +262,57 @@ static abi_long do_bsd_closefrom(abi_long arg1) > return get_errno(0); > } > > +/* revoke(2) */ > +static abi_long do_bsd_revoke(abi_long arg1) > +{ > + abi_long ret; > + void *p; > + > + LOCK_PATH(p, arg1); > + ret = get_errno(revoke(p)); /* XXX path(p)? */ > + UNLOCK_PATH(p, arg1); > + > + return ret; > +} Out of curiosity, what is the problem with path(p) here? > +/* faccessat(2) */ > +static abi_long do_bsd_faccessat(abi_long arg1, abi_long arg2, > + abi_long arg3, abi_long arg4) > +{ > + abi_long ret; > + void *p; > + > + LOCK_PATH(p, arg2); > + ret = get_errno(faccessat(arg1, p, arg3, arg4)); /* XXX path(p)? */ > + UNLOCK_PATH(p, arg2); > + > + return ret; > +}
diff --git a/bsd-user/bsd-file.h b/bsd-user/bsd-file.h index 3e0f160e312..37b3efccd2c 100644 --- a/bsd-user/bsd-file.h +++ b/bsd-user/bsd-file.h @@ -262,4 +262,57 @@ static abi_long do_bsd_closefrom(abi_long arg1) return get_errno(0); } +/* revoke(2) */ +static abi_long do_bsd_revoke(abi_long arg1) +{ + abi_long ret; + void *p; + + LOCK_PATH(p, arg1); + ret = get_errno(revoke(p)); /* XXX path(p)? */ + UNLOCK_PATH(p, arg1); + + return ret; +} + +/* access(2) */ +static abi_long do_bsd_access(abi_long arg1, abi_long arg2) +{ + abi_long ret; + void *p; + + LOCK_PATH(p, arg1); + ret = get_errno(access(path(p), arg2)); + UNLOCK_PATH(p, arg1); + + return ret; +} + +/* eaccess(2) */ +static abi_long do_bsd_eaccess(abi_long arg1, abi_long arg2) +{ + abi_long ret; + void *p; + + LOCK_PATH(p, arg1); + ret = get_errno(eaccess(path(p), arg2)); + UNLOCK_PATH(p, arg1); + + return ret; +} + +/* faccessat(2) */ +static abi_long do_bsd_faccessat(abi_long arg1, abi_long arg2, + abi_long arg3, abi_long arg4) +{ + abi_long ret; + void *p; + + LOCK_PATH(p, arg2); + ret = get_errno(faccessat(arg1, p, arg3, arg4)); /* XXX path(p)? */ + UNLOCK_PATH(p, arg2); + + return ret; +} + #endif /* BSD_FILE_H */ diff --git a/bsd-user/freebsd/os-syscall.c b/bsd-user/freebsd/os-syscall.c index f7d09909925..7b7af914e49 100644 --- a/bsd-user/freebsd/os-syscall.c +++ b/bsd-user/freebsd/os-syscall.c @@ -285,6 +285,22 @@ static abi_long freebsd_syscall(void *cpu_env, int num, abi_long arg1, ret = do_bsd_closefrom(arg1); break; + case TARGET_FREEBSD_NR_revoke: /* revoke(2) */ + ret = do_bsd_revoke(arg1); + break; + + case TARGET_FREEBSD_NR_access: /* access(2) */ + ret = do_bsd_access(arg1, arg2); + break; + + case TARGET_FREEBSD_NR_eaccess: /* eaccess(2) */ + ret = do_bsd_eaccess(arg1, arg2); + break; + + case TARGET_FREEBSD_NR_faccessat: /* faccessat(2) */ + ret = do_bsd_faccessat(arg1, arg2, arg3, arg4); + break; + default: qemu_log_mask(LOG_UNIMP, "Unsupported syscall: %d\n", num); ret = -TARGET_ENOSYS;