| Message ID | 20220913191321.96747-1-deller@gmx.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
The close_range(2) man page says:
close_range() first appeared in Linux 5.9. Library support was added
in glibc in version 2.34.
The qemu-user GitLab CI jobs are failing. For example, see
https://gitlab.com/qemu-project/qemu/-/jobs/3043629417:
../linux-user/syscall.c:8734:26: error: implicit declaration of
function 'close_range' is invalid in C99
[-Werror,-Wimplicit-function-declaration]
return get_errno(close_range(arg1, arg2, arg3));
^
There is a second issue with this pull request:
../linux-user/syscall.c:357:16: error: ‘pidfd_getfd’ defined but not
used [-Werror=unused-function]
357 | _syscall3(int, pidfd_getfd, int, pidfd, int, targetfd, unsigned
int, flags);
| ^~~~~~~~~~~
../linux-user/syscall.c:251:13: note: in definition of macro ‘_syscall3’
See https://gitlab.com/qemu-project/qemu/-/jobs/3043629434.
Stefan
On 17/9/22 16:26, Stefan Hajnoczi wrote: > The close_range(2) man page says: > close_range() first appeared in Linux 5.9. Library support was added > in glibc in version 2.34. > > The qemu-user GitLab CI jobs are failing. For example, see > https://gitlab.com/qemu-project/qemu/-/jobs/3043629417: > > ../linux-user/syscall.c:8734:26: error: implicit declaration of > function 'close_range' is invalid in C99 > [-Werror,-Wimplicit-function-declaration] > return get_errno(close_range(arg1, arg2, arg3)); > ^ > > There is a second issue with this pull request: > ../linux-user/syscall.c:357:16: error: ‘pidfd_getfd’ defined but not > used [-Werror=unused-function] > 357 | _syscall3(int, pidfd_getfd, int, pidfd, int, targetfd, unsigned > int, flags); > | ^~~~~~~~~~~ > ../linux-user/syscall.c:251:13: note: in definition of macro ‘_syscall3’ > > See https://gitlab.com/qemu-project/qemu/-/jobs/3043629434. Hmm apparently this PR hasn't been reviewed (although the patches were on the list for 2 weeks). The 'check DCO' job - looking for S-o-b tags - is green: https://gitlab.com/qemu-project/qemu/-/jobs/3043629425. Should we complete it by a R-b/A-b check over the commit range?
On Sat, 17 Sept 2022 at 15:31, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote: > > On 17/9/22 16:26, Stefan Hajnoczi wrote: > > The close_range(2) man page says: > > close_range() first appeared in Linux 5.9. Library support was added > > in glibc in version 2.34. > > > > The qemu-user GitLab CI jobs are failing. For example, see > > https://gitlab.com/qemu-project/qemu/-/jobs/3043629417: > > > > ../linux-user/syscall.c:8734:26: error: implicit declaration of > > function 'close_range' is invalid in C99 > > [-Werror,-Wimplicit-function-declaration] > > return get_errno(close_range(arg1, arg2, arg3)); > > ^ > > > > There is a second issue with this pull request: > > ../linux-user/syscall.c:357:16: error: ‘pidfd_getfd’ defined but not > > used [-Werror=unused-function] > > 357 | _syscall3(int, pidfd_getfd, int, pidfd, int, targetfd, unsigned > > int, flags); > > | ^~~~~~~~~~~ > > ../linux-user/syscall.c:251:13: note: in definition of macro ‘_syscall3’ > > > > See https://gitlab.com/qemu-project/qemu/-/jobs/3043629434. > > Hmm apparently this PR hasn't been reviewed (although the patches were > on the list for 2 weeks). > > The 'check DCO' job - looking for S-o-b tags - is green: > https://gitlab.com/qemu-project/qemu/-/jobs/3043629425. > Should we complete it by a R-b/A-b check over the commit range? In some areas there will be no R-b/A-b, so I don't think we can require those checks. Was this pull request supposed to go through Laurent instead of being applied directly by me? Stefan
On 9/17/22 22:11, Stefan Hajnoczi wrote: > On Sat, 17 Sept 2022 at 15:31, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote: >> >> On 17/9/22 16:26, Stefan Hajnoczi wrote: >>> The close_range(2) man page says: >>> close_range() first appeared in Linux 5.9. Library support was added >>> in glibc in version 2.34. >>> >>> The qemu-user GitLab CI jobs are failing. For example, see >>> https://gitlab.com/qemu-project/qemu/-/jobs/3043629417: >>> >>> ../linux-user/syscall.c:8734:26: error: implicit declaration of >>> function 'close_range' is invalid in C99 >>> [-Werror,-Wimplicit-function-declaration] >>> return get_errno(close_range(arg1, arg2, arg3)); >>> ^ >>> >>> There is a second issue with this pull request: >>> ../linux-user/syscall.c:357:16: error: ‘pidfd_getfd’ defined but not >>> used [-Werror=unused-function] >>> 357 | _syscall3(int, pidfd_getfd, int, pidfd, int, targetfd, unsigned >>> int, flags); >>> | ^~~~~~~~~~~ >>> ../linux-user/syscall.c:251:13: note: in definition of macro ‘_syscall3’ >>> >>> See https://gitlab.com/qemu-project/qemu/-/jobs/3043629434. Stefan, Thanks for testing those patches! I'll send a new series with those issues fixed soon. >> Hmm apparently this PR hasn't been reviewed (although the patches were >> on the list for 2 weeks). >> >> The 'check DCO' job - looking for S-o-b tags - is green: >> https://gitlab.com/qemu-project/qemu/-/jobs/3043629425. >> Should we complete it by a R-b/A-b check over the commit range? > > In some areas there will be no R-b/A-b, so I don't think we can > require those checks. > > Was this pull request supposed to go through Laurent instead of being > applied directly by me? I'm fine with either way :-) Thanks! Helge Btw, I have a whole bunch of additional patches on top of this series so it would be good to get this series in first...
The following changes since commit 621da7789083b80d6f1ff1c0fb499334007b4f51: Update version for v7.1.0 release (2022-08-30 09:40:11 -0700) are available in the Git repository at: https://github.com/hdeller/qemu-hppa.git tags/publish1-pull-request for you to fetch changes up to 192cac33ab6449202d0b44c4d664020b09ce9266: linux-user: Add parameters of getrandom() syscall for strace (2022-09-11 19:58:07 +0200) ---------------------------------------------------------------- linux-user: Add more syscalls, enhance tracing & logging enhancements - show missing signals in strace output - add pidfd_open(), pidfd_send_signal(), pidfd_getfd() and close_range() syscalls - add and enhance strace output for clock_gettime64(), chmod(), clock_nanosleep(), futex() and getrandom() syscalls - show failing executable in EXCP_DUMP() - increase TASK_UNMAPPED_BASE and dump IIR on register dump (on hppa target) ---------------------------------------------------------------- Helge Deller (12): linux-user: Add missing signals in strace output linux-user: Add missing clock_gettime64() syscall strace linux-user: Add pidfd_open(), pidfd_send_signal() and pidfd_getfd() syscalls linux-user: Log failing executable in EXCP_DUMP() linux-user/hppa: Use EXCP_DUMP() to show enhanced debug info linux-user/hppa: Dump IIR on register dump linux-user: Fix strace of chmod() if mode == 0 linux-user/hppa: Set TASK_UNMAPPED_BASE to 0xfa000000 for hppa arch linux-user: Add strace for clock_nanosleep() linux-user: Show timespec on strace for futex() linux-user: Add close_range() syscall linux-user: Add parameters of getrandom() syscall for strace linux-user/cpu_loop-common.h | 2 + linux-user/hppa/cpu_loop.c | 6 +- linux-user/mmap.c | 4 + linux-user/signal-common.h | 46 ++++++++++++ linux-user/signal.c | 37 +-------- linux-user/strace.c | 142 ++++++++++++++++++++++++++++++----- linux-user/strace.list | 21 +++++- linux-user/syscall.c | 46 ++++++++++++ target/hppa/helper.c | 6 +- 9 files changed, 251 insertions(+), 59 deletions(-) -- 2.37.2