[v5,1/2] block: Ignore close() failure in get_tmp_filename()

Commit Message

Bin Meng Sept. 28, 2022, 2:41 p.m. UTC

From: Bin Meng <[e-mail]>

The temporary file has been created and is ready for use. Checking
return value of close() does not seem useful. The file descriptor
is almost certainly closed; see close(2) under "Dealing with error
returns from close()".

Let's simply ignore close() failure here.

Suggested-by: Markus Armbruster <[e-mail]>
Signed-off-by: Bin Meng <[e-mail]>
---

Changes in v5:
- new patch: "block: Ignore close() failure in get_tmp_filename()"

 block.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

Comments

Markus Armbruster Sept. 29, 2022, 11:50 a.m. UTC | #1

Bin Meng <[e-mail]> writes:

> From: Bin Meng <[e-mail]>
>
> The temporary file has been created and is ready for use. Checking
> return value of close() does not seem useful. The file descriptor
> is almost certainly closed; see close(2) under "Dealing with error
> returns from close()".
>
> Let's simply ignore close() failure here.
>
> Suggested-by: Markus Armbruster <[e-mail]>
> Signed-off-by: Bin Meng <[e-mail]>
> ---
>
> Changes in v5:
> - new patch: "block: Ignore close() failure in get_tmp_filename()"
>
>  block.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/block.c b/block.c
> index bc85f46eed..582c205307 100644
> --- a/block.c
> +++ b/block.c
> @@ -886,10 +886,7 @@ int get_tmp_filename(char *filename, int size)
>      if (fd < 0) {
>          return -errno;
>      }
> -    if (close(fd) != 0) {
> -        unlink(filename);
> -        return -errno;
> -    }
> +    close(fd);
>      return 0;
>  #endif
>  }

Reviewed-by: Markus Armbruster <[e-mail]>

Patch

diff --git a/block.c b/block.c
index bc85f46eed..582c205307 100644
--- a/block.c
+++ b/block.c
@@ -886,10 +886,7 @@  int get_tmp_filename(char *filename, int size)
     if (fd < 0) {
         return -errno;
     }
-    if (close(fd) != 0) {
-        unlink(filename);
-        return -errno;
-    }
+    close(fd);
     return 0;
 #endif
 }