[v2,01/11] target/riscv: do not mask unsupported QEMU extensions in write_misa()

Commit Message

Daniel Henrique Barboza Feb. 14, 2023, 7:23 p.m. UTC

The masking done using env->misa_ext_mask already filters any extension
that QEMU doesn't support. If the hart supports the extension then QEMU
supports it as well.

If the masking done by env->misa_ext_mask is somehow letting unsupported
QEMU extensions pass by, misa_ext_mask itself needs to be fixed instead.

Reviewed-by: Weiwei Li <[e-mail]>
Signed-off-by: Daniel Henrique Barboza <[e-mail]>
---
 target/riscv/csr.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Bin Meng Feb. 15, 2023, 11:22 a.m. UTC | #1

On Wed, Feb 15, 2023 at 3:26 AM Daniel Henrique Barboza
<[e-mail]> wrote:
>
> The masking done using env->misa_ext_mask already filters any extension
> that QEMU doesn't support. If the hart supports the extension then QEMU
> supports it as well.
>
> If the masking done by env->misa_ext_mask is somehow letting unsupported
> QEMU extensions pass by, misa_ext_mask itself needs to be fixed instead.
>
> Reviewed-by: Weiwei Li <[e-mail]>
> Signed-off-by: Daniel Henrique Barboza <[e-mail]>
> ---
>  target/riscv/csr.c | 3 ---
>  1 file changed, 3 deletions(-)
>

Reviewed-by: Bin Meng <[e-mail]>

Patch

diff --git a/target/riscv/csr.c b/target/riscv/csr.c
index 1b0a0c1693..e149b453da 100644
--- a/target/riscv/csr.c
+++ b/target/riscv/csr.c
@@ -1356,9 +1356,6 @@  static RISCVException write_misa(CPURISCVState *env, int csrno,
     /* Mask extensions that are not supported by this hart */
     val &= env->misa_ext_mask;
 
-    /* Mask extensions that are not supported by QEMU */
-    val &= (RVI | RVE | RVM | RVA | RVF | RVD | RVC | RVS | RVU | RVV);
-
     /* 'D' depends on 'F', so clear 'D' if 'F' is not present */
     if ((val & RVD) && !(val & RVF)) {
         val &= ~RVD;