Message ID | 20200226113355.2532224-1-anthony.perard@citrix.com (mailing list archive) |
---|---|
Headers | show |
Series | xen: Build system improvements | expand |
On Wednesday, February 26, 2020 6:34 AM, Anthony PERARD wrote: >Patch series available in this git branch: >https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.build-system-xen-v3 > >v3: >- new patches that do some cleanup or fix issues >- have rework most patches, to have better commit message or change the coding > style, or fix issues that I've seen. There were some cases where CFLAGS were > missing. > See patch notes for details >- introduce if_changed*. That plenty of new patches on top of what we had in v2. > (those changes ignore CONFIG_LTO=y, I'll see about fixing that later) > >(There is more to come in order to use fixdep from Linux, but that's not ready) > >v2.1: >- some fixes > >v2: >Rather than taking Kbuild and making it work with Xen, the v2 takes the opposite >approach of slowly transforming our current build system into Kbuild. That have >the advantage of keeping all the feature we have and making the patches much >easier to review. Kconfig update is done in an other patch series. > >Hi, > >I have work toward building Xen (the hypervisor) with Linux's build system, >Kbuild. > >The main reason for that is to be able to have out-of-tree build. It's annoying >when a build fail because of the pvshim. Other benefit is a much faster >rebuild, and `make clean` doesn't take ages, and better dependencies to figure >out what needs to be rebuild. > >So, we are not there yet, but the series already contain quite a few >improvement and cleanup. More patches are going to be added to the series. Thanks for your efforts with this. With your br.build-system-xen-v3 branch, I'm having trouble doing an aarch64 build with early printk enabled. I suspect the following unmerged patch that Julien authored last September may have some helpful information: https://lists.xenproject.org/archives/html/xen-devel/2019-09/msg01207.html I tried the following... echo "CONFIG_DEBUG=y" > xen/arch/arm/configs/arm64_defconfig make -C xen XEN_TARGET_ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- CONFIG_EARLY_PRINTK=zynqmp defconfig make XEN_TARGET_ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- CONFIG_EARLY_PRINTK=zynqmp dist-xen ... but I was met with: prelink.o:(.data+0x578): undefined reference to `early_puts' aarch64-linux-gnu-ld: /home/stew/rpi/xen/xen/.xen-syms.0: hidden symbol `early_puts' isn't defined Stew
On Thu, Feb 27, 2020 at 09:17:51PM +0000, Stewart Hildebrand wrote: > Thanks for your efforts with this. With your br.build-system-xen-v3 > branch, I'm having trouble doing an aarch64 build with early printk > enabled. I suspect the following unmerged patch that Julien authored > last September may have some helpful information: > https://lists.xenproject.org/archives/html/xen-devel/2019-09/msg01207.html Thank you Stewart for testing! And thanks for pointing out Julien's patch, that looks like the best way to fix the problem. I'll fix the issue. The issue is in patch [XEN PATCH v3 15/23] xen/build: have the root Makefile generates the CFLAGS where EARLY_PRINTK isn't set when needed anymore. > I tried the following... > > echo "CONFIG_DEBUG=y" > xen/arch/arm/configs/arm64_defconfig > make -C xen XEN_TARGET_ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- CONFIG_EARLY_PRINTK=zynqmp defconfig > make XEN_TARGET_ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- CONFIG_EARLY_PRINTK=zynqmp dist-xen > > ... but I was met with: > prelink.o:(.data+0x578): undefined reference to `early_puts' > aarch64-linux-gnu-ld: /home/stew/rpi/xen/xen/.xen-syms.0: hidden symbol `early_puts' isn't defined Cheers,