[v2,0/4] x86/intr: guest interrupt handling fixes/cleanup

Message

Roger Pau Monné Jan. 15, 2021, 2:28 p.m. UTC

Hello,

The following series aims to fix some shortcomings of guest interrupt
handling when using passthrough devices. The first 3 patches are
bugfixes, which I think should solve the issue(s) that caused the dpci
EOI timer to be introduced. However neither me nor others seem to be able
to reproduce the original issue, so it's hard to tell.

It's my opinion that we should remove the timer and see what explodes
(if anything). That's the only way we will be able to figure out what
the original issue was, and how to fix it without introducing yet
another per-guest-irq related timer.

Thanks, Roger.

Roger Pau Monne (4):
  x86/vioapic: check IRR before attempting to inject interrupt after EOI
  x86/vioapic: issue EOI to dpci when switching pin to edge trigger mode
  x86/vpic: issue dpci EOI for cleared pins at ICW1
  x86/dpci: remove the dpci EOI timer

 xen/arch/x86/hvm/vioapic.c            | 13 +++-
 xen/arch/x86/hvm/vpic.c               | 21 ++++++
 xen/drivers/passthrough/vtd/x86/hvm.c |  3 -
 xen/drivers/passthrough/x86/hvm.c     | 95 +--------------------------
 xen/include/asm-x86/hvm/irq.h         |  3 -
 xen/include/xen/iommu.h               |  5 --
 6 files changed, 35 insertions(+), 105 deletions(-)