diff mbox

[v1] libxc: fix uninitialized variable when changing rtds scheduling parameters

Message ID 1459974638-7102-1-git-send-email-lichong659@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Chong Li April 6, 2016, 8:30 p.m. UTC 
Commit 046c2b503a89d21b41e4d555a9f75d02af00dbc6 introduces a build
failure: in some cases (e.g., num_vcpus <=0),
xc_sched_rtds_vcpu_get/set returns an uninitialized variable.

Fix it.

Signed-off-by: Chong Li <chong.li@wustl.edu>

---
CC: <dario.faggioli@citrix.com>
CC: <george.dunlap@eu.citrix.com>
CC: <dgolomb@seas.upenn.edu>
CC: <mengxu@cis.upenn.edu>
CC: <wei.liu2@citrix.com>
CC: <ian.jackson@eu.citrix.com>
CC: <lichong659@gmail.com>
---
 tools/libxc/xc_rt.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Andrew Cooper April 6, 2016, 8:35 p.m. UTC | #1 
On 06/04/16 21:30, Chong Li wrote:
> Commit 046c2b503a89d21b41e4d555a9f75d02af00dbc6 introduces a build
> failure: in some cases (e.g., num_vcpus <=0),
> xc_sched_rtds_vcpu_get/set returns an uninitialized variable.
>
> Fix it.
>
> Signed-off-by: Chong Li <chong.li@wustl.edu>
>
> ---
> CC: <dario.faggioli@citrix.com>
> CC: <george.dunlap@eu.citrix.com>
> CC: <dgolomb@seas.upenn.edu>
> CC: <mengxu@cis.upenn.edu>
> CC: <wei.liu2@citrix.com>
> CC: <ian.jackson@eu.citrix.com>
> CC: <lichong659@gmail.com>

LGTM.

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
Dario Faggioli April 6, 2016, 9:50 p.m. UTC | #2 
On Wed, 2016-04-06 at 21:35 +0100, Andrew Cooper wrote:
> On 06/04/16 21:30, Chong Li wrote:
> > 
> > Commit 046c2b503a89d21b41e4d555a9f75d02af00dbc6 introduces a build
> > failure: in some cases (e.g., num_vcpus <=0),
> > xc_sched_rtds_vcpu_get/set returns an uninitialized variable.
> > 
> > Fix it.
> > 
> > Signed-off-by: Chong Li <chong.li@wustl.edu>
> > 
> > ---
> > CC: <dario.faggioli@citrix.com>
> > CC: <george.dunlap@eu.citrix.com>
> > CC: <dgolomb@seas.upenn.edu>
> > CC: <mengxu@cis.upenn.edu>
> > CC: <wei.liu2@citrix.com>
> > CC: <ian.jackson@eu.citrix.com>
> > CC: <lichong659@gmail.com>
> LGTM.
> 
> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
>
Reviewed-by: Dario Faggioli <dario.faggioli@citrix.com>

Dario
Ian Jackson April 7, 2016, 10:36 a.m. UTC | #3 
Andrew Cooper writes ("Re: [Xen-devel] [PATCH v1] libxc: fix uninitialized variable when changing rtds scheduling parameters"):
> On 06/04/16 21:30, Chong Li wrote:
> > Commit 046c2b503a89d21b41e4d555a9f75d02af00dbc6 introduces a build
> > failure: in some cases (e.g., num_vcpus <=0),
> > xc_sched_rtds_vcpu_get/set returns an uninitialized variable.
> 
> LGTM.
> 
> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

Committed-by: Ian Jackson <ian.jackson@eu.citrix.com>
diff mbox

Patch

diff --git a/tools/libxc/xc_rt.c b/tools/libxc/xc_rt.c
index 221d17f..77aaa36 100644
--- a/tools/libxc/xc_rt.c
+++ b/tools/libxc/xc_rt.c
@@ -68,7 +68,7 @@  int xc_sched_rtds_vcpu_set(xc_interface *xch,
                            struct xen_domctl_schedparam_vcpu *vcpus,
                            uint32_t num_vcpus)
 {
-    int rc;
+    int rc = 0;
     unsigned processed = 0;
     DECLARE_DOMCTL;
     DECLARE_HYPERCALL_BOUNCE(vcpus, sizeof(*vcpus) * num_vcpus,
@@ -102,7 +102,7 @@  int xc_sched_rtds_vcpu_get(xc_interface *xch,
                            struct xen_domctl_schedparam_vcpu *vcpus,
                            uint32_t num_vcpus)
 {
-    int rc;
+    int rc = 0;
     unsigned processed = 0;
     DECLARE_DOMCTL;
     DECLARE_HYPERCALL_BOUNCE(vcpus, sizeof(*vcpus) * num_vcpus,