diff mbox

[OSSTEST,4/9] db retry, bisection: Reset %jobs_created on db retry

Message ID 1482259082-30767-5-git-send-email-ian.jackson@eu.citrix.com (mailing list archive)
State New, archived
Headers show

Commit Message

Ian Jackson Dec. 20, 2016, 6:37 p.m. UTC
%jobs_created is used for memoisation while populating the destination
flight.  We need to reset it when we restart flight construction,
because those jobs were created in the discarded transaction.

Otherwise we could create a flight with missing jobs.

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
---
 cs-bisection-step | 1 +
 1 file changed, 1 insertion(+)
diff mbox

Patch

diff --git a/cs-bisection-step b/cs-bisection-step
index 4c71587..1d1962a 100755
--- a/cs-bisection-step
+++ b/cs-bisection-step
@@ -1286,6 +1286,7 @@  END
 
     db_retry($popflight,'constructing', $dbh_tests,[qw(flights)], sub {
         print STDERR "Populating $popflight...\n";
+	undef %jobs_created;
         preparejob($job, $latest_flight, 0);
         foreach my $hostspec (split /,/, $hosts) { # /
             $hostspec =~ m/=/;