diff mbox

[OSSTEST] ts-examine-logs-save: Do not do readdir $! check

Message ID 1495562873-29798-1-git-send-email-ian.jackson@eu.citrix.com (mailing list archive)
State New, archived
Headers show

Commit Message

Ian Jackson May 23, 2017, 6:07 p.m. UTC 
In perl 5.14 in Massachusetts, this produces this message
  /home/logs/logs/109694/test-amd64-amd64-examine Bad file descriptor at ./ts-examine-logs-save line 100.

Sadly this means there is no way to tell failure apart from end of
directory.  This patch should be reverted when we have a fixed version
of perl.

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
---
 ts-examine-logs-save | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox

Patch

diff --git a/ts-examine-logs-save b/ts-examine-logs-save
index 014522a..b9c9941 100755
--- a/ts-examine-logs-save
+++ b/ts-examine-logs-save
@@ -97,7 +97,7 @@  sub save_logs () {
 	logm("saving $f");
 	link "$stash/$f", "$td/$f" or die "$stash $td $f $!";
     }
-    die "$stash $!" if $!;
+    # die "$stash $!" if $!;
     closedir D;
 }