| Message ID | 1496322650-4527-1-git-send-email-andrew.cooper3@citrix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Jun 01, 2017 at 02:10:50PM +0100, Andrew Cooper wrote: > The number of buffers is ahead of the buffer list in the argument list. > > Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com> Acked-by: Wei Liu <wei.liu2@citrix.com>
Hi, On 01/06/17 14:11, Wei Liu wrote: > On Thu, Jun 01, 2017 at 02:10:50PM +0100, Andrew Cooper wrote: >> The number of buffers is ahead of the buffer list in the argument list. >> >> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com> > > Acked-by: Wei Liu <wei.liu2@citrix.com> In general I am happy with any documentation update for Xen 4.9: Release-acked-by: Julien Grall <julien.grall@arm.com> Cheers,
diff --git a/xen/include/public/hvm/dm_op.h b/xen/include/public/hvm/dm_op.h index 20c21b6..2a4c3d9 100644 --- a/xen/include/public/hvm/dm_op.h +++ b/xen/include/public/hvm/dm_op.h @@ -391,17 +391,17 @@ DEFINE_XEN_GUEST_HANDLE(xen_dm_op_buf_t); /* ` enum neg_errnoval * ` HYPERVISOR_dm_op(domid_t domid, - * ` xen_dm_op_buf_t bufs[], - * ` unsigned int nr_bufs) + * ` unsigned int nr_bufs, + * ` xen_dm_op_buf_t bufs[]) * ` * * @domid is the domain the hypercall operates on. + * @nr_bufs is the number of buffers in the @bufs array. * @bufs points to an array of buffers where @bufs[0] contains a struct * xen_dm_op, describing the specific device model operation and its * parameters. * @bufs[1..] may be referenced in the parameters for the purposes of * passing extra information to or from the domain. - * @nr_bufs is the number of buffers in the @bufs array. */ #endif /* __XEN_PUBLIC_HVM_DM_OP_H__ */
The number of buffers is ahead of the buffer list in the argument list. Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com> --- CC: George Dunlap <George.Dunlap@eu.citrix.com> CC: Ian Jackson <ian.jackson@eu.citrix.com> CC: Jan Beulich <JBeulich@suse.com> CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> CC: Stefano Stabellini <sstabellini@kernel.org> CC: Tim Deegan <tim@xen.org> CC: Wei Liu <wei.liu2@citrix.com> CC: Paul Durrant <paul.durrant@citrix.com> CC: Julien Grall <julien.grall@arm.com> For 4.9. This is only documentation, but important to get correct seeing as dm_op()s are a new feature in 4.9 --- xen/include/public/hvm/dm_op.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)