| Message ID | 20160919092946.3292-1-olaf@aepfle.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Sep 19, 2016 at 09:29:46AM +0000, Olaf Hering wrote: > Fix commit f6d4cf5 ("docs: document old SUSE/Novell unplug for HVM"). > The values which VMDP used to control either NIC or disk are flipped. > What the code does is: > > case 8: > if (val == 1 ) { > ide_unplug_harddisks(); > } else if (val == 2) { > pci_unplug_netifs(); > net_tap_shutdown_all(); > } > break; > > Signed-off-by: Olaf Hering <olaf@aepfle.de> Acked-by: Wei Liu <wei.liu2@citrix.com>
On Mon, Sep 19, 2016 at 12:16:06PM +0100, Wei Liu wrote: > On Mon, Sep 19, 2016 at 09:29:46AM +0000, Olaf Hering wrote: > > Fix commit f6d4cf5 ("docs: document old SUSE/Novell unplug for HVM"). > > The values which VMDP used to control either NIC or disk are flipped. > > What the code does is: > > > > case 8: > > if (val == 1 ) { > > ide_unplug_harddisks(); > > } else if (val == 2) { > > pci_unplug_netifs(); > > net_tap_shutdown_all(); > > } > > break; > > > > Signed-off-by: Olaf Hering <olaf@aepfle.de> > > Acked-by: Wei Liu <wei.liu2@citrix.com> Pushed.
diff --git a/docs/misc/hvm-emulated-unplug.markdown b/docs/misc/hvm-emulated-unplug.markdown index 70fb024..256cea2 100644 --- a/docs/misc/hvm-emulated-unplug.markdown +++ b/docs/misc/hvm-emulated-unplug.markdown @@ -89,8 +89,8 @@ Novells VMDP. Depending on how VMDP was configured it would control all devices, or either NIC or storage. To control all devices the value 0x1 was written to offset 0x4 in the memory region of the Xen Platform PCI Device. This was supposed to unplug NIC, IDE and SCSI devices. If VMDP -was configured to control just NIC devices it would write the value 0x1 +was configured to control just NIC devices it would write the value 0x2 to offset 0x8. If VMDP was configured to control just storage devices it -would write the value 0x2 to offset 0x8. Starting with VMDP version 1.7 +would write the value 0x1 to offset 0x8. Starting with VMDP version 1.7 (released 2011) the official protocol was used.
Fix commit f6d4cf5 ("docs: document old SUSE/Novell unplug for HVM"). The values which VMDP used to control either NIC or disk are flipped. What the code does is: case 8: if (val == 1 ) { ide_unplug_harddisks(); } else if (val == 2) { pci_unplug_netifs(); net_tap_shutdown_all(); } break; Signed-off-by: Olaf Hering <olaf@aepfle.de> --- docs/misc/hvm-emulated-unplug.markdown | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)