| Message ID | 20200522161240.3748320-5-george.dunlap@citrix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Golang build fixes | expand |
> Signed-off-by: George Dunlap <george.dunlap@citrix.com> Reviewed-by: Nick Rosbrook <rosbrookn@ainfosec.com>
> > Signed-off-by: George Dunlap <george.dunlap@citrix.com> > Reviewed-by: Nick Rosbrook <rosbrookn@ainfosec.com> Oh, I just noticed your commit message calls the variable "XEN_PKG_DIR", but it's actually named "GOXL_PKG_DIR."
> On May 23, 2020, at 5:48 PM, Nick Rosbrook <rosbrookn@gmail.com> wrote: > >>> Signed-off-by: George Dunlap <george.dunlap@citrix.com> >> Reviewed-by: Nick Rosbrook <rosbrookn@ainfosec.com> > > Oh, I just noticed your commit message calls the variable > "XEN_PKG_DIR", but it's actually named "GOXL_PKG_DIR." Oh, weird. I presume the R-b stands if I fix the title? -George
George Dunlap writes ("[PATCH 4/5] golang/xenlight: Use XEN_PKG_DIR variable rather than open-coding"):
> Signed-off-by: George Dunlap <george.dunlap@citrix.com>
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
On Tue, May 26, 2020 at 5:31 AM George Dunlap <George.Dunlap@citrix.com> wrote: > > > > > On May 23, 2020, at 5:48 PM, Nick Rosbrook <rosbrookn@gmail.com> wrote: > > > >>> Signed-off-by: George Dunlap <george.dunlap@citrix.com> > >> Reviewed-by: Nick Rosbrook <rosbrookn@ainfosec.com> > > > > Oh, I just noticed your commit message calls the variable > > "XEN_PKG_DIR", but it's actually named "GOXL_PKG_DIR." > > Oh, weird. I presume the R-b stands if I fix the title? Yes, of course. -NR
diff --git a/tools/golang/xenlight/Makefile b/tools/golang/xenlight/Makefile index 751f916276..6ab36c0aa9 100644 --- a/tools/golang/xenlight/Makefile +++ b/tools/golang/xenlight/Makefile @@ -19,7 +19,7 @@ package: $(XEN_GOPATH)$(GOXL_PKG_DIR) GOXL_GEN_FILES = types.gen.go helpers.gen.go -$(XEN_GOPATH)/src/$(XEN_GOCODE_URL)/xenlight/: xenlight.go $(GOXL_GEN_FILES) +$(XEN_GOPATH)$(GOXL_PKG_DIR): xenlight.go $(GOXL_GEN_FILES) $(INSTALL_DIR) $(XEN_GOPATH)$(GOXL_PKG_DIR) $(INSTALL_DATA) xenlight.go $(XEN_GOPATH)$(GOXL_PKG_DIR) $(INSTALL_DATA) types.gen.go $(XEN_GOPATH)$(GOXL_PKG_DIR)
Signed-off-by: George Dunlap <george.dunlap@citrix.com> --- CC: Ian Jackson <ian.jackson@citrix.com> CC: Wei Liu <wl@xen.org> CC: Nick Rosbrook <rosbrookn@ainfosec.com> --- tools/golang/xenlight/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)