diff mbox

[4/4] IOMMU: unhide messages useful for diagnostics

Message ID 56781C4102000078000C1ED5@prv-mh.provo.novell.com (mailing list archive)
State New, archived
Headers show

Commit Message

Jan Beulich Dec. 21, 2015, 2:35 p.m. UTC 
Undue use of dprintk() lead to many messages useful in diagnosing
issues in the field now being hidden in non-debug (i.e. production)
builds. Re-surface them.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
IOMMU: unhide messages useful for diagnostics

Undue use of dprintk() lead to many messages useful in diagnosing
issues in the field now being hidden in non-debug (i.e. production)
builds. Re-surface them.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/drivers/passthrough/io.c
+++ b/xen/drivers/passthrough/io.c
@@ -543,10 +543,10 @@ int pt_irq_create_bind(
         spin_unlock(&d->event_lock);
 
         if ( iommu_verbose )
-            dprintk(XENLOG_G_INFO,
-                    "d%d: bind: m_gsi=%u g_gsi=%u dev=%02x.%02x.%u intx=%u\n",
-                    d->domain_id, pirq, guest_gsi, bus,
-                    PCI_SLOT(device), PCI_FUNC(device), intx);
+            printk(XENLOG_G_INFO
+                   "d%d: bind: m_gsi=%u g_gsi=%u dev=%02x.%02x.%u intx=%u\n",
+                   d->domain_id, pirq, guest_gsi, bus,
+                   PCI_SLOT(device), PCI_FUNC(device), intx);
         break;
     }
 
@@ -576,11 +576,11 @@ int pt_irq_destroy_bind(
             unsigned int device = pt_irq_bind->u.pci.device;
             unsigned int intx = pt_irq_bind->u.pci.intx;
 
-            dprintk(XENLOG_G_INFO,
-                    "d%d: unbind: m_gsi=%u g_gsi=%u dev=%02x:%02x.%u intx=%u\n",
-                    d->domain_id, machine_gsi, hvm_pci_intx_gsi(device, intx),
-                    pt_irq_bind->u.pci.bus,
-                    PCI_SLOT(device), PCI_FUNC(device), intx);
+            printk(XENLOG_G_INFO
+                   "d%d: unbind: m_gsi=%u g_gsi=%u dev=%02x:%02x.%u intx=%u\n",
+                   d->domain_id, machine_gsi, hvm_pci_intx_gsi(device, intx),
+                   pt_irq_bind->u.pci.bus,
+                   PCI_SLOT(device), PCI_FUNC(device), intx);
         }
         break;
     case PT_IRQ_TYPE_MSI:
@@ -676,10 +676,10 @@ int pt_irq_destroy_bind(
     {
         unsigned int device = pt_irq_bind->u.pci.device;
 
-        dprintk(XENLOG_G_INFO,
-                "d%d %s unmap: m_irq=%u dev=%02x:%02x.%u intx=%u\n",
-                d->domain_id, what, machine_gsi, pt_irq_bind->u.pci.bus,
-                PCI_SLOT(device), PCI_FUNC(device), pt_irq_bind->u.pci.intx);
+        printk(XENLOG_G_INFO
+               "d%d %s unmap: m_irq=%u dev=%02x:%02x.%u intx=%u\n",
+               d->domain_id, what, machine_gsi, pt_irq_bind->u.pci.bus,
+               PCI_SLOT(device), PCI_FUNC(device), pt_irq_bind->u.pci.intx);
     }
 
     return 0;
diff mbox

Patch

--- a/xen/drivers/passthrough/io.c
+++ b/xen/drivers/passthrough/io.c
@@ -543,10 +543,10 @@  int pt_irq_create_bind(
         spin_unlock(&d->event_lock);
 
         if ( iommu_verbose )
-            dprintk(XENLOG_G_INFO,
-                    "d%d: bind: m_gsi=%u g_gsi=%u dev=%02x.%02x.%u intx=%u\n",
-                    d->domain_id, pirq, guest_gsi, bus,
-                    PCI_SLOT(device), PCI_FUNC(device), intx);
+            printk(XENLOG_G_INFO
+                   "d%d: bind: m_gsi=%u g_gsi=%u dev=%02x.%02x.%u intx=%u\n",
+                   d->domain_id, pirq, guest_gsi, bus,
+                   PCI_SLOT(device), PCI_FUNC(device), intx);
         break;
     }
 
@@ -576,11 +576,11 @@  int pt_irq_destroy_bind(
             unsigned int device = pt_irq_bind->u.pci.device;
             unsigned int intx = pt_irq_bind->u.pci.intx;
 
-            dprintk(XENLOG_G_INFO,
-                    "d%d: unbind: m_gsi=%u g_gsi=%u dev=%02x:%02x.%u intx=%u\n",
-                    d->domain_id, machine_gsi, hvm_pci_intx_gsi(device, intx),
-                    pt_irq_bind->u.pci.bus,
-                    PCI_SLOT(device), PCI_FUNC(device), intx);
+            printk(XENLOG_G_INFO
+                   "d%d: unbind: m_gsi=%u g_gsi=%u dev=%02x:%02x.%u intx=%u\n",
+                   d->domain_id, machine_gsi, hvm_pci_intx_gsi(device, intx),
+                   pt_irq_bind->u.pci.bus,
+                   PCI_SLOT(device), PCI_FUNC(device), intx);
         }
         break;
     case PT_IRQ_TYPE_MSI:
@@ -676,10 +676,10 @@  int pt_irq_destroy_bind(
     {
         unsigned int device = pt_irq_bind->u.pci.device;
 
-        dprintk(XENLOG_G_INFO,
-                "d%d %s unmap: m_irq=%u dev=%02x:%02x.%u intx=%u\n",
-                d->domain_id, what, machine_gsi, pt_irq_bind->u.pci.bus,
-                PCI_SLOT(device), PCI_FUNC(device), pt_irq_bind->u.pci.intx);
+        printk(XENLOG_G_INFO
+               "d%d %s unmap: m_irq=%u dev=%02x:%02x.%u intx=%u\n",
+               d->domain_id, what, machine_gsi, pt_irq_bind->u.pci.bus,
+               PCI_SLOT(device), PCI_FUNC(device), pt_irq_bind->u.pci.intx);
     }
 
     return 0;