diff mbox

[3/4] xfs_scrub: kill dead code

Message ID 151760739949.29371.1187587453029792957.stgit@magnolia (mailing list archive)
State Accepted
Headers show

Commit Message

Darrick J. Wong Feb. 2, 2018, 9:36 p.m. UTC 
From: Darrick J. Wong <darrick.wong@oracle.com>

We can't reach the return mess at the bottom of __xfs_scrub_test so get
rid of it.

Fixes-coverity-id: 1428798
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
 scrub/scrub.c |    1 -
 1 file changed, 1 deletion(-)



--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Eric Sandeen Feb. 2, 2018, 9:46 p.m. UTC | #1 
On 2/2/18 3:36 PM, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
> 
> We can't reach the return mess at the bottom of __xfs_scrub_test so get
> rid of it.
> 
> Fixes-coverity-id: 1428798
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>

Reviewed-by: Eric Sandeen <sandeen@redhat.com>

> ---
>  scrub/scrub.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> 
> diff --git a/scrub/scrub.c b/scrub/scrub.c
> index 0dbe11c..6abca2a 100644
> --- a/scrub/scrub.c
> +++ b/scrub/scrub.c
> @@ -602,7 +602,6 @@ _("Kernel %s %s facility not detected."),
>  		str_info(ctx, ctx->mntpoint, "%s", strerror(errno));
>  		return true;
>  	}
> -	return error == 0 || (error && errno != EOPNOTSUPP && errno != ENOTTY);
>  }
>  
>  bool
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/scrub/scrub.c b/scrub/scrub.c
index 0dbe11c..6abca2a 100644
--- a/scrub/scrub.c
+++ b/scrub/scrub.c
@@ -602,7 +602,6 @@  _("Kernel %s %s facility not detected."),
 		str_info(ctx, ctx->mntpoint, "%s", strerror(errno));
 		return true;
 	}
-	return error == 0 || (error && errno != EOPNOTSUPP && errno != ENOTTY);
 }
 
 bool