| Message ID | 1539201682-22198-11-git-send-email-sandeen@redhat.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | xfsprogs: finer-grained sparse fixes | expand |
On Wed, Oct 10, 2018 at 03:01:14PM -0500, Eric Sandeen wrote: > These are flagged by the sparse checker as possibly static. > They are actually not used at this point; avl64.c has a few unused > functions and/or ones that could be made static, but for now just silence > the warnings, and save deeper surgery for later. > > Signed-off-by: Eric Sandeen <sandeen@redhat.com> They've been unused for how long? I'd favor just removing them, but until that happens: Reviewed-by: Christoph Hellwig <hch@lst.de>
diff --git a/include/avl64.h b/include/avl64.h index 7a66883..4042f6c 100644 --- a/include/avl64.h +++ b/include/avl64.h @@ -69,6 +69,12 @@ avl64_insert_immediate( avl64node_t *afterp, avl64node_t *newnode); +avl64node_t * +avl64_firstino(avl64node_t *root); + +avl64node_t * +avl64_lastino(avl64node_t *root); + void avl64_init_tree( avl64tree_desc_t *tree,
These are flagged by the sparse checker as possibly static. They are actually not used at this point; avl64.c has a few unused functions and/or ones that could be made static, but for now just silence the warnings, and save deeper surgery for later. Signed-off-by: Eric Sandeen <sandeen@redhat.com> --- include/avl64.h | 6 ++++++ 1 file changed, 6 insertions(+)