diff mbox series

[02/36] configure: use sys/xattr.h for fsetxattr detection

Message ID 155259743543.31886.18053722203157328922.stgit@magnolia (mailing list archive)
State Accepted
Headers show
Series xfsprogs-5.0: fix various problems | expand

Commit Message

Darrick J. Wong March 14, 2019, 9:03 p.m. UTC 
From: Darrick J. Wong <darrick.wong@oracle.com>

The only user of fsetxattr and HAVE_FSETXATTR is fsr, which includes
sys/xattr.h (from libc).  However, the m4 macro to detect fsetxattr
support requires attr/xattr.h (from libattr).  libattr dropped xattr.h
last year, so update the check.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
---
 m4/package_libcdev.m4 |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Allison Henderson March 15, 2019, 10:01 p.m. UTC | #1 
Looks ok to me.

Reviewed-by: Allison Henderson <allison.henderson@oracle.com>

On 3/14/19 2:03 PM, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
> 
> The only user of fsetxattr and HAVE_FSETXATTR is fsr, which includes
> sys/xattr.h (from libc).  However, the m4 macro to detect fsetxattr
> support requires attr/xattr.h (from libattr).  libattr dropped xattr.h
> last year, so update the check.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> ---
>   m4/package_libcdev.m4 |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> 
> diff --git a/m4/package_libcdev.m4 b/m4/package_libcdev.m4
> index 7ee4acdd..2c0c72ce 100644
> --- a/m4/package_libcdev.m4
> +++ b/m4/package_libcdev.m4
> @@ -223,14 +223,14 @@ AC_DEFUN([AC_HAVE_FLS],
>     ])
>   
>   #
> -# Check if we have a fsetxattr call (Mac OS X)
> +# Check if we have a fsetxattr call
>   #
>   AC_DEFUN([AC_HAVE_FSETXATTR],
>     [ AC_CHECK_DECL([fsetxattr],
>          have_fsetxattr=yes,
>          [],
>          [#include <sys/types.h>
> -        #include <attr/xattr.h>]
> +        #include <sys/xattr.h>]
>          )
>       AC_SUBST(have_fsetxattr)
>     ])
>
diff mbox series

Patch

diff --git a/m4/package_libcdev.m4 b/m4/package_libcdev.m4
index 7ee4acdd..2c0c72ce 100644
--- a/m4/package_libcdev.m4
+++ b/m4/package_libcdev.m4
@@ -223,14 +223,14 @@  AC_DEFUN([AC_HAVE_FLS],
   ])
 
 #
-# Check if we have a fsetxattr call (Mac OS X)
+# Check if we have a fsetxattr call
 #
 AC_DEFUN([AC_HAVE_FSETXATTR],
   [ AC_CHECK_DECL([fsetxattr],
        have_fsetxattr=yes,
        [],
        [#include <sys/types.h>
-        #include <attr/xattr.h>]
+        #include <sys/xattr.h>]
        )
     AC_SUBST(have_fsetxattr)
   ])