diff mbox series

[03/36] configure.ac: fix alignment of features

Message ID 155259744173.31886.6475707140088498779.stgit@magnolia (mailing list archive)
State Accepted
Headers show
Series xfsprogs-5.0: fix various problems | expand

Commit Message

Darrick J. Wong March 14, 2019, 9:04 p.m. UTC 
From: Darrick J. Wong <darrick.wong@oracle.com>

Fix the alignment of the feature options in the --help screen.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
 configure.ac |   28 ++++++++++++++--------------
 1 file changed, 14 insertions(+), 14 deletions(-)

Comments

Eric Sandeen March 14, 2019, 11:46 p.m. UTC | #1 
On 3/14/19 4:04 PM, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
> 
> Fix the alignment of the feature options in the --help screen.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>

Beauty!

Reviewed-by: Eric Sandeen <sandeen@redhat.com>

> ---
>  configure.ac |   28 ++++++++++++++--------------
>  1 file changed, 14 insertions(+), 14 deletions(-)
> 
> 
> diff --git a/configure.ac b/configure.ac
> index ccc6e292..5a4e55ad 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -28,82 +28,82 @@ if test "${BUILD_CFLAGS+set}" != "set"; then
>  fi
>  
>  AC_ARG_ENABLE(shared,
> -[ --enable-shared=[yes/no] Enable use of shared libraries [default=yes]],,
> +[  --enable-shared=[yes/no]  Enable use of shared libraries [default=yes]],,
>  	enable_shared=yes)
>  AC_SUBST(enable_shared)
>  
>  AC_ARG_ENABLE(gettext,
> -[ --enable-gettext=[yes/no] Enable alternate language support [default=yes]],,
> +[  --enable-gettext=[yes/no] Enable alternate language support [default=yes]],,
>  	enable_gettext=yes)
>  AC_SUBST(enable_gettext)
>  
>  AC_ARG_ENABLE(blkid,
> -[ --enable-blkid=[yes/no] Enable use of block device id library [default=yes]],,
> +[  --enable-blkid=[yes/no]   Enable use of block device id library [default=yes]],,
>  	enable_blkid=yes)
>  AC_SUBST(enable_blkid)
>  
>  AC_ARG_ENABLE(readline,
> -[ --enable-readline=[yes/no] Enable readline command editing [default=no]],
> +[  --enable-readline=[yes/no] Enable readline command editing [default=no]],
>  	test $enable_readline = yes && libreadline="-lreadline",
>  	enable_readline=no)
>  AC_SUBST(libreadline)
>  AC_SUBST(enable_readline)
>  
>  AC_ARG_ENABLE(editline,
> -[ --enable-editline=[yes/no] Enable editline command editing [default=no]],
> +[  --enable-editline=[yes/no] Enable editline command editing [default=no]],
>  	test $enable_editline = yes && libeditline="-ledit",
>  	enable_editline=no)
>  AC_SUBST(libeditline)
>  AC_SUBST(enable_editline)
>  
>  AC_ARG_ENABLE(termcap,
> -[ --enable-termcap=[yes/no] Enable terminal capabilities library [default=no]],
> +[  --enable-termcap=[yes/no] Enable terminal capabilities library [default=no]],
>  	test $enable_termcap = yes && libtermcap="-ltermcap",)
>  AC_SUBST(libtermcap)
>  
>  
>  AC_ARG_ENABLE(lib64,
> -[ --enable-lib64=[yes/no] Enable lib64 support [default=yes]],,
> +[  --enable-lib64=[yes/no]   Enable lib64 support [default=yes]],,
>  	enable_lib64=yes)
>  AC_SUBST(enable_lib64)
>  
>  AC_ARG_ENABLE(librt,
> -[ --enable-librt=[yes/no] Enable librt support [default=yes]],,
> +[  --enable-librt=[yes/no]   Enable librt support [default=yes]],,
>  	enable_librt=yes)
>  AC_SUBST(enable_librt)
>  
>  # Enable UBSAN; set enable_ubsan=probe below to enable autoprobe.
>  AC_ARG_ENABLE(ubsan,
> -[ --enable-ubsan=[yes/no] Enable Undefined Behavior Sanitizer (UBSAN) [default=no]],,
> +[  --enable-ubsan=[yes/no]   Enable Undefined Behavior Sanitizer (UBSAN) [default=no]],,
>  	enable_ubsan=no)
>  AC_SUBST(enable_ubsan)
>  
>  # Enable ADDRSAN; set enable_addrsan=probe below to enable autoprobe.
>  AC_ARG_ENABLE(addrsan,
> -[ --enable-addrsan=[yes/no] Enable Address Sanitizer (ADDRSAN) [default=no]],,
> +[  --enable-addrsan=[yes/no] Enable Address Sanitizer (ADDRSAN) [default=no]],,
>  	enable_addrsan=no)
>  AC_SUBST(enable_addrsan)
>  
>  # Enable THREADSAN; set enable_threadsan=probe to enable autoprobe.
>  AC_ARG_ENABLE(threadsan,
> -[ --enable-threadsan=[yes/no] Enable Thread Sanitizer (THREADSAN) [default=no]],,
> +[  --enable-threadsan=[yes/no] Enable Thread Sanitizer (THREADSAN) [default=no]],,
>  	enable_threadsan=no)
>  AC_SUBST(enable_threadsan)
>  
>  AC_ARG_ENABLE(lto,
> -[ --enable-lto=[yes/no]      Enable link time optimization (LTO) [default=no]],,
> +[  --enable-lto=[yes/no]     Enable link time optimization (LTO) [default=no]],,
>  	enable_lto=no)
>  AC_SUBST(enable_lto)
>  
>  # Enable xfs_scrub build
>  AC_ARG_ENABLE(scrub,
> -[ --enable-scrub=[yes/no]    Enable build of xfs_scrub utility [default=yes]],,
> +[  --enable-scrub=[yes/no]   Enable build of xfs_scrub utility [default=yes]],,
>  	enable_scrub=yes)
>  AC_SUBST(enable_scrub)
>  
>  # Enable libicu for xfs_scrubbing of malicious unicode sequences in names
>  AC_ARG_ENABLE(libicu,
> -[ --enable-libicu=[yes/no]   Enable Unicode name scanning in xfs_scrub (libicu) [default=probe]],,
> +[  --enable-libicu=[yes/no]  Enable Unicode name scanning in xfs_scrub (libicu) [default=probe]],,
>  	enable_libicu=probe)
>  
>  #
>
Allison Henderson March 15, 2019, 10:02 p.m. UTC | #2 
Looks good.  Thanks!

Reviewed-by: Allison Henderson <allison.henderson@oracle.com>

On 3/14/19 2:04 PM, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
> 
> Fix the alignment of the feature options in the --help screen.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
>   configure.ac |   28 ++++++++++++++--------------
>   1 file changed, 14 insertions(+), 14 deletions(-)
> 
> 
> diff --git a/configure.ac b/configure.ac
> index ccc6e292..5a4e55ad 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -28,82 +28,82 @@ if test "${BUILD_CFLAGS+set}" != "set"; then
>   fi
>   
>   AC_ARG_ENABLE(shared,
> -[ --enable-shared=[yes/no] Enable use of shared libraries [default=yes]],,
> +[  --enable-shared=[yes/no]  Enable use of shared libraries [default=yes]],,
>   	enable_shared=yes)
>   AC_SUBST(enable_shared)
>   
>   AC_ARG_ENABLE(gettext,
> -[ --enable-gettext=[yes/no] Enable alternate language support [default=yes]],,
> +[  --enable-gettext=[yes/no] Enable alternate language support [default=yes]],,
>   	enable_gettext=yes)
>   AC_SUBST(enable_gettext)
>   
>   AC_ARG_ENABLE(blkid,
> -[ --enable-blkid=[yes/no] Enable use of block device id library [default=yes]],,
> +[  --enable-blkid=[yes/no]   Enable use of block device id library [default=yes]],,
>   	enable_blkid=yes)
>   AC_SUBST(enable_blkid)
>   
>   AC_ARG_ENABLE(readline,
> -[ --enable-readline=[yes/no] Enable readline command editing [default=no]],
> +[  --enable-readline=[yes/no] Enable readline command editing [default=no]],
>   	test $enable_readline = yes && libreadline="-lreadline",
>   	enable_readline=no)
>   AC_SUBST(libreadline)
>   AC_SUBST(enable_readline)
>   
>   AC_ARG_ENABLE(editline,
> -[ --enable-editline=[yes/no] Enable editline command editing [default=no]],
> +[  --enable-editline=[yes/no] Enable editline command editing [default=no]],
>   	test $enable_editline = yes && libeditline="-ledit",
>   	enable_editline=no)
>   AC_SUBST(libeditline)
>   AC_SUBST(enable_editline)
>   
>   AC_ARG_ENABLE(termcap,
> -[ --enable-termcap=[yes/no] Enable terminal capabilities library [default=no]],
> +[  --enable-termcap=[yes/no] Enable terminal capabilities library [default=no]],
>   	test $enable_termcap = yes && libtermcap="-ltermcap",)
>   AC_SUBST(libtermcap)
>   
>   
>   AC_ARG_ENABLE(lib64,
> -[ --enable-lib64=[yes/no] Enable lib64 support [default=yes]],,
> +[  --enable-lib64=[yes/no]   Enable lib64 support [default=yes]],,
>   	enable_lib64=yes)
>   AC_SUBST(enable_lib64)
>   
>   AC_ARG_ENABLE(librt,
> -[ --enable-librt=[yes/no] Enable librt support [default=yes]],,
> +[  --enable-librt=[yes/no]   Enable librt support [default=yes]],,
>   	enable_librt=yes)
>   AC_SUBST(enable_librt)
>   
>   # Enable UBSAN; set enable_ubsan=probe below to enable autoprobe.
>   AC_ARG_ENABLE(ubsan,
> -[ --enable-ubsan=[yes/no] Enable Undefined Behavior Sanitizer (UBSAN) [default=no]],,
> +[  --enable-ubsan=[yes/no]   Enable Undefined Behavior Sanitizer (UBSAN) [default=no]],,
>   	enable_ubsan=no)
>   AC_SUBST(enable_ubsan)
>   
>   # Enable ADDRSAN; set enable_addrsan=probe below to enable autoprobe.
>   AC_ARG_ENABLE(addrsan,
> -[ --enable-addrsan=[yes/no] Enable Address Sanitizer (ADDRSAN) [default=no]],,
> +[  --enable-addrsan=[yes/no] Enable Address Sanitizer (ADDRSAN) [default=no]],,
>   	enable_addrsan=no)
>   AC_SUBST(enable_addrsan)
>   
>   # Enable THREADSAN; set enable_threadsan=probe to enable autoprobe.
>   AC_ARG_ENABLE(threadsan,
> -[ --enable-threadsan=[yes/no] Enable Thread Sanitizer (THREADSAN) [default=no]],,
> +[  --enable-threadsan=[yes/no] Enable Thread Sanitizer (THREADSAN) [default=no]],,
>   	enable_threadsan=no)
>   AC_SUBST(enable_threadsan)
>   
>   AC_ARG_ENABLE(lto,
> -[ --enable-lto=[yes/no]      Enable link time optimization (LTO) [default=no]],,
> +[  --enable-lto=[yes/no]     Enable link time optimization (LTO) [default=no]],,
>   	enable_lto=no)
>   AC_SUBST(enable_lto)
>   
>   # Enable xfs_scrub build
>   AC_ARG_ENABLE(scrub,
> -[ --enable-scrub=[yes/no]    Enable build of xfs_scrub utility [default=yes]],,
> +[  --enable-scrub=[yes/no]   Enable build of xfs_scrub utility [default=yes]],,
>   	enable_scrub=yes)
>   AC_SUBST(enable_scrub)
>   
>   # Enable libicu for xfs_scrubbing of malicious unicode sequences in names
>   AC_ARG_ENABLE(libicu,
> -[ --enable-libicu=[yes/no]   Enable Unicode name scanning in xfs_scrub (libicu) [default=probe]],,
> +[  --enable-libicu=[yes/no]  Enable Unicode name scanning in xfs_scrub (libicu) [default=probe]],,
>   	enable_libicu=probe)
>   
>   #
>
diff mbox series

Patch

diff --git a/configure.ac b/configure.ac
index ccc6e292..5a4e55ad 100644
--- a/configure.ac
+++ b/configure.ac
@@ -28,82 +28,82 @@  if test "${BUILD_CFLAGS+set}" != "set"; then
 fi
 
 AC_ARG_ENABLE(shared,
-[ --enable-shared=[yes/no] Enable use of shared libraries [default=yes]],,
+[  --enable-shared=[yes/no]  Enable use of shared libraries [default=yes]],,
 	enable_shared=yes)
 AC_SUBST(enable_shared)
 
 AC_ARG_ENABLE(gettext,
-[ --enable-gettext=[yes/no] Enable alternate language support [default=yes]],,
+[  --enable-gettext=[yes/no] Enable alternate language support [default=yes]],,
 	enable_gettext=yes)
 AC_SUBST(enable_gettext)
 
 AC_ARG_ENABLE(blkid,
-[ --enable-blkid=[yes/no] Enable use of block device id library [default=yes]],,
+[  --enable-blkid=[yes/no]   Enable use of block device id library [default=yes]],,
 	enable_blkid=yes)
 AC_SUBST(enable_blkid)
 
 AC_ARG_ENABLE(readline,
-[ --enable-readline=[yes/no] Enable readline command editing [default=no]],
+[  --enable-readline=[yes/no] Enable readline command editing [default=no]],
 	test $enable_readline = yes && libreadline="-lreadline",
 	enable_readline=no)
 AC_SUBST(libreadline)
 AC_SUBST(enable_readline)
 
 AC_ARG_ENABLE(editline,
-[ --enable-editline=[yes/no] Enable editline command editing [default=no]],
+[  --enable-editline=[yes/no] Enable editline command editing [default=no]],
 	test $enable_editline = yes && libeditline="-ledit",
 	enable_editline=no)
 AC_SUBST(libeditline)
 AC_SUBST(enable_editline)
 
 AC_ARG_ENABLE(termcap,
-[ --enable-termcap=[yes/no] Enable terminal capabilities library [default=no]],
+[  --enable-termcap=[yes/no] Enable terminal capabilities library [default=no]],
 	test $enable_termcap = yes && libtermcap="-ltermcap",)
 AC_SUBST(libtermcap)
 
 
 AC_ARG_ENABLE(lib64,
-[ --enable-lib64=[yes/no] Enable lib64 support [default=yes]],,
+[  --enable-lib64=[yes/no]   Enable lib64 support [default=yes]],,
 	enable_lib64=yes)
 AC_SUBST(enable_lib64)
 
 AC_ARG_ENABLE(librt,
-[ --enable-librt=[yes/no] Enable librt support [default=yes]],,
+[  --enable-librt=[yes/no]   Enable librt support [default=yes]],,
 	enable_librt=yes)
 AC_SUBST(enable_librt)
 
 # Enable UBSAN; set enable_ubsan=probe below to enable autoprobe.
 AC_ARG_ENABLE(ubsan,
-[ --enable-ubsan=[yes/no] Enable Undefined Behavior Sanitizer (UBSAN) [default=no]],,
+[  --enable-ubsan=[yes/no]   Enable Undefined Behavior Sanitizer (UBSAN) [default=no]],,
 	enable_ubsan=no)
 AC_SUBST(enable_ubsan)
 
 # Enable ADDRSAN; set enable_addrsan=probe below to enable autoprobe.
 AC_ARG_ENABLE(addrsan,
-[ --enable-addrsan=[yes/no] Enable Address Sanitizer (ADDRSAN) [default=no]],,
+[  --enable-addrsan=[yes/no] Enable Address Sanitizer (ADDRSAN) [default=no]],,
 	enable_addrsan=no)
 AC_SUBST(enable_addrsan)
 
 # Enable THREADSAN; set enable_threadsan=probe to enable autoprobe.
 AC_ARG_ENABLE(threadsan,
-[ --enable-threadsan=[yes/no] Enable Thread Sanitizer (THREADSAN) [default=no]],,
+[  --enable-threadsan=[yes/no] Enable Thread Sanitizer (THREADSAN) [default=no]],,
 	enable_threadsan=no)
 AC_SUBST(enable_threadsan)
 
 AC_ARG_ENABLE(lto,
-[ --enable-lto=[yes/no]      Enable link time optimization (LTO) [default=no]],,
+[  --enable-lto=[yes/no]     Enable link time optimization (LTO) [default=no]],,
 	enable_lto=no)
 AC_SUBST(enable_lto)
 
 # Enable xfs_scrub build
 AC_ARG_ENABLE(scrub,
-[ --enable-scrub=[yes/no]    Enable build of xfs_scrub utility [default=yes]],,
+[  --enable-scrub=[yes/no]   Enable build of xfs_scrub utility [default=yes]],,
 	enable_scrub=yes)
 AC_SUBST(enable_scrub)
 
 # Enable libicu for xfs_scrubbing of malicious unicode sequences in names
 AC_ARG_ENABLE(libicu,
-[ --enable-libicu=[yes/no]   Enable Unicode name scanning in xfs_scrub (libicu) [default=probe]],,
+[  --enable-libicu=[yes/no]  Enable Unicode name scanning in xfs_scrub (libicu) [default=probe]],,
 	enable_libicu=probe)
 
 #