diff mbox series

[5/6] common/populate: don't metadump xfs filesystems twice

Message ID 166500906102.886939.861772249521756043.stgit@magnolia (mailing list archive)
State New, archived
Headers show
Series fstests: random fixes for v2022.09.25 | expand

Commit Message

Darrick J. Wong Oct. 5, 2022, 10:31 p.m. UTC
From: Darrick J. Wong <djwong@kernel.org>

Due to some braino on my part, _scratch_populate_cached will metadump
the filesystem twice -- once with compression disabled, and again with
it enabled, maybe.  Get rid of the first metadump.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
 common/populate |    1 -
 1 file changed, 1 deletion(-)

Comments

Zorro Lang Oct. 8, 2022, 11:12 a.m. UTC | #1
On Wed, Oct 05, 2022 at 03:31:01PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
> 
> Due to some braino on my part, _scratch_populate_cached will metadump
> the filesystem twice -- once with compression disabled, and again with
> it enabled, maybe.  Get rid of the first metadump.
> 
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> ---

Good to me,
Reviewed-by: Zorro Lang <zlang@redhat.com>

>  common/populate |    1 -
>  1 file changed, 1 deletion(-)
> 
> 
> diff --git a/common/populate b/common/populate
> index 9739ac99e0..4eee7e8c66 100644
> --- a/common/populate
> +++ b/common/populate
> @@ -890,7 +890,6 @@ _scratch_populate_cached() {
>  	"xfs")
>  		_scratch_xfs_populate $@
>  		_scratch_xfs_populate_check
> -		_scratch_xfs_metadump "${POPULATE_METADUMP}"
>  
>  		local logdev=
>  		[ "$USE_EXTERNAL" = yes -a ! -z "$SCRATCH_LOGDEV" ] && \
>
diff mbox series

Patch

diff --git a/common/populate b/common/populate
index 9739ac99e0..4eee7e8c66 100644
--- a/common/populate
+++ b/common/populate
@@ -890,7 +890,6 @@  _scratch_populate_cached() {
 	"xfs")
 		_scratch_xfs_populate $@
 		_scratch_xfs_populate_check
-		_scratch_xfs_metadump "${POPULATE_METADUMP}"
 
 		local logdev=
 		[ "$USE_EXTERNAL" = yes -a ! -z "$SCRATCH_LOGDEV" ] && \