diff mbox series

[6/6] common/populate: fix _xfs_metadump usage in _scratch_populate_cached

Message ID 166500906664.886939.1596674456976768238.stgit@magnolia (mailing list archive)
State New, archived
Headers show
Series fstests: random fixes for v2022.09.25 | expand

Commit Message

Darrick J. Wong Oct. 5, 2022, 10:31 p.m. UTC 
From: Darrick J. Wong <djwong@kernel.org>

_xfs_metadump requires that the caller pass in "none" for the log device
if it doesn't have a log device, so fix this call site.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
 common/populate |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Zorro Lang Oct. 8, 2022, 11:12 a.m. UTC | #1 
On Wed, Oct 05, 2022 at 03:31:06PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
> 
> _xfs_metadump requires that the caller pass in "none" for the log device
> if it doesn't have a log device, so fix this call site.
> 
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> ---

Good to me,
Reviewed-by: Zorro Lang <zlang@redhat.com>

>  common/populate |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> 
> diff --git a/common/populate b/common/populate
> index 4eee7e8c66..cfdaf766f0 100644
> --- a/common/populate
> +++ b/common/populate
> @@ -891,7 +891,7 @@ _scratch_populate_cached() {
>  		_scratch_xfs_populate $@
>  		_scratch_xfs_populate_check
>  
> -		local logdev=
> +		local logdev=none
>  		[ "$USE_EXTERNAL" = yes -a ! -z "$SCRATCH_LOGDEV" ] && \
>  			logdev=$SCRATCH_LOGDEV
>  
>
diff mbox series

Patch

diff --git a/common/populate b/common/populate
index 4eee7e8c66..cfdaf766f0 100644
--- a/common/populate
+++ b/common/populate
@@ -891,7 +891,7 @@  _scratch_populate_cached() {
 		_scratch_xfs_populate $@
 		_scratch_xfs_populate_check
 
-		local logdev=
+		local logdev=none
 		[ "$USE_EXTERNAL" = yes -a ! -z "$SCRATCH_LOGDEV" ] && \
 			logdev=$SCRATCH_LOGDEV