diff mbox

[v3,23/23] staging/rdma/hfi1: Update driver version string to 0.9-294

Message ID 1445869729-7507-24-git-send-email-ira.weiny@intel.com (mailing list archive)
State Not Applicable
Headers show

Commit Message

Ira Weiny Oct. 26, 2015, 2:28 p.m. UTC
From: Jubin John <jubin.john@intel.com>

Signed-off-by: Jubin John <jubin.john@intel.com>
Signed-off-by: Ira Weiny <ira.weiny@intel.com>
---
 drivers/staging/rdma/hfi1/common.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Greg KH Oct. 27, 2015, 8:46 a.m. UTC | #1
On Mon, Oct 26, 2015 at 10:28:49AM -0400, ira.weiny@intel.com wrote:
> From: Jubin John <jubin.john@intel.com>
> 
> Signed-off-by: Jubin John <jubin.john@intel.com>
> Signed-off-by: Ira Weiny <ira.weiny@intel.com>
> ---
>  drivers/staging/rdma/hfi1/common.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rdma/hfi1/common.h b/drivers/staging/rdma/hfi1/common.h
> index 7809093eb55e..5dd92720faae 100644
> --- a/drivers/staging/rdma/hfi1/common.h
> +++ b/drivers/staging/rdma/hfi1/common.h
> @@ -205,7 +205,7 @@
>   * to the driver itself, not the software interfaces it supports.
>   */
>  #ifndef HFI1_DRIVER_VERSION_BASE
> -#define HFI1_DRIVER_VERSION_BASE "0.9-248"
> +#define HFI1_DRIVER_VERSION_BASE "0.9-294"

Patches like this make no sense at all, please drop it and only use the
kernel version.  Trust me, it's going to get messy really fast (hint, it
already did...)

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Ira Weiny Oct. 27, 2015, 9 p.m. UTC | #2
On Tue, Oct 27, 2015 at 05:46:41PM +0900, Greg KH wrote:
> On Mon, Oct 26, 2015 at 10:28:49AM -0400, ira.weiny@intel.com wrote:
> > From: Jubin John <jubin.john@intel.com>
> > 
> > Signed-off-by: Jubin John <jubin.john@intel.com>
> > Signed-off-by: Ira Weiny <ira.weiny@intel.com>
> > ---
> >  drivers/staging/rdma/hfi1/common.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/staging/rdma/hfi1/common.h b/drivers/staging/rdma/hfi1/common.h
> > index 7809093eb55e..5dd92720faae 100644
> > --- a/drivers/staging/rdma/hfi1/common.h
> > +++ b/drivers/staging/rdma/hfi1/common.h
> > @@ -205,7 +205,7 @@
> >   * to the driver itself, not the software interfaces it supports.
> >   */
> >  #ifndef HFI1_DRIVER_VERSION_BASE
> > -#define HFI1_DRIVER_VERSION_BASE "0.9-248"
> > +#define HFI1_DRIVER_VERSION_BASE "0.9-294"
> 
> Patches like this make no sense at all, please drop it and only use the
> kernel version.

What do you mean by "only use the kernel version"?  Do you mean

#define HFI1_DRIVER_VERSION_BASE UTS_RELEASE
     
Or just remove the macro entirely?

>
> Trust me, it's going to get messy really fast (hint, it
> already did...)

Did I base this on the wrong tree?  Not sure how this could have messed you up.

Thanks,
Ira

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Greg KH Oct. 27, 2015, 9:15 p.m. UTC | #3
On Tue, Oct 27, 2015 at 05:00:22PM -0400, ira.weiny wrote:
> On Tue, Oct 27, 2015 at 05:46:41PM +0900, Greg KH wrote:
> > On Mon, Oct 26, 2015 at 10:28:49AM -0400, ira.weiny@intel.com wrote:
> > > From: Jubin John <jubin.john@intel.com>
> > > 
> > > Signed-off-by: Jubin John <jubin.john@intel.com>
> > > Signed-off-by: Ira Weiny <ira.weiny@intel.com>
> > > ---
> > >  drivers/staging/rdma/hfi1/common.h | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/staging/rdma/hfi1/common.h b/drivers/staging/rdma/hfi1/common.h
> > > index 7809093eb55e..5dd92720faae 100644
> > > --- a/drivers/staging/rdma/hfi1/common.h
> > > +++ b/drivers/staging/rdma/hfi1/common.h
> > > @@ -205,7 +205,7 @@
> > >   * to the driver itself, not the software interfaces it supports.
> > >   */
> > >  #ifndef HFI1_DRIVER_VERSION_BASE
> > > -#define HFI1_DRIVER_VERSION_BASE "0.9-248"
> > > +#define HFI1_DRIVER_VERSION_BASE "0.9-294"
> > 
> > Patches like this make no sense at all, please drop it and only use the
> > kernel version.
> 
> What do you mean by "only use the kernel version"?  Do you mean
> 
> #define HFI1_DRIVER_VERSION_BASE UTS_RELEASE
>      
> Or just remove the macro entirely?

Remove it entirely, it's pointless and makes no sense for in-kernel
code.

> > Trust me, it's going to get messy really fast (hint, it
> > already did...)
> 
> Did I base this on the wrong tree?  Not sure how this could have messed you up.

Nope, the patch applied just fine, but think about it, I didn't take all
of the patches you sent me, so what exactly does that version number now
represent?  Hint, absolutely nothing, or even worse, something
completely wrong :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/staging/rdma/hfi1/common.h b/drivers/staging/rdma/hfi1/common.h
index 7809093eb55e..5dd92720faae 100644
--- a/drivers/staging/rdma/hfi1/common.h
+++ b/drivers/staging/rdma/hfi1/common.h
@@ -205,7 +205,7 @@ 
  * to the driver itself, not the software interfaces it supports.
  */
 #ifndef HFI1_DRIVER_VERSION_BASE
-#define HFI1_DRIVER_VERSION_BASE "0.9-248"
+#define HFI1_DRIVER_VERSION_BASE "0.9-294"
 #endif
 
 /* create the final driver version string */